All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org,
	"open list:Block layer core" <qemu-block@nongnu.org>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH] tests/iotests: drop test 312 from auto group
Date: Tue, 12 Jan 2021 12:25:56 +0100	[thread overview]
Message-ID: <20210112112556.GA6075@merkur.fritz.box> (raw)
In-Reply-To: <20210105100402.12350-1-alex.bennee@linaro.org>

Am 05.01.2021 um 11:04 hat Alex Bennée geschrieben:
> The "auto" documentation states:
> 
>   That means they should run with every QEMU binary (also non-x86)
> 
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

I think the better solution would be to do something like in 192 so that
the test is still run at least for one binary:

if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
    _notrun "Requires a PC machine"
fi

Kevin



  parent reply	other threads:[~2021-01-12 11:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 10:04 [PATCH] tests/iotests: drop test 312 from auto group Alex Bennée
2021-01-05 10:12 ` Philippe Mathieu-Daudé
2021-01-05 11:51   ` Philippe Mathieu-Daudé
2021-01-05 17:37 ` Max Reitz
2021-01-12 11:25 ` Kevin Wolf [this message]
2021-01-12 14:16   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210112112556.GA6075@merkur.fritz.box \
    --to=kwolf@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.