From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC41FC433DB for ; Tue, 12 Jan 2021 12:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84FDE2310D for ; Tue, 12 Jan 2021 12:39:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731154AbhALMji (ORCPT ); Tue, 12 Jan 2021 07:39:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbhALMjh (ORCPT ); Tue, 12 Jan 2021 07:39:37 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D507C061786; Tue, 12 Jan 2021 04:38:56 -0800 (PST) Received: from zn.tnic (p200300ec2f0e8c004f0317ef2d68091d.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:8c00:4f03:17ef:2d68:91d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 053191EC0249; Tue, 12 Jan 2021 13:38:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1610455135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=lURGhY+Iv5XxPLBY60nqF2mu5aZ9mPyUntpgmLiCz5M=; b=Y6jRwXbkPF6Zrx2LAZ3Ujt/c25wOxBRyzkUDo7pIu3ABZCUPNHevapYd8ucYMSfbYYV3t9 JessYM7sPkBy9HDPfbRWyRfZDveHdIyyNvPn4bqbqkItxSkZl2lWBCjmiJ1vib+FxX0m6e rc2eRyaTa3f8mT6icwPYFSzUxQqu5Yw= Date: Tue, 12 Jan 2021 13:38:54 +0100 From: Borislav Petkov To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu Subject: Re: [PATCH v17 04/26] x86/cpufeatures: Introduce X86_FEATURE_CET and setup functions Message-ID: <20210112123854.GE13086@zn.tnic> References: <20201229213053.16395-5-yu-cheng.yu@intel.com> <20210111230900.5916-1-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210111230900.5916-1-yu-cheng.yu@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 03:09:00PM -0800, Yu-cheng Yu wrote: > @@ -1252,6 +1260,16 @@ static void __init cpu_parse_early_param(void) > if (cmdline_find_option_bool(boot_command_line, "noxsaves")) > setup_clear_cpu_cap(X86_FEATURE_XSAVES); > > + /* > + * CET states are XSAVES states and options must be parsed early. > + */ That comment is redundant - look at the containing function's name. Otherwise patch looks just as it should. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette