Re: [PATCH 2/2] drm/amd/pm: fix one superfluous error for renoir

[Huang Rui <ray.huang@amd.com>]

On Tue, Jan 12, 2021 at 07:35:30PM +0800, Du, Xiaojian wrote:
> From: Xiaojian Du <xiaojian.du@amd.com>
> 
> From: Xiaojian Du <Xiaojian.Du@amd.com>
> 
> This patch is to fix one superfluous error for renoir.
> Renoir supports 5 kinds of power profile mode:
> "FULL SCREEN 3D", "VIDEO", "VR", "COMPUTE" and "CUSTOM".
> After loading amdgpu driver, the driver will set "BOOTUP_DEFAULT"
> mode to APU, and it will get one superfluouserror error,
> which is saying "Unsupported power profile mode 0 on RENOIR",
> but it will not make any other harmful events, so fix this error.
> 
> Signed-off-by: Xiaojian Du <Xiaojian.Du@amd.com>

Series are Reviewed-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
> index 1f6a774278b1..f33f5141cbe1 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
> @@ -835,6 +835,10 @@ static int renoir_set_power_profile_mode(struct smu_context *smu, long *input, u
>  		return -EINVAL;
>  	}
>  
> +	if (profile_mode == PP_SMC_POWER_PROFILE_BOOTUP_DEFAULT ||
> +			profile_mode == PP_SMC_POWER_PROFILE_POWERSAVING)
> +		return 0;
> +
>  	/* conv PP_SMC_POWER_PROFILE* to WORKLOAD_PPLIB_*_BIT */
>  	workload_type = smu_cmn_to_asic_specific_index(smu,
>  						       CMN2ASIC_MAPPING_WORKLOAD,
> -- 
> 2.17.1
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx