From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00483C4332D for ; Tue, 12 Jan 2021 13:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCD0A23136 for ; Tue, 12 Jan 2021 13:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731954AbhALNVd (ORCPT ); Tue, 12 Jan 2021 08:21:33 -0500 Received: from bmailout2.hostsharing.net ([83.223.78.240]:49391 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732265AbhALNVc (ORCPT ); Tue, 12 Jan 2021 08:21:32 -0500 Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id E08F82800B3D8; Tue, 12 Jan 2021 14:20:49 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id D48D850D7E; Tue, 12 Jan 2021 14:20:49 +0100 (CET) Date: Tue, 12 Jan 2021 14:20:49 +0100 From: Lukas Wunner To: Linus Torvalds Cc: Will Deacon , Peter Zijlstra , Arnd Bergmann , Russell King - ARM Linux admin , linux-toolchains@vger.kernel.org, Mark Rutland , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Message-ID: <20210112132049.GA26096@wunner.de> References: <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> <20210108092655.GA4031@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 08, 2021 at 12:02:53PM -0800, Linus Torvalds wrote: > I appreciate Arnd pointing out "--std=gnu11", though. What are the > actual relevant language improvements? > > Variable declarations in for-loops is the only one I can think of. I > think that would clean up some code (and some macros), but might not > be compelling on its own. Anonymous structs/unions. I used to have a use case for that in struct efi_dev_path in include/linux/efi.h, but Ard Biesheuvel refactored it in a gnu89-compatible way for v5.7 with db8952e7094f. [The above was copy-pasted from last time this discussion came up in July 2020. Back then, Kirill Shutemov likewise mentioned the local variables in loops feature: https://lore.kernel.org/lkml/20200710111724.m4jaci73pykalxys@wunner.de/ ] Thanks, Lukas