From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A617AC433E9 for ; Tue, 12 Jan 2021 13:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D57E22B30 for ; Tue, 12 Jan 2021 13:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389430AbhALNpW (ORCPT ); Tue, 12 Jan 2021 08:45:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389332AbhALNpQ (ORCPT ); Tue, 12 Jan 2021 08:45:16 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B437C061786 for ; Tue, 12 Jan 2021 05:44:34 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id d26so2520342wrb.12 for ; Tue, 12 Jan 2021 05:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7+CygbaNK8RHrTYKRH9okC/C8+mWeFn+wpyKag9alwM=; b=nb2va2lASe6ml4oEgsCucR2h4msVpa/5PWlMPxNIr3yB+4cvOjhdTE4RKYQEzeFzzH oiivQ5vvm9GCeZww1BgVbRfNGh2y18UHOlMD5gMo9D7R7/IwddYyhB3/IncauhM8P8bf NSQ8Vz40gJ2a9+HkIYXJCKt0hH8yCvN578LOFHcfXSesl/qX0XCieF7bXmUVuX3YZ79g LjbJosVcLaZCikduTj06Ie7qp7NMICNlavL6di1bEZID437VdvD1uMnAgkz8/EaVqjc3 5vuoIamKNyat/YfZ9MQPmNxb0lNrt9GiGTHGEciDLlWOgc3bGaFpr8SyUzAb8qzTfwPo IHmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7+CygbaNK8RHrTYKRH9okC/C8+mWeFn+wpyKag9alwM=; b=TAfPuaX+cOln69bj/6nAGhTU43khYRgpOAxZfl13Svua9z/ywaYan9+WbeQcy2vNVh ox+bCCy0XZfW4ODl0WizjpU+yTOa5KqNmk4U1tF4fJsAELqqp7v/iG4L0o8AREjZQUFK d+rEcNjEwU7PLJfMBfzS5hxi+NfHcccaHwp00UXAGxvsqGjyJpB6MXKZQTDL1ESN2ODI v6P400ysmUdjFI8+Bog+1viAwv47dWiE5GrG30pRLSQKifCsG+muPGNKECPys7lqYQTh 0XJD0Qe41vsCM7R79lhCXP/SUxP9s8VbbG9FhE2fPMAkhEwNAMSVpYABume4dfmQ09mo RGEQ== X-Gm-Message-State: AOAM533NIjsfo3cxeKdDSljCMoZBYqYaGMBibmD3ULqM3mv3/IUqqdjS y7DlOY55PnbKeUGLJs8H6//3HpFbCwwPipjl X-Google-Smtp-Source: ABdhPJzZqlNguZvDKi2CFA1mo99Wnpi9WTqm4JhWMkWTz2Hy16qA5C3yjzwttwDyYbr3GW6kYbgLUg== X-Received: by 2002:adf:e84f:: with SMTP id d15mr4464921wrn.245.1610459072649; Tue, 12 Jan 2021 05:44:32 -0800 (PST) Received: from dell ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id y68sm4561267wmc.0.2021.01.12.05.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 05:44:32 -0800 (PST) Date: Tue, 12 Jan 2021 13:44:30 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Harry Wentland , Leo Li , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter , Colin Ian King , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 13/40] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap Message-ID: <20210112134430.GA3975472@dell> References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-14-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210111191926.3688443-14-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Jan 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function ‘calculate_bandwidth’: > drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2016:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian König" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Colin Ian King > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > .../gpu/drm/amd/display/dc/calcs/dce_calcs.c | 21 +++++++++++++++---- > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c > index 158d927c03e55..a0c69fae40ced 100644 > --- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c > +++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c > @@ -98,16 +98,16 @@ static void calculate_bandwidth( > int32_t num_cursor_lines; > > int32_t i, j, k; > - struct bw_fixed yclk[3]; > - struct bw_fixed sclk[8]; > + struct bw_fixed *yclk; > + struct bw_fixed *sclk; > bool d0_underlay_enable; > bool d1_underlay_enable; > bool fbc_enabled; > bool lpt_enabled; > enum bw_defines sclk_message; > enum bw_defines yclk_message; > - enum bw_defines tiling_mode[maximum_number_of_surfaces]; > - enum bw_defines surface_type[maximum_number_of_surfaces]; > + enum bw_defines *tiling_mode; > + enum bw_defines *surface_type; > enum bw_defines voltage; > enum bw_defines pipe_check; > enum bw_defines hsr_check; > @@ -122,6 +122,14 @@ static void calculate_bandwidth( > int32_t number_of_displays_enabled_with_margin = 0; > int32_t number_of_aligned_displays_with_no_margin = 0; > > + yclk = kzalloc(sizeof(*yclk) * 3, GFP_KERNEL); > + sclk = kzalloc(sizeof(*sclk) * 8, GFP_KERNEL); > + > + tiling_mode = kzalloc(sizeof(*tiling_mode) * > + maximum_number_of_surfaces, GFP_KERNEL); > + surface_type = kzalloc(sizeof(*surface_type) * > + maximum_number_of_surfaces, GFP_KERNEL); Please refrain from merging this yet. I missed some error checking. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50098C433E0 for ; Tue, 12 Jan 2021 13:44:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 180262222B for ; Tue, 12 Jan 2021 13:44:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 180262222B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DB42A6E226; Tue, 12 Jan 2021 13:44:35 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C7356E226 for ; Tue, 12 Jan 2021 13:44:33 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id d13so2515847wrc.13 for ; Tue, 12 Jan 2021 05:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7+CygbaNK8RHrTYKRH9okC/C8+mWeFn+wpyKag9alwM=; b=nb2va2lASe6ml4oEgsCucR2h4msVpa/5PWlMPxNIr3yB+4cvOjhdTE4RKYQEzeFzzH oiivQ5vvm9GCeZww1BgVbRfNGh2y18UHOlMD5gMo9D7R7/IwddYyhB3/IncauhM8P8bf NSQ8Vz40gJ2a9+HkIYXJCKt0hH8yCvN578LOFHcfXSesl/qX0XCieF7bXmUVuX3YZ79g LjbJosVcLaZCikduTj06Ie7qp7NMICNlavL6di1bEZID437VdvD1uMnAgkz8/EaVqjc3 5vuoIamKNyat/YfZ9MQPmNxb0lNrt9GiGTHGEciDLlWOgc3bGaFpr8SyUzAb8qzTfwPo IHmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7+CygbaNK8RHrTYKRH9okC/C8+mWeFn+wpyKag9alwM=; b=NNxROnVCdDT4bNEbev4ZnfEFP/3/hpLxQsEKMc7fnJY6mSKIdWSjAmyt1ikpMZ+oRs 0QFHbkXLxF2f3Rilz5+Is5X08YkzkOrQZPYybJ9MzpWVjysFjJuJ0iSS3fj8jAOP3ZYa ZOJ+j8LIU/ft+rGwxVnp+DfOeLdAVafK5vNyZeD4P5l/AsuqlnkKoHuhytMSsrbroaLQ UU75D0I0Mqs9PATrKQCZHi2BaZixB4b9K8RO1PnhQID6wOGhhqqdgkOiocHozIFzAIIK iIK1WfTgBAc8nbE9UD9QfDS91n7vqwVUJwP0xlPOGo64EjJ04akzey1oR4tHI6GYHqFt H1lQ== X-Gm-Message-State: AOAM530ixM677F1brLl3R9D3SXKBiOWomWIGyLNEn/lnY2UCz5ztjY1+ mv1KyGWRkuAmnggJWRiJw2toSQ== X-Google-Smtp-Source: ABdhPJzZqlNguZvDKi2CFA1mo99Wnpi9WTqm4JhWMkWTz2Hy16qA5C3yjzwttwDyYbr3GW6kYbgLUg== X-Received: by 2002:adf:e84f:: with SMTP id d15mr4464921wrn.245.1610459072649; Tue, 12 Jan 2021 05:44:32 -0800 (PST) Received: from dell ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id y68sm4561267wmc.0.2021.01.12.05.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 05:44:32 -0800 (PST) Date: Tue, 12 Jan 2021 13:44:30 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Harry Wentland , Leo Li , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter , Colin Ian King , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 13/40] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap Message-ID: <20210112134430.GA3975472@dell> References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-14-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210111191926.3688443-14-lee.jones@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAxMSBKYW4gMjAyMSwgTGVlIEpvbmVzIHdyb3RlOgoKPiBGaXhlcyB0aGUgZm9sbG93 aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiAKPiAgZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvLi4vZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYzogSW4gZnVuY3Rpb24g4oCY Y2FsY3VsYXRlX2JhbmR3aWR0aOKAmToKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4v ZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYzoyMDE2OjE6IHdhcm5pbmc6IHRoZSBmcmFtZSBz aXplIG9mIDEyMTYgYnl0ZXMgaXMgbGFyZ2VyIHRoYW4gMTAyNCBieXRlcyBbLVdmcmFtZS1sYXJn ZXItdGhhbj1dCj4gCj4gQ2M6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29t Pgo+IENjOiBMZW8gTGkgPHN1bnBlbmcubGlAYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxh bGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4Lmll Pgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IENvbGluIElhbiBL aW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQt b2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICAuLi4vZ3B1 L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYyAgfCAyMSArKysrKysrKysrKysr KystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3Mv ZGNlX2NhbGNzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2Nh bGNzLmMKPiBpbmRleCAxNThkOTI3YzAzZTU1Li5hMGM2OWZhZTQwY2VkIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYwo+IEBAIC05 OCwxNiArOTgsMTYgQEAgc3RhdGljIHZvaWQgY2FsY3VsYXRlX2JhbmR3aWR0aCgKPiAgCWludDMy X3QgbnVtX2N1cnNvcl9saW5lczsKPiAgCj4gIAlpbnQzMl90IGksIGosIGs7Cj4gLQlzdHJ1Y3Qg YndfZml4ZWQgeWNsa1szXTsKPiAtCXN0cnVjdCBid19maXhlZCBzY2xrWzhdOwo+ICsJc3RydWN0 IGJ3X2ZpeGVkICp5Y2xrOwo+ICsJc3RydWN0IGJ3X2ZpeGVkICpzY2xrOwo+ICAJYm9vbCBkMF91 bmRlcmxheV9lbmFibGU7Cj4gIAlib29sIGQxX3VuZGVybGF5X2VuYWJsZTsKPiAgCWJvb2wgZmJj X2VuYWJsZWQ7Cj4gIAlib29sIGxwdF9lbmFibGVkOwo+ICAJZW51bSBid19kZWZpbmVzIHNjbGtf bWVzc2FnZTsKPiAgCWVudW0gYndfZGVmaW5lcyB5Y2xrX21lc3NhZ2U7Cj4gLQllbnVtIGJ3X2Rl ZmluZXMgdGlsaW5nX21vZGVbbWF4aW11bV9udW1iZXJfb2Zfc3VyZmFjZXNdOwo+IC0JZW51bSBi d19kZWZpbmVzIHN1cmZhY2VfdHlwZVttYXhpbXVtX251bWJlcl9vZl9zdXJmYWNlc107Cj4gKwll bnVtIGJ3X2RlZmluZXMgKnRpbGluZ19tb2RlOwo+ICsJZW51bSBid19kZWZpbmVzICpzdXJmYWNl X3R5cGU7Cj4gIAllbnVtIGJ3X2RlZmluZXMgdm9sdGFnZTsKPiAgCWVudW0gYndfZGVmaW5lcyBw aXBlX2NoZWNrOwo+ICAJZW51bSBid19kZWZpbmVzIGhzcl9jaGVjazsKPiBAQCAtMTIyLDYgKzEy MiwxNCBAQCBzdGF0aWMgdm9pZCBjYWxjdWxhdGVfYmFuZHdpZHRoKAo+ICAJaW50MzJfdCBudW1i ZXJfb2ZfZGlzcGxheXNfZW5hYmxlZF93aXRoX21hcmdpbiA9IDA7Cj4gIAlpbnQzMl90IG51bWJl cl9vZl9hbGlnbmVkX2Rpc3BsYXlzX3dpdGhfbm9fbWFyZ2luID0gMDsKPiAgCj4gKwl5Y2xrID0g a3phbGxvYyhzaXplb2YoKnljbGspICogMywgR0ZQX0tFUk5FTCk7Cj4gKwlzY2xrID0ga3phbGxv YyhzaXplb2YoKnNjbGspICogOCwgR0ZQX0tFUk5FTCk7Cj4gKwo+ICsJdGlsaW5nX21vZGUgPSBr emFsbG9jKHNpemVvZigqdGlsaW5nX21vZGUpICoKPiArCQkJICAgICAgbWF4aW11bV9udW1iZXJf b2Zfc3VyZmFjZXMsIEdGUF9LRVJORUwpOwo+ICsJc3VyZmFjZV90eXBlID0ga3phbGxvYyhzaXpl b2YoKnN1cmZhY2VfdHlwZSkgKgo+ICsJCQkgICAgICAgbWF4aW11bV9udW1iZXJfb2Zfc3VyZmFj ZXMsIEdGUF9LRVJORUwpOwoKUGxlYXNlIHJlZnJhaW4gZnJvbSBtZXJnaW5nIHRoaXMgeWV0LiAg SSBtaXNzZWQgc29tZSBlcnJvciBjaGVja2luZy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10K U2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSC IE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9v ayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCC2C433E0 for ; Tue, 12 Jan 2021 14:18:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 071F92311D for ; Tue, 12 Jan 2021 14:18:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 071F92311D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5BAD66E243; Tue, 12 Jan 2021 14:18:51 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06EE66E223 for ; Tue, 12 Jan 2021 13:44:33 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id c5so2550014wrp.6 for ; Tue, 12 Jan 2021 05:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7+CygbaNK8RHrTYKRH9okC/C8+mWeFn+wpyKag9alwM=; b=nb2va2lASe6ml4oEgsCucR2h4msVpa/5PWlMPxNIr3yB+4cvOjhdTE4RKYQEzeFzzH oiivQ5vvm9GCeZww1BgVbRfNGh2y18UHOlMD5gMo9D7R7/IwddYyhB3/IncauhM8P8bf NSQ8Vz40gJ2a9+HkIYXJCKt0hH8yCvN578LOFHcfXSesl/qX0XCieF7bXmUVuX3YZ79g LjbJosVcLaZCikduTj06Ie7qp7NMICNlavL6di1bEZID437VdvD1uMnAgkz8/EaVqjc3 5vuoIamKNyat/YfZ9MQPmNxb0lNrt9GiGTHGEciDLlWOgc3bGaFpr8SyUzAb8qzTfwPo IHmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7+CygbaNK8RHrTYKRH9okC/C8+mWeFn+wpyKag9alwM=; b=UNpuv88fdAX1KeCi80DLuxCm1HMPDOy28fAbacmjJ8pR/bpIA2UAt2RqELIuFWm9B0 xdZgKs4d0TJoqMoDJQ/tdJwiUr+uwvyR69UxLES4Im6An485hI8m8Q/kaiIOmcsZI+z3 aWFDVbN1ZBNVglm0HpzDmzkTfa+Y4cqnF08PEmtSaRcAFQXUjPSAJs1WYR1Pma3+6rz5 Uwm7muVCpa16L13px5ZghTQRSVc4rQfxT+cxHGVvk8RuDkxP1TxUR7tBoMEdCfjusox8 9uVmXgcXuVsMyOF0gzYCMe4AuMiU9NxTiSc3AwbnTgpTGS0A3qa/imGcag9ydF2rWaeB 2klg== X-Gm-Message-State: AOAM531zVEdAKtTIvQ9zEXNyBd9CDZUtOOevR2J6n3y2EgSKG6V71T9l 4Ox5IyUtoDwh9VXaJgXeJ7BYoQ== X-Google-Smtp-Source: ABdhPJzZqlNguZvDKi2CFA1mo99Wnpi9WTqm4JhWMkWTz2Hy16qA5C3yjzwttwDyYbr3GW6kYbgLUg== X-Received: by 2002:adf:e84f:: with SMTP id d15mr4464921wrn.245.1610459072649; Tue, 12 Jan 2021 05:44:32 -0800 (PST) Received: from dell ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id y68sm4561267wmc.0.2021.01.12.05.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 05:44:32 -0800 (PST) Date: Tue, 12 Jan 2021 13:44:30 +0000 From: Lee Jones To: linux-kernel@vger.kernel.org, Harry Wentland , Leo Li , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter , Colin Ian King , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 13/40] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap Message-ID: <20210112134430.GA3975472@dell> References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-14-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210111191926.3688443-14-lee.jones@linaro.org> X-Mailman-Approved-At: Tue, 12 Jan 2021 14:18:50 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gTW9uLCAxMSBKYW4gMjAyMSwgTGVlIEpvbmVzIHdyb3RlOgoKPiBGaXhlcyB0aGUgZm9sbG93 aW5nIFc9MSBrZXJuZWwgYnVpbGQgd2FybmluZyhzKToKPiAKPiAgZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvLi4vZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYzogSW4gZnVuY3Rpb24g4oCY Y2FsY3VsYXRlX2JhbmR3aWR0aOKAmToKPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4v ZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYzoyMDE2OjE6IHdhcm5pbmc6IHRoZSBmcmFtZSBz aXplIG9mIDEyMTYgYnl0ZXMgaXMgbGFyZ2VyIHRoYW4gMTAyNCBieXRlcyBbLVdmcmFtZS1sYXJn ZXItdGhhbj1dCj4gCj4gQ2M6IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29t Pgo+IENjOiBMZW8gTGkgPHN1bnBlbmcubGlAYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxh bGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4Lmll Pgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IENvbGluIElhbiBL aW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQt b2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICAuLi4vZ3B1 L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYyAgfCAyMSArKysrKysrKysrKysr KystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3Mv ZGNlX2NhbGNzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY2FsY3MvZGNlX2Nh bGNzLmMKPiBpbmRleCAxNThkOTI3YzAzZTU1Li5hMGM2OWZhZTQwY2VkIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9kYy9jYWxjcy9kY2VfY2FsY3MuYwo+IEBAIC05 OCwxNiArOTgsMTYgQEAgc3RhdGljIHZvaWQgY2FsY3VsYXRlX2JhbmR3aWR0aCgKPiAgCWludDMy X3QgbnVtX2N1cnNvcl9saW5lczsKPiAgCj4gIAlpbnQzMl90IGksIGosIGs7Cj4gLQlzdHJ1Y3Qg YndfZml4ZWQgeWNsa1szXTsKPiAtCXN0cnVjdCBid19maXhlZCBzY2xrWzhdOwo+ICsJc3RydWN0 IGJ3X2ZpeGVkICp5Y2xrOwo+ICsJc3RydWN0IGJ3X2ZpeGVkICpzY2xrOwo+ICAJYm9vbCBkMF91 bmRlcmxheV9lbmFibGU7Cj4gIAlib29sIGQxX3VuZGVybGF5X2VuYWJsZTsKPiAgCWJvb2wgZmJj X2VuYWJsZWQ7Cj4gIAlib29sIGxwdF9lbmFibGVkOwo+ICAJZW51bSBid19kZWZpbmVzIHNjbGtf bWVzc2FnZTsKPiAgCWVudW0gYndfZGVmaW5lcyB5Y2xrX21lc3NhZ2U7Cj4gLQllbnVtIGJ3X2Rl ZmluZXMgdGlsaW5nX21vZGVbbWF4aW11bV9udW1iZXJfb2Zfc3VyZmFjZXNdOwo+IC0JZW51bSBi d19kZWZpbmVzIHN1cmZhY2VfdHlwZVttYXhpbXVtX251bWJlcl9vZl9zdXJmYWNlc107Cj4gKwll bnVtIGJ3X2RlZmluZXMgKnRpbGluZ19tb2RlOwo+ICsJZW51bSBid19kZWZpbmVzICpzdXJmYWNl X3R5cGU7Cj4gIAllbnVtIGJ3X2RlZmluZXMgdm9sdGFnZTsKPiAgCWVudW0gYndfZGVmaW5lcyBw aXBlX2NoZWNrOwo+ICAJZW51bSBid19kZWZpbmVzIGhzcl9jaGVjazsKPiBAQCAtMTIyLDYgKzEy MiwxNCBAQCBzdGF0aWMgdm9pZCBjYWxjdWxhdGVfYmFuZHdpZHRoKAo+ICAJaW50MzJfdCBudW1i ZXJfb2ZfZGlzcGxheXNfZW5hYmxlZF93aXRoX21hcmdpbiA9IDA7Cj4gIAlpbnQzMl90IG51bWJl cl9vZl9hbGlnbmVkX2Rpc3BsYXlzX3dpdGhfbm9fbWFyZ2luID0gMDsKPiAgCj4gKwl5Y2xrID0g a3phbGxvYyhzaXplb2YoKnljbGspICogMywgR0ZQX0tFUk5FTCk7Cj4gKwlzY2xrID0ga3phbGxv YyhzaXplb2YoKnNjbGspICogOCwgR0ZQX0tFUk5FTCk7Cj4gKwo+ICsJdGlsaW5nX21vZGUgPSBr emFsbG9jKHNpemVvZigqdGlsaW5nX21vZGUpICoKPiArCQkJICAgICAgbWF4aW11bV9udW1iZXJf b2Zfc3VyZmFjZXMsIEdGUF9LRVJORUwpOwo+ICsJc3VyZmFjZV90eXBlID0ga3phbGxvYyhzaXpl b2YoKnN1cmZhY2VfdHlwZSkgKgo+ICsJCQkgICAgICAgbWF4aW11bV9udW1iZXJfb2Zfc3VyZmFj ZXMsIEdGUF9LRVJORUwpOwoKUGxlYXNlIHJlZnJhaW4gZnJvbSBtZXJnaW5nIHRoaXMgeWV0LiAg SSBtaXNzZWQgc29tZSBlcnJvciBjaGVja2luZy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10K U2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSC IE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9v ayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdm eAo=