From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A36D5C433E6 for ; Tue, 12 Jan 2021 18:48:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60DA622C9F for ; Tue, 12 Jan 2021 18:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732584AbhALSsC (ORCPT ); Tue, 12 Jan 2021 13:48:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729408AbhALSsC (ORCPT ); Tue, 12 Jan 2021 13:48:02 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B53C061786 for ; Tue, 12 Jan 2021 10:47:21 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id c22so1988521pgg.13 for ; Tue, 12 Jan 2021 10:47:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hdo2CjRwL8l2YWwyDwjd6+MgVOQ7mgZAA3i8urJGhbs=; b=M7by6JufEKLMDzLaTd9vXvZ011hDGrFfmfhsiu43IfW2HxVOGStBIW9F3E88Xh9/qy vzmBj60x2fAxPecxBgOFK94HGWsTVNFT4gNJ12v78cdQIx5sUgnjlh7EhKNlBHhfnfk2 ADrrAYQwMEwi6Koach7FWR1kahAyBHEbnUttN2ME24++f+NPeIvuq5UwdkqJ10N4U/Yo nG7TLaoCZ00uuoEYZ4fPjty3zZuahaNHrpvQSxq/ArnxdMkI5PqStFwk9EFXOJ26/Ffb A6HaClwNU2keIsV0oLyUAasROLqWA9HqNo2UrdH71w35DvtxXsc/5874wATh99EjT5j1 nUfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hdo2CjRwL8l2YWwyDwjd6+MgVOQ7mgZAA3i8urJGhbs=; b=YfStfmxqDZmQLJnXTRbOlzfRf+8JTdIaKgn/9HiOEmuaFDBvCZOdY3s3JgB+Szbreg CQPJP3dFKCFGWTr8BLAWNEGMlrhfHdoDxRGNksPjQBx9chN+56ogzQRkrpR/eV4CJJYS GOajmTVv6JBqC1l3nyHTtp4jq/zf3aac0VmLsV0I07yMLKTBeCxoTtl40xkO0E0MPP+9 Ea5b3W3eLb12WBN4Vz+YC71PlZvBHw8ABUd/qsa9yeJvUQjZap0md8J9S6PNeRLNTlrt xM9ymEzk49ptnW3Nb+AVjr/p48rTQqDJ5hXWmHr1I8LVMw7IcEtTCr863ujUqfQ+BYqm rBow== X-Gm-Message-State: AOAM533P/zWIjKZBlSj9NuVdpDPtmwQWl8tgtNvl+nYrmJ0ca5vI61gr CuGNWah9nhC6CLPdWV+vzlUKpw== X-Google-Smtp-Source: ABdhPJx3WV1fspkF5IuWOsxX9UJmiyz/NBcYcrWSuy8EAXWCwzWIutcGrOHywQxiPAJQNi5fPb/lgQ== X-Received: by 2002:a63:e:: with SMTP id 14mr410657pga.426.1610477241277; Tue, 12 Jan 2021 10:47:21 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 32sm4498081pgq.80.2021.01.12.10.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:47:20 -0800 (PST) Date: Tue, 12 Jan 2021 11:47:18 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, paul@crapouillou.net, matthias.bgg@gmail.com, agross@kernel.org, patrice.chotard@st.com Subject: Re: [PATCH V6 05/10] remoteproc: imx_rproc: correct err message Message-ID: <20210112184718.GB186830@xps15> References: <1610444359-1857-1-git-send-email-peng.fan@nxp.com> <1610444359-1857-6-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610444359-1857-6-git-send-email-peng.fan@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jan 12, 2021 at 05:39:14PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Peng Fan > Reviewed-by: Mathieu Poirier > Reviewed-by: Mathieu Poirier That was a finger problem on my side, no need to add my RB twice. > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6603e00bb6f4..2a093cea4997 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C568EC433E0 for ; Tue, 12 Jan 2021 18:49:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5743E22B4B for ; Tue, 12 Jan 2021 18:49:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5743E22B4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oFfEvBecYRIaDwpz6hVRn581wqqn0t7QY6cmY0DyTQ8=; b=OoTIf2iDCpXS18B1fgzDMX3YF cwnLI3RW3lGeb9MQ154SZXyYCEf/U93ZdGwbeLiYFvw1oxZBwSWjVs0hg0TabnnIRiESZ23vuUnR1 JUTU8cBN4E1FuGnpU9LrWvyoDWnia0v0oJG+Z7Kwwv1rmlEe3fg7gV+W1qDS41dfCcEV+mjkVSUTT zmTZUbp6kFdPSk4NBEWgY2mM4Z2yw2/FD/hQnfNMltk7CC1PH+3/0XlpESnEjAFjpuA3rhY88j87V TGqz7TAw7s7bTCKiO9AnTaQmc/mI5hF7gDUXkLVGHHcp+8EQIzwi2ePtwlpcKUq1KU/JXbAXzF+9F hDhwNvDag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzOhS-0006EP-Pl; Tue, 12 Jan 2021 18:47:26 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzOhP-0006Cq-66 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 18:47:24 +0000 Received: by mail-pf1-x42d.google.com with SMTP id m6so1914484pfm.6 for ; Tue, 12 Jan 2021 10:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hdo2CjRwL8l2YWwyDwjd6+MgVOQ7mgZAA3i8urJGhbs=; b=M7by6JufEKLMDzLaTd9vXvZ011hDGrFfmfhsiu43IfW2HxVOGStBIW9F3E88Xh9/qy vzmBj60x2fAxPecxBgOFK94HGWsTVNFT4gNJ12v78cdQIx5sUgnjlh7EhKNlBHhfnfk2 ADrrAYQwMEwi6Koach7FWR1kahAyBHEbnUttN2ME24++f+NPeIvuq5UwdkqJ10N4U/Yo nG7TLaoCZ00uuoEYZ4fPjty3zZuahaNHrpvQSxq/ArnxdMkI5PqStFwk9EFXOJ26/Ffb A6HaClwNU2keIsV0oLyUAasROLqWA9HqNo2UrdH71w35DvtxXsc/5874wATh99EjT5j1 nUfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hdo2CjRwL8l2YWwyDwjd6+MgVOQ7mgZAA3i8urJGhbs=; b=tcpngwFHXQCpfOkSpp9DmxtXJmHmWVj96IiDSoMR4xOIfC/jrQ7dyoxBEHuzLSf6bo gcpJaTiMYkgcUOa+sqna0Rjinq9B+qJe+aZ9tBhXZprukWhpHPwJg2ghAkzwSeNv1HcO ExBRJL6pETaCBzuvVqLLTm4VTjI/oO9XQJDdWrB32d9of2EWEU8GtyFPpDKezgm2f8P4 wnFTWmg5rvL4bZyvj2bK9EVhDreeKHQ69DfP5DABv3uTIsIpcKJSR2TplYowqdHui9fc rnK2xeUCxzzfpdfE6JhQFSKQVT+9tmRxVkWKK5E6cT4vzQNKkT8t7Ne/RLpFXmurD2Cg crkA== X-Gm-Message-State: AOAM5312+J6gR43fTBo1WFcaCkKYocSofH87sALpbn84Ai5xEUky3TPA LSGuy2q5o3ZVxY/D2nPAF4pJLN0Njvcg4g== X-Google-Smtp-Source: ABdhPJx3WV1fspkF5IuWOsxX9UJmiyz/NBcYcrWSuy8EAXWCwzWIutcGrOHywQxiPAJQNi5fPb/lgQ== X-Received: by 2002:a63:e:: with SMTP id 14mr410657pga.426.1610477241277; Tue, 12 Jan 2021 10:47:21 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 32sm4498081pgq.80.2021.01.12.10.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:47:20 -0800 (PST) Date: Tue, 12 Jan 2021 11:47:18 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH V6 05/10] remoteproc: imx_rproc: correct err message Message-ID: <20210112184718.GB186830@xps15> References: <1610444359-1857-1-git-send-email-peng.fan@nxp.com> <1610444359-1857-6-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1610444359-1857-6-git-send-email-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_134723_277277_E4CF8F10 X-CRM114-Status: GOOD ( 18.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, patrice.chotard@st.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, paul@crapouillou.net, o.rempel@pengutronix.de, robh+dt@kernel.org, agross@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 12, 2021 at 05:39:14PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > It is using devm_ioremap, so not devm_ioremap_resource. Correct > the error message and print out sa/size. > > Reviewed-by: Bjorn Andersson > Signed-off-by: Peng Fan > Reviewed-by: Mathieu Poirier > Reviewed-by: Mathieu Poirier That was a finger problem on my side, no need to add my RB twice. > --- > drivers/remoteproc/imx_rproc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 6603e00bb6f4..2a093cea4997 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -268,7 +268,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, > att->sa, att->size); > if (!priv->mem[b].cpu_addr) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %#x bytes from %#x\n", att->size, att->sa); > return -ENOMEM; > } > priv->mem[b].sys_addr = att->sa; > @@ -298,7 +298,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > > priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "failed to remap %pr\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel