From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51B1FC43381 for ; Tue, 12 Jan 2021 21:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DE7D23123 for ; Tue, 12 Jan 2021 21:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732503AbhALVrJ (ORCPT ); Tue, 12 Jan 2021 16:47:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:44094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732102AbhALVrC (ORCPT ); Tue, 12 Jan 2021 16:47:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3356023122; Tue, 12 Jan 2021 21:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610487981; bh=UQDaWvLBuUDRI2C+9laV/b1uo1RHw1RpRmTBFWgJcNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P7ORlgNjfyzMEo5za2dbespNyEU4nMoCr33iibDSeVjm3ic4JiE6MkH9aJieisDFE oOBxGZYlvG9fmYrPGZ/6s63dmMqW8eQHWJ+RTVQlfC33HQgpcnpyPPyP5jXiNfeSDn qA4c0Qy1Np5sta1iJOg71HxvP5A3VoCCyvkSHlKEVaHU7oZkMbdj8RHSzavHU20sCu Ir3aT2YN4QvGWD69jJ8elyQaoHzfkpiHI9X35xU5ujS/aEhFcfbLyugVcezBzwajjJ ksHwjrNjRXXHyuY9uRFm8UY5R4bCodT99R0rdfwzU9X6mfImssgWV6Ey7ShvVQaAOQ 3UZJcRW7T+8RA== Date: Tue, 12 Jan 2021 21:46:15 +0000 From: Will Deacon To: Hugh Dickins Cc: Linus Torvalds , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , "Kirill A . Shutemov" , Vinayak Menon , Android Kernel Team Subject: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag Message-ID: <20210112214615.GB10434@willie-the-truck> References: <20210108171517.5290-1-will@kernel.org> <20210111133007.GA7642@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 01:03:29PM -0800, Hugh Dickins wrote: > On Mon, 11 Jan 2021, Will Deacon wrote: > > On Fri, Jan 08, 2021 at 11:34:08AM -0800, Linus Torvalds wrote: > > > On Fri, Jan 8, 2021 at 9:15 AM Will Deacon wrote: > > > > > > > > The big difference in this version is that I have reworked it based on > > > > Kirill's patch which he posted as a follow-up to the original. However, > > > > I can't tell where we've landed on that -- Linus seemed to like it, but > > > > Hugh was less enthusiastic. > > > > > > Yeah, I like it, but I have to admit that it had a disturbingly high > > > number of small details wrong for several versions. I hope you picked > > > up the final version of the code. > > > > I picked the version from here: > > > > https://lore.kernel.org/r/20201229132819.najtavneutnf7ajp@box > > > > and actually, I just noticed that willy spotted a typo in a comment, so > > I'll fix that locally as well as adding the above to a 'Link:' tag for > > reference. > > > > > At the same time, I do think that the "disturbingly high number of > > > issues" was primarily exactly _because_ the old code was so > > > incomprehensible, and I think the end result is much cleaner, so I > > > still like it. > > Just to report that I gave this v2 set a spin on a few (x86_64 and i386) > machines, and found nothing objectionable this time around. Thanks, Hugh. > And the things that I'm unenthusiastic about are exactly those details > that you and Kirill and Linus find unsatisfactory, but awkward to > eliminate: expect no new insights from me! Well, I'll keep you on CC for v3 -- just in case! Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24433C433DB for ; Tue, 12 Jan 2021 21:48:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A403523122 for ; Tue, 12 Jan 2021 21:48:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A403523122 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8GD0koaFaBJQhVFuoRa9AEwnPEApyyO/jPBIRb1D52k=; b=GlhLzl+0aKaUdGiWrqICqtVtF BVNXohrEPQr49flhMvABI9FsQ/tmF6mZFaRcgEDh8Avq7qKvkxtgGAXzfnlWADNnoc65ANueXIkr7 xo3AIg31Xi2jBQnJ6FIrG+KTF2KdWv1LbCP28Kw/519/cNxQ0oXybVp7S7L7QhRxZBb0fFCUZW0xD 82M1/rxmKpZiB246pA43TSvPdlnS/GeSxBC1bRC9B+Pdh6lgxE8biXKGCVU9STCQabmltpEGT3BW0 yPQa3cYDW9JA+K/8Y5ZCvJ4MCw19NLQzQrQcZF/8y6/sRt/zqeI3/LjLtSFWTj9b/V4eH3zHAK25z wAxzAusNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzRUg-0007q1-B3; Tue, 12 Jan 2021 21:46:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzRUc-0007ny-Ed for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 21:46:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3356023122; Tue, 12 Jan 2021 21:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610487981; bh=UQDaWvLBuUDRI2C+9laV/b1uo1RHw1RpRmTBFWgJcNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P7ORlgNjfyzMEo5za2dbespNyEU4nMoCr33iibDSeVjm3ic4JiE6MkH9aJieisDFE oOBxGZYlvG9fmYrPGZ/6s63dmMqW8eQHWJ+RTVQlfC33HQgpcnpyPPyP5jXiNfeSDn qA4c0Qy1Np5sta1iJOg71HxvP5A3VoCCyvkSHlKEVaHU7oZkMbdj8RHSzavHU20sCu Ir3aT2YN4QvGWD69jJ8elyQaoHzfkpiHI9X35xU5ujS/aEhFcfbLyugVcezBzwajjJ ksHwjrNjRXXHyuY9uRFm8UY5R4bCodT99R0rdfwzU9X6mfImssgWV6Ey7ShvVQaAOQ 3UZJcRW7T+8RA== Date: Tue, 12 Jan 2021 21:46:15 +0000 From: Will Deacon To: Hugh Dickins Subject: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag Message-ID: <20210112214615.GB10434@willie-the-truck> References: <20210108171517.5290-1-will@kernel.org> <20210111133007.GA7642@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_164622_683096_C61C882E X-CRM114-Status: GOOD ( 22.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Android Kernel Team , Jan Kara , Minchan Kim , Catalin Marinas , Linux Kernel Mailing List , Linux-MM , Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 11, 2021 at 01:03:29PM -0800, Hugh Dickins wrote: > On Mon, 11 Jan 2021, Will Deacon wrote: > > On Fri, Jan 08, 2021 at 11:34:08AM -0800, Linus Torvalds wrote: > > > On Fri, Jan 8, 2021 at 9:15 AM Will Deacon wrote: > > > > > > > > The big difference in this version is that I have reworked it based on > > > > Kirill's patch which he posted as a follow-up to the original. However, > > > > I can't tell where we've landed on that -- Linus seemed to like it, but > > > > Hugh was less enthusiastic. > > > > > > Yeah, I like it, but I have to admit that it had a disturbingly high > > > number of small details wrong for several versions. I hope you picked > > > up the final version of the code. > > > > I picked the version from here: > > > > https://lore.kernel.org/r/20201229132819.najtavneutnf7ajp@box > > > > and actually, I just noticed that willy spotted a typo in a comment, so > > I'll fix that locally as well as adding the above to a 'Link:' tag for > > reference. > > > > > At the same time, I do think that the "disturbingly high number of > > > issues" was primarily exactly _because_ the old code was so > > > incomprehensible, and I think the end result is much cleaner, so I > > > still like it. > > Just to report that I gave this v2 set a spin on a few (x86_64 and i386) > machines, and found nothing objectionable this time around. Thanks, Hugh. > And the things that I'm unenthusiastic about are exactly those details > that you and Kirill and Linus find unsatisfactory, but awkward to > eliminate: expect no new insights from me! Well, I'll keep you on CC for v3 -- just in case! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel