From: Rob Herring <robh@kernel.org>
To: Adam Ford <aford173@gmail.com>
Cc: linux-clk@vger.kernel.org, aford@beaconembedded.com,
Luca Ceresoli <luca@lucaceresoli.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties
Date: Tue, 12 Jan 2021 21:16:02 -0600 [thread overview]
Message-ID: <20210113031602.GA1443816@robh.at.kernel.org> (raw)
In-Reply-To: <20210106173900.388758-1-aford173@gmail.com>
On Wed, Jan 06, 2021 at 11:38:59AM -0600, Adam Ford wrote:
> There are two registers which can set the load capacitance for
> XTAL1 and XTAL2. These are optional registers when using an
> external crystal. Update the bindings to support them.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> index 2ac1131fd922..e5e55ffb266e 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -59,6 +59,18 @@ properties:
> minItems: 1
> maxItems: 2
>
> + idt,xtal1-load-femtofarads:
> + $ref: /schemas/types.yaml#/definitions/uint32
Already has a type, so you can drop the $ref.
> + minimum: 9000
> + maximum: 25000
> + description: Optional loading capacitor for XTAL1
> +
> + idt,xtal2-load-femtofarads:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 9000
> + maximum: 25000
> + description: Optional loading capacitor for XTAL2
> +
> patternProperties:
> "^OUT[1-4]$":
> type: object
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-01-13 3:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 17:38 [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties Adam Ford
2021-01-06 17:39 ` [RFC 2/2] clk: vc5: Add support for optional load capacitance Adam Ford
2021-01-06 20:45 ` kernel test robot
2021-01-08 22:49 ` Luca Ceresoli
2021-01-09 3:00 ` Adam Ford
2021-01-09 18:02 ` Luca Ceresoli
2021-01-11 16:40 ` Adam Ford
2021-01-12 16:45 ` Luca Ceresoli
2021-01-12 17:00 ` Adam Ford
2021-01-13 14:12 ` Luca Ceresoli
2021-01-13 7:23 ` Stephen Boyd
2021-01-08 22:49 ` [RFC 1/2] dt-bindings: clk: versaclock5: Add load capacitance properties Luca Ceresoli
2021-01-09 2:48 ` Adam Ford
2021-01-13 14:39 ` Luca Ceresoli
2021-01-13 3:16 ` Rob Herring [this message]
2021-01-13 12:31 ` Adam Ford
2021-01-13 14:36 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113031602.GA1443816@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.