Re: [RFC PATCH v2] net: bridge: igmp: Extend IGMP query to be per vlan

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v2] net: bridge: igmp: Extend IGMP query to be per vlan
Date: Wed, 13 Jan 2021 09:21:32 +0800	[thread overview]
Message-ID: <202101130951.ORlcW06g-lkp@intel.com> (raw)
In-Reply-To: <20210112135903.3730765-1-horatiu.vultur@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 3820 bytes --]

Hi Horatiu,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v5.11-rc3 next-20210112]
[cannot apply to sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Horatiu-Vultur/net-bridge-igmp-Extend-IGMP-query-to-be-per-vlan/20210112-220655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git c73a45965dd54a10c368191804b9de661eee1007
config: microblaze-randconfig-c004-20210112 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8d72e3d611eb9514714411569a9a98cda24d04c2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Horatiu-Vultur/net-bridge-igmp-Extend-IGMP-query-to-be-per-vlan/20210112-220655
        git checkout 8d72e3d611eb9514714411569a9a98cda24d04c2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/bridge/br_netlink.c: In function 'br_changelink':
>> net/bridge/br_netlink.c:1197:6: warning: variable 'vid' set but not used [-Wunused-but-set-variable]
    1197 |  u16 vid = 0;
         |      ^~~

vim +/vid +1197 net/bridge/br_netlink.c

  1191	
  1192	static int br_changelink(struct net_device *brdev, struct nlattr *tb[],
  1193				 struct nlattr *data[],
  1194				 struct netlink_ext_ack *extack)
  1195	{
  1196		struct net_bridge *br = netdev_priv(brdev);
> 1197		u16 vid = 0;
  1198		int err;
  1199	
  1200		if (!data)
  1201			return 0;
  1202	
  1203		if (data[IFLA_BR_FORWARD_DELAY]) {
  1204			err = br_set_forward_delay(br, nla_get_u32(data[IFLA_BR_FORWARD_DELAY]));
  1205			if (err)
  1206				return err;
  1207		}
  1208	
  1209		if (data[IFLA_BR_MCAST_QUERIER_VID])
  1210			vid = nla_get_u16(data[IFLA_BR_MCAST_QUERIER_VID]);
  1211	
  1212		if (data[IFLA_BR_HELLO_TIME]) {
  1213			err = br_set_hello_time(br, nla_get_u32(data[IFLA_BR_HELLO_TIME]));
  1214			if (err)
  1215				return err;
  1216		}
  1217	
  1218		if (data[IFLA_BR_MAX_AGE]) {
  1219			err = br_set_max_age(br, nla_get_u32(data[IFLA_BR_MAX_AGE]));
  1220			if (err)
  1221				return err;
  1222		}
  1223	
  1224		if (data[IFLA_BR_AGEING_TIME]) {
  1225			err = br_set_ageing_time(br, nla_get_u32(data[IFLA_BR_AGEING_TIME]));
  1226			if (err)
  1227				return err;
  1228		}
  1229	
  1230		if (data[IFLA_BR_STP_STATE]) {
  1231			u32 stp_enabled = nla_get_u32(data[IFLA_BR_STP_STATE]);
  1232	
  1233			err = br_stp_set_enabled(br, stp_enabled, extack);
  1234			if (err)
  1235				return err;
  1236		}
  1237	
  1238		if (data[IFLA_BR_PRIORITY]) {
  1239			u32 priority = nla_get_u16(data[IFLA_BR_PRIORITY]);
  1240	
  1241			br_stp_set_bridge_priority(br, priority);
  1242		}
  1243	
  1244		if (data[IFLA_BR_VLAN_FILTERING]) {
  1245			u8 vlan_filter = nla_get_u8(data[IFLA_BR_VLAN_FILTERING]);
  1246	
  1247			err = __br_vlan_filter_toggle(br, vlan_filter);
  1248			if (err)
  1249				return err;
  1250		}
  1251	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30578 bytes --]