All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH 3/7] iotests/129: Do not check @busy
Date: Wed, 13 Jan 2021 15:06:12 +0100	[thread overview]
Message-ID: <20210113140616.150283-4-mreitz@redhat.com> (raw)
In-Reply-To: <20210113140616.150283-1-mreitz@redhat.com>

@busy is false when the job is paused, which happens all the time
because that is how jobs yield (e.g. for mirror at least since commit
565ac01f8d3).

Back when 129 was added (2015), perhaps there was no better way of
checking whether the job was still actually running.  Now we have the
@status field (as of 58b295ba52c, i.e. 2018), which can give us exactly
that information.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/129 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index 2fc65ada6a..dd23bb2e5a 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -69,7 +69,7 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
         result = self.vm.qmp("stop")
         self.assert_qmp(result, 'return', {})
         result = self.vm.qmp("query-block-jobs")
-        self.assert_qmp(result, 'return[0]/busy', True)
+        self.assert_qmp(result, 'return[0]/status', 'running')
         self.assert_qmp(result, 'return[0]/ready', False)
 
     def test_drive_mirror(self):
-- 
2.29.2



  parent reply	other threads:[~2021-01-13 14:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 14:06 [PATCH 0/7] iotests/129: Fix it Max Reitz
2021-01-13 14:06 ` [PATCH 1/7] iotests: Move try_remove to iotests.py Max Reitz
2021-01-13 14:25   ` Eric Blake
2021-01-13 14:06 ` [PATCH 2/7] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-13 14:34   ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:43   ` Eric Blake
2021-01-13 14:06 ` Max Reitz [this message]
2021-01-13 14:48   ` [PATCH 3/7] iotests/129: Do not check @busy Eric Blake
2021-01-13 15:01   ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 4/7] iotests/129: Use throttle node Max Reitz
2021-01-13 14:10   ` Max Reitz
2021-01-13 14:53     ` Eric Blake
2021-01-13 15:07     ` Vladimir Sementsov-Ogievskiy
2021-01-13 15:15       ` Max Reitz
2021-01-13 16:46   ` Vladimir Sementsov-Ogievskiy
2021-01-13 17:02     ` Max Reitz
2021-01-13 17:05       ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 5/7] iotests/129: Actually test a commit job Max Reitz
2021-01-13 15:58   ` Eric Blake
2021-01-13 16:52   ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 6/7] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-13 16:03   ` Eric Blake
2021-01-13 17:02   ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:06 ` [PATCH 7/7] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-13 16:04   ` Eric Blake
2021-01-13 14:31 ` [PATCH 0/7] iotests/129: Fix it Vladimir Sementsov-Ogievskiy
2021-01-13 15:19   ` Max Reitz
2021-01-13 15:29     ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:38 ` Kevin Wolf
2021-01-13 14:59   ` Vladimir Sementsov-Ogievskiy
2021-01-13 15:26   ` Max Reitz
2021-01-13 15:43     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210113140616.150283-4-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.