From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99805C43219 for ; Thu, 14 Jan 2021 01:47:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 732842343B for ; Thu, 14 Jan 2021 01:47:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728185AbhANBqh (ORCPT ); Wed, 13 Jan 2021 20:46:37 -0500 Received: from foss.arm.com ([217.140.110.172]:42570 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727012AbhANA55 (ORCPT ); Wed, 13 Jan 2021 19:57:57 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DB191FB; Wed, 13 Jan 2021 16:45:58 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A3073F719; Wed, 13 Jan 2021 16:45:55 -0800 (PST) Date: Thu, 14 Jan 2021 00:45:12 +0000 From: Andre Przywara To: Maxime Ripard Cc: Chen-Yu Tsai , Jernej Skrabec , Icenowy Zheng , Linus Walleij , Rob Herring , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Shuosheng Huang , Yangtao Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 02/21] dt-bindings: pinctrl: Add Allwinner H616 compatible strings Message-ID: <20210114004512.6cc7bd10@slackpad.fritz.box> In-Reply-To: <20201214093728.ehd2362jzclbxwp5@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-3-andre.przywara@arm.com> <20201214093728.ehd2362jzclbxwp5@gilmour> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 14 Dec 2020 10:37:28 +0100 Maxime Ripard wrote: > On Fri, Dec 11, 2020 at 01:19:15AM +0000, Andre Przywara wrote: > > A new SoC, a new compatible string. > > Also we were too miserly with just allowing seven interrupt banks. > > > > Signed-off-by: Andre Przywara > > --- > > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 18 > > ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > index 5240487dfe50..292b05d9ed08 100644 --- > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > +++ > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > @@ -53,6 +53,8 @@ properties: > > - allwinner,sun50i-h5-pinctrl > > - allwinner,sun50i-h6-pinctrl > > - allwinner,sun50i-h6-r-pinctrl > > + - allwinner,sun50i-h616-pinctrl > > + - allwinner,sun50i-h616-r-pinctrl > > - allwinner,suniv-f1c100s-pinctrl > > - nextthing,gr8-pinctrl > > > > @@ -61,7 +63,7 @@ properties: > > > > interrupts: > > minItems: 1 > > - maxItems: 7 > > + maxItems: 8 > > description: > > One interrupt per external interrupt bank supported on the > > controller, sorted by bank number ascending order. > > @@ -91,7 +93,7 @@ properties: > > bank found in the controller > > $ref: /schemas/types.yaml#/definitions/uint32-array > > minItems: 1 > > - maxItems: 5 > > + maxItems: 8 > > > > patternProperties: > > # It's pretty scary, but the basic idea is that: > > @@ -145,6 +147,18 @@ allOf: > > # boards are defining it at the moment so it would generate a > > lot of # warnings. > > > > + - if: > > + properties: > > + compatible: > > + enum: > > + - allwinner,sun50i-h616-pinctrl > > + > > + then: > > + properties: > > + interrupts: > > + minItems: 8 > > + maxItems: 8 > > + > > You don't need to have both if they are equals, and in this particular Mmh, but all the other compatibles have both equal, so what would be the recommended way to describe this? Just minItems? I don't find a good explanation at the moment how to handle an explicit number, other than by enumerating the items explicitly. > case we already check that the maximum is 8 so there's no need to > repeat that check here. Are you referring to the overall "maxItems: 8" above, in the 2nd hunk? While this will become redundant, this is apparently prone to changes (as only "7" would be redundant at the moment), so I would rather not rely on a global limit. Cheers, Andre. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1209CC433E0 for ; Thu, 14 Jan 2021 00:47:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F3A623359 for ; Thu, 14 Jan 2021 00:47:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F3A623359 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y/PGhHHWHob5iRCFCIfE9cUnKkioY9YvBvc6E8Fj94k=; b=N2SZsZUAM+8gzkVVnDx+Z6RtZ G0PCJvx2GICy1196s9WPrZBH8bth08BS1IZWaAeTXviucR/w+R59pJVlNlRugq9d6m+Tvc7QRUu3m 7HzB/CxWNSQAxDJmt28tyOwl1FTQvggF9yTIRDjN0eSr8Fe0NmOS3MIgq39M8EoWAaUCrdtWHhbpI abiq6oLmcwnDpZiJHp2IrTyTp9Jm7RVa7b4VurWT0qHsHhZmWamBlvavw69vswTvdywGxAv831c8T vt7uLmEaKVHNsrUNkrfG4yEHK9TrDyy9If6DOdee/m2ujGQGWOwhuW0n8And9Qr00Zn7AqOYkD/8s KBR77W3ew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzqmA-00029F-Ad; Thu, 14 Jan 2021 00:46:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzqm4-000286-L9 for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 00:46:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DB191FB; Wed, 13 Jan 2021 16:45:58 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3A3073F719; Wed, 13 Jan 2021 16:45:55 -0800 (PST) Date: Thu, 14 Jan 2021 00:45:12 +0000 From: Andre Przywara To: Maxime Ripard Subject: Re: [PATCH v2 02/21] dt-bindings: pinctrl: Add Allwinner H616 compatible strings Message-ID: <20210114004512.6cc7bd10@slackpad.fritz.box> In-Reply-To: <20201214093728.ehd2362jzclbxwp5@gilmour> References: <20201211011934.6171-1-andre.przywara@arm.com> <20201211011934.6171-3-andre.przywara@arm.com> <20201214093728.ehd2362jzclbxwp5@gilmour> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_194604_850992_6AD324FA X-CRM114-Status: GOOD ( 22.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , devicetree@vger.kernel.org, Yangtao Li , Linus Walleij , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Chen-Yu Tsai , =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= , Icenowy Zheng , Shuosheng Huang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 14 Dec 2020 10:37:28 +0100 Maxime Ripard wrote: > On Fri, Dec 11, 2020 at 01:19:15AM +0000, Andre Przywara wrote: > > A new SoC, a new compatible string. > > Also we were too miserly with just allowing seven interrupt banks. > > > > Signed-off-by: Andre Przywara > > --- > > .../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 18 > > ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > index 5240487dfe50..292b05d9ed08 100644 --- > > a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > +++ > > b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > > @@ -53,6 +53,8 @@ properties: > > - allwinner,sun50i-h5-pinctrl > > - allwinner,sun50i-h6-pinctrl > > - allwinner,sun50i-h6-r-pinctrl > > + - allwinner,sun50i-h616-pinctrl > > + - allwinner,sun50i-h616-r-pinctrl > > - allwinner,suniv-f1c100s-pinctrl > > - nextthing,gr8-pinctrl > > > > @@ -61,7 +63,7 @@ properties: > > > > interrupts: > > minItems: 1 > > - maxItems: 7 > > + maxItems: 8 > > description: > > One interrupt per external interrupt bank supported on the > > controller, sorted by bank number ascending order. > > @@ -91,7 +93,7 @@ properties: > > bank found in the controller > > $ref: /schemas/types.yaml#/definitions/uint32-array > > minItems: 1 > > - maxItems: 5 > > + maxItems: 8 > > > > patternProperties: > > # It's pretty scary, but the basic idea is that: > > @@ -145,6 +147,18 @@ allOf: > > # boards are defining it at the moment so it would generate a > > lot of # warnings. > > > > + - if: > > + properties: > > + compatible: > > + enum: > > + - allwinner,sun50i-h616-pinctrl > > + > > + then: > > + properties: > > + interrupts: > > + minItems: 8 > > + maxItems: 8 > > + > > You don't need to have both if they are equals, and in this particular Mmh, but all the other compatibles have both equal, so what would be the recommended way to describe this? Just minItems? I don't find a good explanation at the moment how to handle an explicit number, other than by enumerating the items explicitly. > case we already check that the maximum is 8 so there's no need to > repeat that check here. Are you referring to the overall "maxItems: 8" above, in the 2nd hunk? While this will become redundant, this is apparently prone to changes (as only "7" would be redundant at the moment), so I would rather not rely on a global limit. Cheers, Andre. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel