From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jiri Olsa <jolsa@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-crypto@vger.kernel.org, Qais Yousef <qais.yousef@arm.com>,
Andrii Nakryiko <andriin@fb.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] crypto: Rename struct device_private to bcm_device_private
Date: Thu, 14 Jan 2021 17:46:48 +1100 [thread overview]
Message-ID: <20210114064648.GE12584@gondor.apana.org.au> (raw)
In-Reply-To: <20210104230237.916064-1-jolsa@kernel.org>
On Tue, Jan 05, 2021 at 12:02:37AM +0100, Jiri Olsa wrote:
> Renaming 'struct device_private' to 'struct bcm_device_private',
> because it clashes with 'struct device_private' from
> 'drivers/base/base.h'.
>
> While it's not a functional problem, it's causing two distinct
> type hierarchies in BTF data. It also breaks build with options:
> CONFIG_DEBUG_INFO_BTF=y
> CONFIG_CRYPTO_DEV_BCM_SPU=y
>
> as reported by Qais Yousef [1].
>
> [1] https://lore.kernel.org/lkml/20201229151352.6hzmjvu3qh6p2qgg@e107158-lin/
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> drivers/crypto/bcm/cipher.c | 2 +-
> drivers/crypto/bcm/cipher.h | 4 ++--
> drivers/crypto/bcm/util.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-01-14 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 23:02 [PATCH] crypto: Rename struct device_private to bcm_device_private Jiri Olsa
2021-01-05 10:49 ` Qais Yousef
2021-01-14 6:46 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114064648.GE12584@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qais.yousef@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.