From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF76C433DB for ; Thu, 14 Jan 2021 12:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 327AC239FD for ; Thu, 14 Jan 2021 12:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbhANMld (ORCPT ); Thu, 14 Jan 2021 07:41:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:58966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbhANMld (ORCPT ); Thu, 14 Jan 2021 07:41:33 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2C8F623A53; Thu, 14 Jan 2021 12:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610628052; bh=OxL9TuHjbQbPuPcAueI8mkcZ4/hHYeRATV5+Snzg2sg=; h=From:To:Cc:Subject:Date:From; b=orgFjgQL/Kn0lbejYzUJ0LUwxm1/SMaYz2krykGO0uxLsaSmgJPJgwWiezS7Mpz+V gTD97L8ou/pJL+BcGSYjUiWNUpcp51hfx3/icX5GaP3MHEobVyM1/duQeYPIJ1aj0f NzBZvUwh13mqZrz/CzyVdUYJH2McU8lzNNed9LEnk7v4bdw9VlsAy0hggA73/FV4UC kmyHd3/UQ5d7DSUU2fYvobCg9rUU+qeF1knJMVEE5/v67q7s44wOtZsOSRxsCG9HSb 6Ll1DKQYiGKr0hl7vRpd090BPAAkviVUKz7sw4KRSrsQhdn+q4/gQ/borKL6/FL5WN 3yIHNDxiC5jzw== Received: by pali.im (Postfix) id 9D0CF621; Thu, 14 Jan 2021 13:40:49 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Gregory Clement , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , "Miquel Raynal" , "Tomasz Maciej Nowak" , "Luka Perkov" , "Andre Heider" , "Vladimir Vid" , "Russell King" , =?UTF-8?q?G=C3=A9rald=20Kerma?= , "Konstantin Porotchkin" Subject: [PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz Date: Thu, 14 Jan 2021 13:40:22 +0100 Message-Id: <20210114124032.12765-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! The armada-37xx-cpufreq driver changes base CPU speed from 1000 MHz to 800 MHz on EspressoBIN and Turris MOX. The commit message in patch 2/10 explains why and how can this be discovered. That patch 2/10 led us to discover another bug, in the SOC itself, that causes the CPU to behave weirdly when frequency changes to 1 GHz. A similar erratum is documented by Marvell but only for systems where base frequency is 1.2 GHz. We've discovered that to make cpufreq scaling stable on Armada 3720 systems with base frequency 1 GHz, we also have to set voltage levels for L0 and L1 loads to at least 1108 mV. We were led to this by patch we found in Marvell kernel fork. Fix is in the patch 4/10. https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/dc33b62c90696afb6adc7dbcc4ebbd48bedec269 During fixing this voltage issue for 1 GHz we discovered another bug in armada-37xx-cpufreq driver that causes CPU instability. Erratum for VDD stabilization was improperly implemented, details are in patch 6/10. This patch series is also available in my git tree in branch a3720-cpufreq-issues: https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=a3720-cpufreq-issues We have tested this patch series on Espressobin v5 and Turris MOX boards. If you have other Armada 3720 boards (Espressobin v5/v7, uDPU, Devel Board, ...) then it will be nice to do an additional tests and check if instability issues are finally fixed. There is a discussion on armbian forum that Espressobin v7 is unstable when running at 1 GHz and in this thread was also mentioned above voltage patch from Marvell kernel fork: https://forum.armbian.com/topic/10429-how-to-make-espressobin-v7-stable/ Marek & Pali Marek Behún (3): arm64: dts: marvell: armada-37xx: add syscon compatible to NB clk node cpufreq: armada-37xx: Fix setting TBG parent for load levels clk: mvebu: armada-37xx-periph: remove .set_parent method for CPU PM clock Pali Rohár (7): cpufreq: armada-37xx: Fix the AVS value for loads L0 and L1 clk: mvebu: armada-37xx-periph: Fix switching CPU freq from 250 Mhz to 1 GHz clk: mvebu: armada-37xx-periph: Fix workaround for switching from L1 to L0 cpufreq: armada-37xx: Fix driver cleanup when registration failed cpufreq: armada-37xx: Fix determining base CPU frequency cpufreq: armada-37xx: Remove cur_frequency variable cpufreq: armada-37xx: Fix module unloading arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 3 +- drivers/clk/mvebu/armada-37xx-periph.c | 83 ++++++++------- drivers/cpufreq/armada-37xx-cpufreq.c | 100 ++++++++++++++----- 3 files changed, 124 insertions(+), 62 deletions(-) -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB4C1C433E0 for ; Thu, 14 Jan 2021 12:42:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C5AA239FD for ; Thu, 14 Jan 2021 12:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C5AA239FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=uJyxm5/TmNwqJWZbuZjWEH/hzeaPZOYQWaG+7VDPYDM=; b=bDxbZ2Z2tYU+E0ksSE4NF5xl2u 8SIB1CVSmTHv4gbB5a+3+BX4rrvKveDvFg9yXuxjfXTxVD4EmhSvNWH31qsoDJY0onVA/crbyB4B0 XhfF9PTMYMc/QGWoz8u5un0tY46EOGfnBJa4uaQULPayEa2/ri1xsIi5l50je3w2DYq08S7Qcswzt FQQ/mn5ZzsszxtbV4E8jDXwVtZYdU/UerLBv2jFHzK1wxFK1RgEkG1lZ8UjYf47yY/xcrc0ZOmKcr aXNrUdsCBcuiADhbzTEF6FgcYju0A0dd7E6UHRW8HxNnR7T/frVUYVf9770O072/mIeZZPrlb7U3+ fc53woKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l01vs-0001fI-Oj; Thu, 14 Jan 2021 12:40:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l01vq-0001eg-93 for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 12:40:55 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2C8F623A53; Thu, 14 Jan 2021 12:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610628052; bh=OxL9TuHjbQbPuPcAueI8mkcZ4/hHYeRATV5+Snzg2sg=; h=From:To:Cc:Subject:Date:From; b=orgFjgQL/Kn0lbejYzUJ0LUwxm1/SMaYz2krykGO0uxLsaSmgJPJgwWiezS7Mpz+V gTD97L8ou/pJL+BcGSYjUiWNUpcp51hfx3/icX5GaP3MHEobVyM1/duQeYPIJ1aj0f NzBZvUwh13mqZrz/CzyVdUYJH2McU8lzNNed9LEnk7v4bdw9VlsAy0hggA73/FV4UC kmyHd3/UQ5d7DSUU2fYvobCg9rUU+qeF1knJMVEE5/v67q7s44wOtZsOSRxsCG9HSb 6Ll1DKQYiGKr0hl7vRpd090BPAAkviVUKz7sw4KRSrsQhdn+q4/gQ/borKL6/FL5WN 3yIHNDxiC5jzw== Received: by pali.im (Postfix) id 9D0CF621; Thu, 14 Jan 2021 13:40:49 +0100 (CET) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Gregory Clement , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: [PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz Date: Thu, 14 Jan 2021 13:40:22 +0100 Message-Id: <20210114124032.12765-1-pali@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_074054_455814_7D297744 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?UTF-8?q?G=C3=A9rald=20Kerma?= , Miquel Raynal , Konstantin Porotchkin Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8hCgpUaGUgYXJtYWRhLTM3eHgtY3B1ZnJlcSBkcml2ZXIgY2hhbmdlcyBiYXNlIENQVSBz cGVlZCBmcm9tIDEwMDAgTUh6IHRvCjgwMCBNSHogb24gRXNwcmVzc29CSU4gYW5kIFR1cnJpcyBN T1guIFRoZSBjb21taXQgbWVzc2FnZSBpbiBwYXRjaCAyLzEwCmV4cGxhaW5zIHdoeSBhbmQgaG93 IGNhbiB0aGlzIGJlIGRpc2NvdmVyZWQuCgpUaGF0IHBhdGNoIDIvMTAgbGVkIHVzIHRvIGRpc2Nv dmVyIGFub3RoZXIgYnVnLCBpbiB0aGUgU09DIGl0c2VsZiwKdGhhdCBjYXVzZXMgdGhlIENQVSB0 byBiZWhhdmUgd2VpcmRseSB3aGVuIGZyZXF1ZW5jeSBjaGFuZ2VzIHRvIDEgR0h6LgpBIHNpbWls YXIgZXJyYXR1bSBpcyBkb2N1bWVudGVkIGJ5IE1hcnZlbGwgYnV0IG9ubHkgZm9yIHN5c3RlbXMg d2hlcmUKYmFzZSBmcmVxdWVuY3kgaXMgMS4yIEdIei4KCldlJ3ZlIGRpc2NvdmVyZWQgdGhhdCB0 byBtYWtlIGNwdWZyZXEgc2NhbGluZyBzdGFibGUgb24gQXJtYWRhIDM3MjAKc3lzdGVtcyB3aXRo IGJhc2UgZnJlcXVlbmN5IDEgR0h6LCB3ZSBhbHNvIGhhdmUgdG8gc2V0IHZvbHRhZ2UgbGV2ZWxz CmZvciBMMCBhbmQgTDEgbG9hZHMgdG8gYXQgbGVhc3QgMTEwOCBtVi4gV2Ugd2VyZSBsZWQgdG8g dGhpcyBieSBwYXRjaCB3ZQpmb3VuZCBpbiBNYXJ2ZWxsIGtlcm5lbCBmb3JrLiBGaXggaXMgaW4g dGhlIHBhdGNoIDQvMTAuCgpodHRwczovL2dpdGh1Yi5jb20vTWFydmVsbEVtYmVkZGVkUHJvY2Vz c29ycy9saW51eC1tYXJ2ZWxsL2NvbW1pdC9kYzMzYjYyYzkwNjk2YWZiNmFkYzdkYmNjNGViYmQ0 OGJlZGVjMjY5CgpEdXJpbmcgZml4aW5nIHRoaXMgdm9sdGFnZSBpc3N1ZSBmb3IgMSBHSHogd2Ug ZGlzY292ZXJlZCBhbm90aGVyIGJ1ZyBpbgphcm1hZGEtMzd4eC1jcHVmcmVxIGRyaXZlciB0aGF0 IGNhdXNlcyBDUFUgaW5zdGFiaWxpdHkuIEVycmF0dW0gZm9yIFZERApzdGFiaWxpemF0aW9uIHdh cyBpbXByb3Blcmx5IGltcGxlbWVudGVkLCBkZXRhaWxzIGFyZSBpbiBwYXRjaCA2LzEwLgoKVGhp cyBwYXRjaCBzZXJpZXMgaXMgYWxzbyBhdmFpbGFibGUgaW4gbXkgZ2l0IHRyZWUgaW4gYnJhbmNo IGEzNzIwLWNwdWZyZXEtaXNzdWVzOgoKaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xp bnV4L2tlcm5lbC9naXQvcGFsaS9saW51eC5naXQvbG9nLz9oPWEzNzIwLWNwdWZyZXEtaXNzdWVz CgpXZSBoYXZlIHRlc3RlZCB0aGlzIHBhdGNoIHNlcmllcyBvbiBFc3ByZXNzb2JpbiB2NSBhbmQg VHVycmlzIE1PWApib2FyZHMuIElmIHlvdSBoYXZlIG90aGVyIEFybWFkYSAzNzIwIGJvYXJkcyAo RXNwcmVzc29iaW4gdjUvdjcsIHVEUFUsCkRldmVsIEJvYXJkLCAuLi4pIHRoZW4gaXQgd2lsbCBi ZSBuaWNlIHRvIGRvIGFuIGFkZGl0aW9uYWwgdGVzdHMgYW5kCmNoZWNrIGlmIGluc3RhYmlsaXR5 IGlzc3VlcyBhcmUgZmluYWxseSBmaXhlZC4KClRoZXJlIGlzIGEgZGlzY3Vzc2lvbiBvbiBhcm1i aWFuIGZvcnVtIHRoYXQgRXNwcmVzc29iaW4gdjcgaXMgdW5zdGFibGUKd2hlbiBydW5uaW5nIGF0 IDEgR0h6IGFuZCBpbiB0aGlzIHRocmVhZCB3YXMgYWxzbyBtZW50aW9uZWQgYWJvdmUKdm9sdGFn ZSBwYXRjaCBmcm9tIE1hcnZlbGwga2VybmVsIGZvcms6CgpodHRwczovL2ZvcnVtLmFybWJpYW4u Y29tL3RvcGljLzEwNDI5LWhvdy10by1tYWtlLWVzcHJlc3NvYmluLXY3LXN0YWJsZS8KCk1hcmVr ICYgUGFsaQoKCk1hcmVrIEJlaMO6biAoMyk6CiAgYXJtNjQ6IGR0czogbWFydmVsbDogYXJtYWRh LTM3eHg6IGFkZCBzeXNjb24gY29tcGF0aWJsZSB0byBOQiBjbGsgbm9kZQogIGNwdWZyZXE6IGFy bWFkYS0zN3h4OiBGaXggc2V0dGluZyBUQkcgcGFyZW50IGZvciBsb2FkIGxldmVscwogIGNsazog bXZlYnU6IGFybWFkYS0zN3h4LXBlcmlwaDogcmVtb3ZlIC5zZXRfcGFyZW50IG1ldGhvZCBmb3Ig Q1BVIFBNCiAgICBjbG9jawoKUGFsaSBSb2jDoXIgKDcpOgogIGNwdWZyZXE6IGFybWFkYS0zN3h4 OiBGaXggdGhlIEFWUyB2YWx1ZSBmb3IgbG9hZHMgTDAgYW5kIEwxCiAgY2xrOiBtdmVidTogYXJt YWRhLTM3eHgtcGVyaXBoOiBGaXggc3dpdGNoaW5nIENQVSBmcmVxIGZyb20gMjUwIE1oeiB0bwog ICAgMSBHSHoKICBjbGs6IG12ZWJ1OiBhcm1hZGEtMzd4eC1wZXJpcGg6IEZpeCB3b3JrYXJvdW5k IGZvciBzd2l0Y2hpbmcgZnJvbSBMMQogICAgdG8gTDAKICBjcHVmcmVxOiBhcm1hZGEtMzd4eDog Rml4IGRyaXZlciBjbGVhbnVwIHdoZW4gcmVnaXN0cmF0aW9uIGZhaWxlZAogIGNwdWZyZXE6IGFy bWFkYS0zN3h4OiBGaXggZGV0ZXJtaW5pbmcgYmFzZSBDUFUgZnJlcXVlbmN5CiAgY3B1ZnJlcTog YXJtYWRhLTM3eHg6IFJlbW92ZSBjdXJfZnJlcXVlbmN5IHZhcmlhYmxlCiAgY3B1ZnJlcTogYXJt YWRhLTM3eHg6IEZpeCBtb2R1bGUgdW5sb2FkaW5nCgogYXJjaC9hcm02NC9ib290L2R0cy9tYXJ2 ZWxsL2FybWFkYS0zN3h4LmR0c2kgfCAgIDMgKy0KIGRyaXZlcnMvY2xrL212ZWJ1L2FybWFkYS0z N3h4LXBlcmlwaC5jICAgICAgIHwgIDgzICsrKysrKysrLS0tLS0tLQogZHJpdmVycy9jcHVmcmVx L2FybWFkYS0zN3h4LWNwdWZyZXEuYyAgICAgICAgfCAxMDAgKysrKysrKysrKysrKystLS0tLQog MyBmaWxlcyBjaGFuZ2VkLCAxMjQgaW5zZXJ0aW9ucygrKSwgNjIgZGVsZXRpb25zKC0pCgotLSAK Mi4yMC4xCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=