From: Matthew Wilcox <firstname.lastname@example.org> To: David Howells <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Dominique Martinet <firstname.lastname@example.org>, Steve French <email@example.com>, Trond Myklebust <firstname.lastname@example.org>, Anna Schumaker <email@example.com>, Christoph Hellwig <firstname.lastname@example.org>, email@example.com, Linus Torvalds <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: Re: Redesigning and modernising fscache Date: Thu, 14 Jan 2021 16:19:29 +0000 [thread overview] Message-ID: <20210114161929.GQ35215@casper.infradead.org> (raw) In-Reply-To: <email@example.com> On Thu, Jan 14, 2021 at 10:45:06AM +0000, David Howells wrote: > However, there've been some objections to the approach I've taken to > implementing this. The way I've done it is to disable the use of fscache by > the five network filesystems that use it, remove much of the old code, put in > the reimplementation, then cut the filesystems over. I.e. rip-and-replace. > It leaves unported filesystems unable to use it - but three of the five are > done (afs, ceph, nfs), and I've supplied partially-done patches for the other > two (9p, cifs). > > It's been suggested that it's too hard to review this way and that either I > should go for a gradual phasing in or build the new one in parallel. The > first is difficult because I want to change how almost everything in there > works - but the parts are tied together; the second is difficult because there > are areas that would *have* to overlap (the UAPI device file, the cache > storage, the cache size limits and at least some state for managing these), so > there would have to be interaction between the two variants. One refinement > of the latter would be to make the two implementations mutually exclusive: you > can build one or the other, but not both. My reservation with "build fscache2" is that it's going to take some time to do, and I really want rid of ->readpages as soon as possible. What I'd like to see is netfs_readahead() existing as soon as possible, built on top of the current core. Then filesystems can implement netfs_read_request_ops one by one, and they become insulated from the transition.
next prev parent reply other threads:[~2021-01-14 16:20 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-14 10:45 David Howells 2021-01-14 16:19 ` Matthew Wilcox [this message] 2021-01-18 23:36 ` Cut down implementation of fscache new API David Howells
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210114161929.GQ35215@casper.infradead.org \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Redesigning and modernising fscache' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.