From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CC7C433DB for ; Thu, 14 Jan 2021 20:55:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 379F923A34 for ; Thu, 14 Jan 2021 20:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728878AbhANUzS (ORCPT ); Thu, 14 Jan 2021 15:55:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727949AbhANUzS (ORCPT ); Thu, 14 Jan 2021 15:55:18 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5729FC061757 for ; Thu, 14 Jan 2021 12:54:38 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id x18so3539863pln.6 for ; Thu, 14 Jan 2021 12:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jD7vbDbD0h84CsDujjRSLvXMFR2wSvaymJTCUCRVyTg=; b=i4ANxg8Q3GY1CKfPo+klvkSjAhcsfVbNRqK+K/aQ/iToZldEMxU8NHBcNKw6UiXjq0 JOaf8WHB+ZRym59WBEzqIO8fSNdU5TfCYCLb7V+NuC833UbYh+Qe4jnSCo5qbzILKgOe ZCtM7mU+AKviHFbajnRGNd9uuqwb5C2h5qCDtW8MiFGKZclK1cVhdY18laToooYZVFNe 5gTSksJXBxPeXBQHIrvw8OvxYowfx5fNvMqwFL/B+6Xli9GAXFZNvxWFEVbJfqXw3Id+ 5rKeRDeu0YnRxzQ0ei0wp8zeAofbx/+H5ZTcajDcb6MvU6sbkRDUBWcGV2yCe5kwnyx4 ShVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jD7vbDbD0h84CsDujjRSLvXMFR2wSvaymJTCUCRVyTg=; b=hdkpEHp/KdEaDmDOZAl++2+j5gduNF7DR+ZlyJ3OPRQhhquYPuTXyQmvQyGk9xfOeW Qaybh4+BL3VeLRTraRrZCbxayy2hEZyYocZxZGA3zBfg5Ckz4RJsMnUgolujjye8ugnP OS180cD6qLVmAB0ZZyOiP79KJg8gfVnUEAKFYxMfUTSN+wjl4FZ5Bt9cRC1PII7MTb4K JdBvoF8RgCztXmqomdcZeuOAmgaRH7Q/hfvEMXPXBY2LHAUR8HF+XS4mJGhaFfR79yKZ cbnLquztQb8KoZcupGFlVjzRcTdKjlVy4bEy9otqGY++oVPUhR/xgQC1timMq50TFQUe THiA== X-Gm-Message-State: AOAM533fklYVUoseZfgrpsggAc+0D61fowQTk8GpB1j4rBhGHOudp0D7 3SsB3rsbh/mHNR4SpILY8F1tsA== X-Google-Smtp-Source: ABdhPJwHSp4h2t6bqX0badjP/w9fNcURWQGRTeksXWdcWRqrH8U8NT/f7kVg2Tt51R5DDZxijhwg+Q== X-Received: by 2002:a17:90a:bf05:: with SMTP id c5mr6907923pjs.90.1610657677823; Thu, 14 Jan 2021 12:54:37 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id fv22sm6486172pjb.14.2021.01.14.12.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 12:54:37 -0800 (PST) Date: Thu, 14 Jan 2021 13:54:35 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, paul@crapouillou.net, matthias.bgg@gmail.com, agross@kernel.org, patrice.chotard@st.com Subject: Re: [PATCH V6 09/10] remoteproc: imx_rproc: ignore mapping vdev regions Message-ID: <20210114205435.GC255481@xps15> References: <1610444359-1857-1-git-send-email-peng.fan@nxp.com> <1610444359-1857-10-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610444359-1857-10-git-send-email-peng.fan@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jan 12, 2021 at 05:39:18PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > vdev regions are vdev0vring0, vdev0vring1, vdevbuffer and similar. > They are handled by remoteproc common code, no need to map in imx > rproc driver. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index f80428afb8a7..e62a53ee128e 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -417,6 +417,9 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > struct resource res; > > node = of_parse_phandle(np, "memory-region", a); > + /* Not map vdev region */ > + if (!strcmp(node->name, "vdev")) > + continue; Reviewed-by: Mathieu Poirier > err = of_address_to_resource(node, 0, &res); > if (err) { > dev_err(dev, "unable to resolve memory region\n"); > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89558C433DB for ; Thu, 14 Jan 2021 20:56:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 480DD23A79 for ; Thu, 14 Jan 2021 20:56:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 480DD23A79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xAg+TTku709GDnjPR7/QPyrgdQe8R78UBrQohiwtN7o=; b=AUcDEItAqnlmvfLCdMrVsGZ4z u4ssF/A6inPCmnPR9J1qStq6qpxwtC4UslikerGVg5oZXLvCWfCHnclUZick2RelvVIchwQPAAypD /bceJEC3yL4PWuZ5Y0yy9QnaFu/hF0VqyHq7FJBwXmDSsLMkvD8f5wPWMhwt6y37JrOf+z+RONf79 GGId7Nt9jZXXXYO8ymQbuHG7v3veUcVA06Tg1OP7b0iwZiB+zvEl2yaI7tM0tBWFEiWr7G7ztVcC8 0dxFW/096O2CFMxfPB8RZJHO5qWgUMGiUVZclfAVKewCBksnmq/DcLmSj0ERZgtCtb16LEf8tfuef /vANYQG8Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l09dn-00023l-3u; Thu, 14 Jan 2021 20:54:47 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l09dh-00022w-Hi for linux-arm-kernel@lists.infradead.org; Thu, 14 Jan 2021 20:54:45 +0000 Received: by mail-pl1-x62f.google.com with SMTP id r4so3527166pls.11 for ; Thu, 14 Jan 2021 12:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jD7vbDbD0h84CsDujjRSLvXMFR2wSvaymJTCUCRVyTg=; b=i4ANxg8Q3GY1CKfPo+klvkSjAhcsfVbNRqK+K/aQ/iToZldEMxU8NHBcNKw6UiXjq0 JOaf8WHB+ZRym59WBEzqIO8fSNdU5TfCYCLb7V+NuC833UbYh+Qe4jnSCo5qbzILKgOe ZCtM7mU+AKviHFbajnRGNd9uuqwb5C2h5qCDtW8MiFGKZclK1cVhdY18laToooYZVFNe 5gTSksJXBxPeXBQHIrvw8OvxYowfx5fNvMqwFL/B+6Xli9GAXFZNvxWFEVbJfqXw3Id+ 5rKeRDeu0YnRxzQ0ei0wp8zeAofbx/+H5ZTcajDcb6MvU6sbkRDUBWcGV2yCe5kwnyx4 ShVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jD7vbDbD0h84CsDujjRSLvXMFR2wSvaymJTCUCRVyTg=; b=O4Dy1zoL9uWkHqo7OaF34sI1Ka8vl+02Cwn0oYoj2hds0VCY/gOyWLyip7SwUNziKq BaM83oorBTjQSFyTFfzflF7Rw+/5nJvAfaEke6qKZnqai0HJLNa6Vqteq6zilwY27Z7Z /2eH0+cfvI6zXGVDXyK+YlWeZVdHMPtmyVfawXdWiOrfBS4mRSdY8BwQJ5wtHkIv0Q5x 3vw1dOdWUBQ25asaj+cARVOvyXvpFZeYeafwzQlA3Vl9I03sZ5hFqyfRo8oPjszDZdwA XqsGE9h+d//TBGQACi9Az4nFNlg169Ca2XIQTFE3puq7i+8wor2BAtJJKQpzc50DqDO+ IUug== X-Gm-Message-State: AOAM530KQbI02QbmJgbBt1kqIic5Xty/CBUWIwKN5CyIUgpQBnat5yAY w9EMvsnW4bOZPXSfV8HRTbCYVg== X-Google-Smtp-Source: ABdhPJwHSp4h2t6bqX0badjP/w9fNcURWQGRTeksXWdcWRqrH8U8NT/f7kVg2Tt51R5DDZxijhwg+Q== X-Received: by 2002:a17:90a:bf05:: with SMTP id c5mr6907923pjs.90.1610657677823; Thu, 14 Jan 2021 12:54:37 -0800 (PST) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id fv22sm6486172pjb.14.2021.01.14.12.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 12:54:37 -0800 (PST) Date: Thu, 14 Jan 2021 13:54:35 -0700 From: Mathieu Poirier To: peng.fan@nxp.com Subject: Re: [PATCH V6 09/10] remoteproc: imx_rproc: ignore mapping vdev regions Message-ID: <20210114205435.GC255481@xps15> References: <1610444359-1857-1-git-send-email-peng.fan@nxp.com> <1610444359-1857-10-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1610444359-1857-10-git-send-email-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_155441_879482_868BC818 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ohad@wizery.com, patrice.chotard@st.com, festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, paul@crapouillou.net, o.rempel@pengutronix.de, robh+dt@kernel.org, agross@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, matthias.bgg@gmail.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 12, 2021 at 05:39:18PM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > vdev regions are vdev0vring0, vdev0vring1, vdevbuffer and similar. > They are handled by remoteproc common code, no need to map in imx > rproc driver. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index f80428afb8a7..e62a53ee128e 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -417,6 +417,9 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > struct resource res; > > node = of_parse_phandle(np, "memory-region", a); > + /* Not map vdev region */ > + if (!strcmp(node->name, "vdev")) > + continue; Reviewed-by: Mathieu Poirier > err = of_address_to_resource(node, 0, &res); > if (err) { > dev_err(dev, "unable to resolve memory region\n"); > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel