Re: [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support static

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

On Thu, Jan 14, 2021 at 03:06:23PM -0300, Daniel Henrique Barboza wrote:
> The function is called only inside spapr_hcall.c.
> 
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Nice catch - that's a hangover from an earlier version where it was
called elswhere.  Applied to ppc-for-6.0.

> ---
>  hw/ppc/spapr_hcall.c   | 1 +
>  include/hw/ppc/spapr.h | 5 -----
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index e5dfc1ba7a..7b5cd3553c 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1632,6 +1632,7 @@ static uint32_t cas_check_pvr(PowerPCCPU *cpu, uint32_t max_compat,
>      return best_compat;
>  }
>  
> +static
>  target_ulong do_client_architecture_support(PowerPCCPU *cpu,
>                                              SpaprMachineState *spapr,
>                                              target_ulong vec,
> diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> index 4d37c2a93b..a2d1fb21c6 100644
> --- a/include/hw/ppc/spapr.h
> +++ b/include/hw/ppc/spapr.h
> @@ -583,11 +583,6 @@ void spapr_register_hypercall(target_ulong opcode, spapr_hcall_fn fn);
>  target_ulong spapr_hypercall(PowerPCCPU *cpu, target_ulong opcode,
>                               target_ulong *args);
>  
> -target_ulong do_client_architecture_support(PowerPCCPU *cpu,
> -                                            SpaprMachineState *spapr,
> -                                            target_ulong addr,
> -                                            target_ulong fdt_bufsize);
> -
>  /* Virtual Processor Area structure constants */
>  #define VPA_MIN_SIZE           640
>  #define VPA_SIZE_OFFSET        0x4

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]