From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C474C433DB for ; Fri, 15 Jan 2021 13:13:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5AFA2256F for ; Fri, 15 Jan 2021 13:13:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5AFA2256F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xZiiucnS2sJPWMP/3QEMAr2iyhx5PJoeKjP1cj6CS/w=; b=w+w6lI3R1at1HUh9Aqxpf1+TN tldtBWy50FRagzl9YSKEVvm9Y6LO3nnWW/Mo4DuI/1EtI29qT3GCtmTEmnf5qN+3zK68CpP55qLC/ aVo0dL/Z7UEQc1yDWBFaaGoAG1MLrKmSjdMFLciDTBx+nNMJtPkBCrgJA/tmI3GaOMuBO+NdaNfpA so4TXka9j6UnpkiO8A+42e1kbvRMQKqDSwgqrY5t3IgeOWqX1/g3P6evQdzLag9r9X9zbaBRjk43h xtc4LWTKsCNQIzbcloqYOOANI17uFHjSIHay58ie02js3+nSa3/hnjEWnANkEvvgWX33QlXTNqjtN q0OgwK9eQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0OtZ-00028p-2R; Fri, 15 Jan 2021 13:12:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0OtW-00028P-DQ for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 13:12:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 242FCED1; Fri, 15 Jan 2021 05:11:56 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.41.13]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63FA33F70D; Fri, 15 Jan 2021 05:11:55 -0800 (PST) Date: Fri, 15 Jan 2021 13:11:53 +0000 From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: syscall: include prototype for EL0 SVC functions Message-ID: <20210115131153.GD39776@C02TD0UTHF1T.local> References: <20210114124812.17754-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210114124812.17754-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210115_081202_514248_EA192EB5 X-CRM114-Status: GOOD ( 22.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 14, 2021 at 12:48:12PM +0000, Mark Rutland wrote: > The kbuild test robot reports that when building with W=1, GCC will warn > for a couple of missing prototypes in syscall.c: > > | arch/arm64/kernel/syscall.c:157:6: warning: no previous prototype for 'do_el0_svc' [-Wmissing-prototypes] > | 157 | void do_el0_svc(struct pt_regs *regs) > | | ^~~~~~~~~~ > | arch/arm64/kernel/syscall.c:164:6: warning: no previous prototype for 'do_el0_svc_compat' [-Wmissing-prototypes] > | 164 | void do_el0_svc_compat(struct pt_regs *regs) > | | ^~~~~~~~~~~~~~~~~ > > While this isn't a functional problem, as a general policy we should > include the prototype for functions wherever possible to catch any > accidental divergence between the prototype and implementation. Here we > can easily include , so let's do so. > > While there are a number of warnings elsewhere and some warnings enabled > under W=1 are of questionable benefit, this change helps to make the > code more robust as it evolved and reduces the noise somewhat, so it > seems worthwhile. > > Reported-by: kernel test robot > Cc: Catalin Marinas > Cc: Will Deacon > Link: https://lore.kernel.org/r/202101141046.n8iPO3mw-lkp@intel.com Whoops; I messed up the tags here. For the record, the tags should have started with: Signed-off-by: Mark Rutland ... and please feel free to fold that in! Mark. > --- > arch/arm64/kernel/syscall.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/syscall.c b/arch/arm64/kernel/syscall.c > index f61e9d8cc55a..5991e72d4b8f 100644 > --- a/arch/arm64/kernel/syscall.c > +++ b/arch/arm64/kernel/syscall.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > #include > -- > 2.11.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel