From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1964FC433DB for ; Fri, 15 Jan 2021 13:57:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E09032336F for ; Fri, 15 Jan 2021 13:57:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731286AbhAON56 (ORCPT ); Fri, 15 Jan 2021 08:57:58 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2358 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728330AbhAON55 (ORCPT ); Fri, 15 Jan 2021 08:57:57 -0500 Received: from fraeml711-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DHN1V0qjwz67WPc; Fri, 15 Jan 2021 21:53:18 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml711-chm.china.huawei.com (10.206.15.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 15 Jan 2021 14:57:16 +0100 Received: from localhost (10.47.77.110) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 15 Jan 2021 13:57:15 +0000 Date: Fri, 15 Jan 2021 13:56:35 +0000 From: Jonathan Cameron To: Stephan Gerhold CC: Jonathan Cameron , Rob Herring , , Peter Meerwald-Stadler , Lars-Peter Clausen , Linus Walleij , , Rob Herring Subject: Re: [PATCH] dt-bindings: iio: accel: bma255: Fix bmc150/bmi055 compatible Message-ID: <20210115135635.0000034b@Huawei.com> In-Reply-To: References: <20201202083551.7753-1-stephan@gerhold.net> <20201209181739.GA708144@robh.at.kernel.org> <20201213132514.00d7ffff@archlinux> <20210114205937.11e650d0@archlinux> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.77.110] X-ClientProxiedBy: lhreml735-chm.china.huawei.com (10.201.108.86) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 15 Jan 2021 09:37:42 +0100 Stephan Gerhold wrote: > On Thu, Jan 14, 2021 at 08:59:37PM +0000, Jonathan Cameron wrote: > > On Sun, 13 Dec 2020 13:25:14 +0000 > > Jonathan Cameron wrote: > > > > > On Wed, 9 Dec 2020 12:17:39 -0600 > > > Rob Herring wrote: > > > > > > > On Wed, 02 Dec 2020 09:35:51 +0100, Stephan Gerhold wrote: > > > > > The bmc150-accel-i2c.c driver has an "_accel" suffix for the > > > > > compatibles of BMC150 and BMI055. This is necessary because BMC150 > > > > > contains both accelerometer (bosch,bmc150_accel) and magnetometer > > > > > (bosch,bmc150_magn) and therefore "bosch,bmc150" would be ambiguous. > > > > > > > > > > However, the binding documentation suggests using "bosch,bmc150". > > > > > Add the "_accel" suffix for BMC150 and BMI055 so the binding docs > > > > > match what is expected by the driver. > > > > > > > > > > Cc: Linus Walleij > > > > > Fixes: 496a39526fce8 ("iio: accel: bmc150-accel: Add DT bindings") > > > > > Signed-off-by: Stephan Gerhold > > > > > --- > > > > > Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > Reviewed-by: Rob Herring > > > Applied to the fixes-togreg branch of iio.git which is now based on stuff > > > queued up for the merge window. I'll send a pull not long after rc1. > > > > > > > Not sure why, but the Fixes tag above is invalid. > > > > I think we can call this a "race condition" :) > > I sent the patch on Dec 02 and you rebased the patch on Dec 03 for > "iio-for-5.11b-take2" (because some sign offs were missing there). > My patch simply refers to the old commit hash. > > Stephan That would do it! :) I suspected as much but was being lazy so didn't bother looking :) Jonathan