From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B38DC433E0 for ; Sat, 16 Jan 2021 23:24:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF3372251E for ; Sat, 16 Jan 2021 23:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727842AbhAPXY3 (ORCPT ); Sat, 16 Jan 2021 18:24:29 -0500 Received: from retiisi.eu ([95.216.213.190]:51250 "EHLO hillosipuli.retiisi.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbhAPXYY (ORCPT ); Sat, 16 Jan 2021 18:24:24 -0500 Received: from valkosipuli.localdomain (valkosipuli.localdomain [IPv6:fd35:1bc8:1a6:d3d5::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.eu (Postfix) with ESMTPS id E053D634C89; Sun, 17 Jan 2021 01:22:40 +0200 (EET) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1l0uu0-0002pH-Qk; Sun, 17 Jan 2021 01:22:40 +0200 Date: Sun, 17 Jan 2021 01:22:40 +0200 From: Sakari Ailus To: Helen Koike Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, mchehab@kernel.org, hans.verkuil@cisco.com, kernel@collabora.com, linux-kernel@vger.kernel.org, tfiga@chromium.org Subject: Re: [PATCH 3/3] media: videobuf2-v4l2: remove redundant error test Message-ID: <20210116232240.GV850@valkosipuli.retiisi.org.uk> References: <20210114180149.1755892-1-helen.koike@collabora.com> <20210114180149.1755892-4-helen.koike@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210114180149.1755892-4-helen.koike@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 14, 2021 at 03:01:49PM -0300, Helen Koike wrote: > request_fd is validated under media_request_get_by_fd() just below this > check. Thus remove it. > > Suggested-by: Tomasz Figa > Signed-off-by: Helen Koike Reviewed-by: Sakari Ailus -- Sakari Ailus