From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C4AC433E6 for ; Mon, 18 Jan 2021 06:34:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4ED6A22BF3 for ; Mon, 18 Jan 2021 06:34:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732528AbhARGdt (ORCPT ); Mon, 18 Jan 2021 01:33:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:36482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732470AbhARGdj (ORCPT ); Mon, 18 Jan 2021 01:33:39 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CEFBF227C3; Mon, 18 Jan 2021 06:32:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610951578; bh=6N01wzOWjD4rcN3F+PsOZ2+FEiqBi+1ijLv2TWHWy1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DZhxDTkH4wOiwmQkjydK2eMj9TNaaYJmpx+GAz3q49VqQbiljqZ7R4DIpakgbcF6Y T8r5mtoerAun0V4Aq06ChEmL0Tdci7RmiFkFIci1mKJDy9jimnRqEEeuC654YQAEUM AUwdIzGyafW7ZD+C1NWNwdf8GMR7hAhQuBl9hx2xKwx7QmZwX22H+5MKS8w8iDzgAh oyms8zIjaL3/SB9RP5D917Y/ru5sdAMdAcU6mgMvoZt/Lyl7ABJXAr1ejU0YiFq43O jKWj754opqG8+X2S4t5jjzYjj1+kDO4H1HBcDgrMIq0GfUugUja7Sv2L++2iL8hmVn dS/mKQujjh3MA== Date: Mon, 18 Jan 2021 14:32:53 +0800 From: Shawn Guo To: Bruno Thomsen Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Bruno Thomsen , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rasmus Villemoes , Alexandre Belloni Subject: Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset Message-ID: <20210118063252.GJ28365@dragon> References: <20210111151537.12530-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210111151537.12530-1-bruno.thomsen@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote: > RTC pcf2127 device driver has changed default behaviour of the watchdog > feature in v5.11-rc1. Now you need to explicitly enable it with a > device tree property, "reset-source", when used in the board design. It sound that the existing DTBs are broken by this default behaviour change? > > Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available") > > Signed-off-by: Bruno Thomsen > Cc: Bruno Thomsen > Cc: Uwe Kleine-König > Cc: Rasmus Villemoes > Cc: Alexandre Belloni Applied, thanks. Shawn > --- > arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts > index 84b095279e65..bd6b5285aa8d 100644 > --- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts > +++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts > @@ -115,6 +115,7 @@ pcf2127: rtc@0 { > compatible = "nxp,pcf2127"; > reg = <0>; > spi-max-frequency = <2000000>; > + reset-source; > }; > }; > > > base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837 > -- > 2.29.2 >