From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D1DC433DB for ; Mon, 18 Jan 2021 06:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EF7C229C4 for ; Mon, 18 Jan 2021 06:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732062AbhARGqG (ORCPT ); Mon, 18 Jan 2021 01:46:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:38648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbhARGqA (ORCPT ); Mon, 18 Jan 2021 01:46:00 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7EF21229C4; Mon, 18 Jan 2021 06:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610952320; bh=e2CwknkP5NekTSXTF/l/DZ4TRNU3wjDFJ3Y0S399E/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qc0rbu5xpn0EJ6RO51eVoTq+WbllSP+2LtQE2RIYxGKhj5b/MbSejWjOhrw0dXctQ 7gwgV7Cccqv6uT4chqmcNXokjJRuJBq5G5pwqJbhwolYMJoyOj6UXOX2nxwAX9i7RA viZQzv2za7nW9ckLdzszW136/CAzNC6DZ+4nWHFJenBZwf5Dz7QKgnrEa9M79e8Lzb O+iHIPC550pu0BRRzR5lQe0r6punn+RNFA8Lk0JOKxD7c4hwqWYSMsLMNFZseXbNpq o/GQmXYJajmQpceaiqwEnf2Zw7/SEQzE2X3J1B1DQNY67syP6WHt7H9XU3mWBwqEX2 sNHqQkEum/0OQ== Date: Mon, 18 Jan 2021 14:45:13 +0800 From: Shawn Guo To: Max Krummenacher Cc: Max Krummenacher , Lucas Stach , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Rouven Czerwinski , linux-kernel@vger.kernel.org, Ahmad Fatoum , Pengutronix Kernel Team , Sascha Hauer , Russell King , NXP Linux Team Subject: Re: [PATCH 1/1] ARM: imx: build suspend-imx6.S with arm instruction set Message-ID: <20210118064512.GK28365@dragon> References: <20210111151704.26296-1-max.krummenacher@toradex.com> <20210111151704.26296-2-max.krummenacher@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111151704.26296-2-max.krummenacher@toradex.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 04:17:04PM +0100, Max Krummenacher wrote: > When the kernel is configured to use the Thumb-2 instruction set > "suspend-to-memory" fails to resume. Observed on a Colibri iMX6ULL > (i.MX 6ULL) and Apalis iMX6 (i.MX 6Q). > > It looks like the CPU resumes unconditionally in ARM instruction mode > and then chokes on the presented Thumb-2 code it should execute. > > Fix this by using the arm instruction set for all code in > suspend-imx6.S. > > Signed-off-by: Max Krummenacher Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7280AC433DB for ; Mon, 18 Jan 2021 06:47:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37D83229C4 for ; Mon, 18 Jan 2021 06:47:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37D83229C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=45vAhUShUNYgdZuv2mGq05L00Bzkq+LyEOouQZb3Roc=; b=B9BNGHdKiysNvEvBfSk/Gz7p7 s2yCYt+0g8X4iacYSSMKmeaG2fM3oAFbbzNJNInYv2NxutdrbKOLETZ6zm/Ysss73ak2BDF49lzwd ky1GfVIGh+tW21zUDA2lw52isAat0kX8GybaNdtikE6J/zUQR/kS38WCc8dT0Bhn9XfyML4URmWBg LH63nqtH3bimGl2FtVUo1wiffbnmEcU0Qp8NjhkZ1tX7P58+Auw61sF15BOF4NjSmABam26NAo8n6 Xr7lGxtFj9bxm7DsDmSqYqHIEiXTlBrc3xsyMIUYPzyq0y2akve5jNKqTfG4yYx/QVjBQ9pxoHltP liC10S6HQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1OI1-0008Oa-43; Mon, 18 Jan 2021 06:45:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1OHx-0008O1-4d for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 06:45:22 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7EF21229C4; Mon, 18 Jan 2021 06:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610952320; bh=e2CwknkP5NekTSXTF/l/DZ4TRNU3wjDFJ3Y0S399E/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qc0rbu5xpn0EJ6RO51eVoTq+WbllSP+2LtQE2RIYxGKhj5b/MbSejWjOhrw0dXctQ 7gwgV7Cccqv6uT4chqmcNXokjJRuJBq5G5pwqJbhwolYMJoyOj6UXOX2nxwAX9i7RA viZQzv2za7nW9ckLdzszW136/CAzNC6DZ+4nWHFJenBZwf5Dz7QKgnrEa9M79e8Lzb O+iHIPC550pu0BRRzR5lQe0r6punn+RNFA8Lk0JOKxD7c4hwqWYSMsLMNFZseXbNpq o/GQmXYJajmQpceaiqwEnf2Zw7/SEQzE2X3J1B1DQNY67syP6WHt7H9XU3mWBwqEX2 sNHqQkEum/0OQ== Date: Mon, 18 Jan 2021 14:45:13 +0800 From: Shawn Guo To: Max Krummenacher Subject: Re: [PATCH 1/1] ARM: imx: build suspend-imx6.S with arm instruction set Message-ID: <20210118064512.GK28365@dragon> References: <20210111151704.26296-1-max.krummenacher@toradex.com> <20210111151704.26296-2-max.krummenacher@toradex.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210111151704.26296-2-max.krummenacher@toradex.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_014521_284677_62C1442B X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rouven Czerwinski , Pengutronix Kernel Team , Sascha Hauer , linux-kernel@vger.kernel.org, Russell King , NXP Linux Team , Max Krummenacher , Ahmad Fatoum , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 11, 2021 at 04:17:04PM +0100, Max Krummenacher wrote: > When the kernel is configured to use the Thumb-2 instruction set > "suspend-to-memory" fails to resume. Observed on a Colibri iMX6ULL > (i.MX 6ULL) and Apalis iMX6 (i.MX 6Q). > > It looks like the CPU resumes unconditionally in ARM instruction mode > and then chokes on the presented Thumb-2 code it should execute. > > Fix this by using the arm instruction set for all code in > suspend-imx6.S. > > Signed-off-by: Max Krummenacher Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel