From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F41C433E6 for ; Mon, 18 Jan 2021 10:38:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E81B02225C for ; Mon, 18 Jan 2021 10:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388440AbhARKhq (ORCPT ); Mon, 18 Jan 2021 05:37:46 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:44887 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389814AbhARKPy (ORCPT ); Mon, 18 Jan 2021 05:15:54 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E2C411585; Mon, 18 Jan 2021 05:15:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 18 Jan 2021 05:15:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=fM/OR5bMbjK642/ahP0Ny1LYwDT vhOHowWFE8Xc2wHc=; b=oIxcG/sDku+VH+uxW1TgEHQH4O29S3on/QZ3dHO2p10 EJq+iuFUycsRAFWEzjAbUyVy7WtjzaBny/jq+CP4t1fkYn2z9kNsNkTWR/8Fw8rk AJHnO4l3Mw2650u5eV0/TvPsxws+cppMz+FVoRO9ReERKZEpZLfhUK39Tu2UDEfa gX1c0r2Sq00E/tuQPEkZUfI60YP+erD/yF20k0VslQPqig555LWF0kr/1IYihzCT UCsllEKTyqOCEuDQ5BLrFyOmab3U2HZqYflRNjm5UO3+c/FKt3X/1oif7XzT1sCs fvMpCUXUcPkiT6EfErRAySuQRqQI33sjz6hOEWcbTtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fM/OR5 bMbjK642/ahP0Ny1LYwDTvhOHowWFE8Xc2wHc=; b=Q6qOy9T+nFLV/dkh1GS7rq oAHU5JALy2VsmuHtVnA/BeqsCbXeURqLb4pH/kj32UM1J8rglk2CfBeAKo+4q0JC P0ZWBK73KS68fS0kXAVjTwGe/L/mNC85blYbY/ujPpW4awa7GqcOn2NG0SfsV2eN L5raV6Ne4MPKtnnr3DClIgFg4jAzxMUjSy79CxGWnoPuLxrXjt5tDdIDkmSecELh /Zhggli7mVHb5BaqtzrtOhx5obBF2edOGhxbtuzmxYbAUEYZDlv2he+ENLWRq0CF f/IvbKQotP4Lexen/itrocTcaB30ccnW1t74esmWpH/cLjGXcit7THnSCUMFfHsg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EB3324005B; Mon, 18 Jan 2021 05:15:05 -0500 (EST) Date: Mon, 18 Jan 2021 11:15:01 +0100 From: Maxime Ripard To: Rob Herring Cc: Frank Rowand , devicetree@vger.kernel.org, Chen-Yu Tsai , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, Alistair Francis , Vasily Khoruzhick Subject: Re: [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties Message-ID: <20210118101501.mmlgsiyj5rulrpgk@gilmour> References: <20210114113538.1233933-1-maxime@cerno.tech> <20210114113538.1233933-5-maxime@cerno.tech> <20210115013714.GA3798333@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p2akrc3zycmkmy4i" Content-Disposition: inline In-Reply-To: <20210115013714.GA3798333@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --p2akrc3zycmkmy4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rob, On Thu, Jan 14, 2021 at 07:37:14PM -0600, Rob Herring wrote: > On Thu, Jan 14, 2021 at 12:35:24PM +0100, Maxime Ripard wrote: > > additionalProperties prevent any property not explicitly defined in the > > binding to be used. Yet, some serial properties like max-speed are valid > > and validated through the serial/serial.yaml binding. > >=20 > > Let's change additionalProperties to unevaluatedProperties to avoid > > spurious warnings. > >=20 > > Cc: Alistair Francis > > Cc: Vasily Khoruzhick > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.ya= ml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > > index 4f485df69ac3..f4d4969d87f4 100644 > > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > > @@ -37,7 +37,7 @@ properties: > > required: > > - compatible > > =20 > > -additionalProperties: false > > +unevaluatedProperties: false >=20 > This would still fail because the serial schema is applied to the parent= =20 > and this schema is applied to the child node. It's a common problem for= =20 > how we've done bus schemas. We'd need to split them into 2 schemas and=20 > reference the child schema here. I'd rather not do that here because=20 > then we'd apply the schema twice assuming we keep bus schemas also=20 > applying the child schemas (which is good at least until we have schemas= =20 > for *all* possible child devices). I couldn't find what requires additionalProperties in the meta-schemas, could you point me to what enforces it? > We've handled this in other cases by just doing 'max-speed: true' here. I will do that then, thanks! Maxime --p2akrc3zycmkmy4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYAVfpQAKCRDj7w1vZxhR xaXOAP95Lk20T0ZHJyV7JdNnmfNh+KASNQVqIC5Ph3fpwUf9GQEAxkR2/nf9RCFx 1GWW2OowBxLpk5SVJlRMuF0u6h/YtAQ= =FLIt -----END PGP SIGNATURE----- --p2akrc3zycmkmy4i-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3E5C433E0 for ; Mon, 18 Jan 2021 10:17:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C1F32253A for ; Mon, 18 Jan 2021 10:17:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C1F32253A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mPyie1d2wyr9rLYblEy+dF9Pe6wP/zpo8AhMdSDnsYQ=; b=U6DDyhTb35thnbF8mcI6zL5jn RtGkfewqZc2vMiwzH7hnrTiUk/uCLVf4xbpT7kXjy3lUpCimq2wygy8ePdeWVjJKPqGDJXt8+wtqJ yIn3bkR8SEaAjiRiPLC2oP+q5w9xLXq53fhWPBfeaPMUBLkGFAvozTCy2F+uBf3sR+gvP1KFrwKdK aAr+BbMVb2XoMhtK4kB1lwlgt5/dKjldWUn+HloWJekoPBOfFZQ9W3q5Hl9V8y+c/SaueK/gHSBTW lVbGBoGRC3wuohan85di5rd+hGfrj1LxWNwN+QxV282bJVtXWSleAIYVzTgV5pzzt/f9yAhHYBI4f PstSl6Yaw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1RZD-0004wf-Ln; Mon, 18 Jan 2021 10:15:23 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1RZA-0004vr-6k for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 10:15:21 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id E2C411585; Mon, 18 Jan 2021 05:15:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 18 Jan 2021 05:15:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=fM/OR5bMbjK642/ahP0Ny1LYwDT vhOHowWFE8Xc2wHc=; b=oIxcG/sDku+VH+uxW1TgEHQH4O29S3on/QZ3dHO2p10 EJq+iuFUycsRAFWEzjAbUyVy7WtjzaBny/jq+CP4t1fkYn2z9kNsNkTWR/8Fw8rk AJHnO4l3Mw2650u5eV0/TvPsxws+cppMz+FVoRO9ReERKZEpZLfhUK39Tu2UDEfa gX1c0r2Sq00E/tuQPEkZUfI60YP+erD/yF20k0VslQPqig555LWF0kr/1IYihzCT UCsllEKTyqOCEuDQ5BLrFyOmab3U2HZqYflRNjm5UO3+c/FKt3X/1oif7XzT1sCs fvMpCUXUcPkiT6EfErRAySuQRqQI33sjz6hOEWcbTtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=fM/OR5 bMbjK642/ahP0Ny1LYwDTvhOHowWFE8Xc2wHc=; b=Q6qOy9T+nFLV/dkh1GS7rq oAHU5JALy2VsmuHtVnA/BeqsCbXeURqLb4pH/kj32UM1J8rglk2CfBeAKo+4q0JC P0ZWBK73KS68fS0kXAVjTwGe/L/mNC85blYbY/ujPpW4awa7GqcOn2NG0SfsV2eN L5raV6Ne4MPKtnnr3DClIgFg4jAzxMUjSy79CxGWnoPuLxrXjt5tDdIDkmSecELh /Zhggli7mVHb5BaqtzrtOhx5obBF2edOGhxbtuzmxYbAUEYZDlv2he+ENLWRq0CF f/IvbKQotP4Lexen/itrocTcaB30ccnW1t74esmWpH/cLjGXcit7THnSCUMFfHsg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdekgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 2EB3324005B; Mon, 18 Jan 2021 05:15:05 -0500 (EST) Date: Mon, 18 Jan 2021 11:15:01 +0100 From: Maxime Ripard To: Rob Herring Subject: Re: [PATCH 05/19] dt-bindings: bluetooth: realtek: Switch to unevaluatedProperties Message-ID: <20210118101501.mmlgsiyj5rulrpgk@gilmour> References: <20210114113538.1233933-1-maxime@cerno.tech> <20210114113538.1233933-5-maxime@cerno.tech> <20210115013714.GA3798333@robh.at.kernel.org> MIME-Version: 1.0 In-Reply-To: <20210115013714.GA3798333@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_051520_698131_18F3DDBC X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , Alistair Francis , Vasily Khoruzhick , Chen-Yu Tsai , Frank Rowand , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4078712148153769802==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4078712148153769802== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="p2akrc3zycmkmy4i" Content-Disposition: inline --p2akrc3zycmkmy4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Rob, On Thu, Jan 14, 2021 at 07:37:14PM -0600, Rob Herring wrote: > On Thu, Jan 14, 2021 at 12:35:24PM +0100, Maxime Ripard wrote: > > additionalProperties prevent any property not explicitly defined in the > > binding to be used. Yet, some serial properties like max-speed are valid > > and validated through the serial/serial.yaml binding. > >=20 > > Let's change additionalProperties to unevaluatedProperties to avoid > > spurious warnings. > >=20 > > Cc: Alistair Francis > > Cc: Vasily Khoruzhick > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.ya= ml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > > index 4f485df69ac3..f4d4969d87f4 100644 > > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > > @@ -37,7 +37,7 @@ properties: > > required: > > - compatible > > =20 > > -additionalProperties: false > > +unevaluatedProperties: false >=20 > This would still fail because the serial schema is applied to the parent= =20 > and this schema is applied to the child node. It's a common problem for= =20 > how we've done bus schemas. We'd need to split them into 2 schemas and=20 > reference the child schema here. I'd rather not do that here because=20 > then we'd apply the schema twice assuming we keep bus schemas also=20 > applying the child schemas (which is good at least until we have schemas= =20 > for *all* possible child devices). I couldn't find what requires additionalProperties in the meta-schemas, could you point me to what enforces it? > We've handled this in other cases by just doing 'max-speed: true' here. I will do that then, thanks! Maxime --p2akrc3zycmkmy4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYAVfpQAKCRDj7w1vZxhR xaXOAP95Lk20T0ZHJyV7JdNnmfNh+KASNQVqIC5Ph3fpwUf9GQEAxkR2/nf9RCFx 1GWW2OowBxLpk5SVJlRMuF0u6h/YtAQ= =FLIt -----END PGP SIGNATURE----- --p2akrc3zycmkmy4i-- --===============4078712148153769802== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4078712148153769802==--