From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78DEC433DB for ; Mon, 18 Jan 2021 11:25:17 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 474EE222B3 for ; Mon, 18 Jan 2021 11:25:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 474EE222B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id DC77C2034C; Mon, 18 Jan 2021 11:25:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4UykgB+W8EEh; Mon, 18 Jan 2021 11:25:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 276E82010E; Mon, 18 Jan 2021 11:25:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F4C0C08A1; Mon, 18 Jan 2021 11:25:16 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2BF08C013A for ; Mon, 18 Jan 2021 11:25:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 285A286668 for ; Mon, 18 Jan 2021 11:25:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9DiKvlxuVV2v for ; Mon, 18 Jan 2021 11:25:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 96223861D4 for ; Mon, 18 Jan 2021 11:25:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 26572222B3; Mon, 18 Jan 2021 11:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610969113; bh=60sJm+mImpf9L23Pcs9uk0teq7X8qJVeYIkzxo748s4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FLUNfs0/W9izTS6EAfZw+31Om3TaNq7HJm6Z4VCCQRLTVTbo3t5VJEoAtl+uasoOt Rn+Xw+PUrq1aG9+zMhSvTnOxFsiOQFIJAMav+/3wgX3/31sF8jA7q09aIyLNazJupM SPER02IgQ1mHJo0Hnm2pftkseErgeK7fGPDL9d+gWYa380ivgs0jmkHN4YtN08qzce BC0UCvP79gNEeO79ShOt5FmR9+VABwEMkTkO/PhqiHwulUt2A4lA54SHaiDFUL1OCi Vbt3xHuyNvXOGp0eQYVNvM1t0BBlI5QvtuRfluapYBaFKtXgJFocZTtaIG6weXQSUW h5HsDR5jn35jQ== Date: Mon, 18 Jan 2021 11:25:08 +0000 From: Will Deacon To: Adrian Huang Subject: Re: [RESEND PATCH 1/1] iommu/amd: Remove unnecessary assignment Message-ID: <20210118112508.GB16500@willie-the-truck> References: <20201210021330.2022-1-adrianhuang0701@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201210021330.2022-1-adrianhuang0701@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Adrian Huang , iommu@lists.linux-foundation.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Dec 10, 2020 at 10:13:30AM +0800, Adrian Huang wrote: > From: Adrian Huang > > From: Adrian Huang > > The values of local variables are assigned after local variables > are declared, so no need to assign the initial value during the > variable declaration. > > And, no need to assign NULL for the local variable 'ivrs_base' > after invoking acpi_put_table(). > > Signed-off-by: Adrian Huang > --- > drivers/iommu/amd/init.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Acked-by: Will Deacon Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu