From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17967C433E0 for ; Mon, 18 Jan 2021 13:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B73BB22B47 for ; Mon, 18 Jan 2021 13:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726463AbhARN4E (ORCPT ); Mon, 18 Jan 2021 08:56:04 -0500 Received: from mga05.intel.com ([192.55.52.43]:59073 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392453AbhARNwL (ORCPT ); Mon, 18 Jan 2021 08:52:11 -0500 IronPort-SDR: mo2AHIpup04DPB7PpJYgnSobKyRwYb7Cm0Q3oh6gm787AV+AF+RJbZ9TV5brNuZ6LwVzSAehFe Y9cudTga50aA== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="263610121" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="263610121" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 05:50:25 -0800 IronPort-SDR: MLmKRq3b4QoZpayrs4ITgd0IkDJ1ntZLWQYao3iSPt0or6j5wbSRJoI87d0U/VhaAOXE+V9RVD HNDuV8xa3WMw== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="402053339" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 05:50:20 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l1UwE-002CGB-0I; Mon, 18 Jan 2021 15:51:22 +0200 Date: Mon, 18 Jan 2021 15:51:21 +0200 From: "andriy.shevchenko@linux.intel.com" To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Daniel Scally , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "devel@acpica.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "andy@kernel.org" , "mika.westerberg@linux.intel.com" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "wsa@kernel.org" , "lee.jones@linaro.org" , "hdegoede@redhat.com" , "mgross@linux.intel.com" , "robert.moore@intel.com" , "erik.kaneda@intel.com" , "sakari.ailus@linux.intel.com" , "laurent.pinchart@ideasonboard.com" , "kieran.bingham@ideasonboard.com" Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver Message-ID: <20210118135121.GM4077@smile.fi.intel.com> References: <20210118003428.568892-1-djrscally@gmail.com> <20210118003428.568892-7-djrscally@gmail.com> <-GKrxu8GJvGe-PlKkLpblw9N-DtVtS7i87BOCLgJR72yf4hUFpUgiOlGcFero_gqgUxJrX2gxtLOnz_31hJugfam0SXXmXxIzGIhS162mhI=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <-GKrxu8GJvGe-PlKkLpblw9N-DtVtS7i87BOCLgJR72yf4hUFpUgiOlGcFero_gqgUxJrX2gxtLOnz_31hJugfam0SXXmXxIzGIhS162mhI=@protonmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jan 18, 2021 at 11:12:34AM +0000, Barnabás Pőcze wrote: > 2021. január 18., hétfő 1:34 keltezéssel, Daniel Scally írta: > Have you considered putting the source (and header) files into a dedicated > folder? I think it'd help manageability in the long run, and it'd be immediately > obvious that these source files form a single "unit". What would be the folder name? Because, for example, intel_cht_int33fe* have no folder (yet?) and here it's kinda similar case when HID describes something else than just one IP. -- With Best Regards, Andy Shevchenko