All of
 help / color / mirror / Atom feed
From: Arkadiusz Kubalewski <>
Subject: [Intel-wired-lan] [PATCH net v4 0/2] i40e: Fix for link-flapping
Date: Mon, 18 Jan 2021 19:34:52 +0000	[thread overview]
Message-ID: <> (raw)

VF queues were not brought up when PF was brought up after being downed
if the VF driver disabled VFs queues during PF down. This could happen
in some older or external VF driver implementations.
The problem was that PF driver used vf->queues_enabled as a condition
to decide what link-state it would send out which caused the issue.
Remove the check for vf->queues_enabled in the VF link notify. Now VF
will always be notified of the current link status. Also remove
the queues_enabled member from i40e_vf structure as it is not used
anymore. Also refactor repeated link state reporting code into a
separate helper function i40e_set_vf_link_state().
Otherwise VNF implementation was broken and caused a link flap.

Fixes: 2ad1274fa35a ("i40e: don't report link up for a VF who hasn't enabled")

v2: improve commit message
v3: net tree target
v4: split into 2 patches

Arkadiusz Kubalewski (2):
  i40e: Revert "i40e: don't report link up for a VF who hasn't enabled
  i40e: refactor repeated link state reporting code

 .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 115 ++++++++++--------
 .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |   1 -
 2 files changed, 67 insertions(+), 49 deletions(-)

base-commit: 82edab16ec1fc048ef6a9a96ec5a0d1374f5bf3b

Intel Technology Poland sp. z o.o.
ul. Sowackiego 173 | 80-298 Gdask | Sd Rejonowy Gdask Pnoc | VII Wydzia Gospodarczy Krajowego Rejestru Sdowego - KRS 101882 | NIP 957-07-52-316 | Kapita zakadowy 200.000 PLN.
Ta wiadomo wraz z zacznikami jest przeznaczona dla okrelonego adresata i moe zawiera informacje poufne. W razie przypadkowego otrzymania tej wiadomoci, prosimy o powiadomienie nadawcy oraz trwae jej usunicie; jakiekolwiek przegldanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.

             reply	other threads:[~2021-01-18 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 19:34 Arkadiusz Kubalewski [this message]
2021-01-18 19:34 ` [Intel-wired-lan] [PATCH net v4 1/2] i40e: Revert "i40e: don't report link up for a VF who hasn't enabled queues" Arkadiusz Kubalewski
2021-01-20  1:29   ` Nguyen, Anthony L
2021-01-20 10:17     ` Loktionov, Aleksandr
2021-01-20 22:17       ` Nguyen, Anthony L
2021-01-18 19:34 ` [Intel-wired-lan] [PATCH net v4 2/2] i40e: refactor repeated link state reporting code Arkadiusz Kubalewski
2021-01-20  1:28   ` Nguyen, Anthony L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.