From: Peter Xu <peterx@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [PATCH] pci: add romsize property
Date: Tue, 19 Jan 2021 11:31:23 -0500 [thread overview]
Message-ID: <20210119163123.GF76571@xz-x1> (raw)
In-Reply-To: <20201218185457.GH2956@work-vm>
On Fri, Dec 18, 2020 at 06:54:57PM +0000, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
> > This property can be useful for distros to set up known-good ROM sizes for
> > migration purposes. The VM will fail to start if the ROM is too large,
> > and migration compatibility will not be broken if the ROM is too small.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> I suspect something breaks horribly if you set this to the 4GB that the
> UINT32 would allow.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Indeed, but we do have lots of restrictions (IIUC) in qemu cmdline that it
won't really work if we don't specify things correctly, so I won't worry it too
much, since I assumed qemu cmdline users are advanced users, always. :)
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-01-19 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 18:27 [PATCH] pci: add romsize property Paolo Bonzini
2020-12-18 18:54 ` Dr. David Alan Gilbert
2021-01-19 16:31 ` Peter Xu [this message]
2021-01-19 16:51 ` Philippe Mathieu-Daudé
2021-01-19 17:10 ` Paolo Bonzini
2021-01-19 17:19 ` Philippe Mathieu-Daudé
2021-01-19 17:20 ` Laszlo Ersek
2021-01-22 14:54 ` Paolo Bonzini
2021-01-20 10:14 ` David Edmondson
2021-01-22 14:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119163123.GF76571@xz-x1 \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.