From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1l1wig-0005V2-9g for mharc-grub-devel@gnu.org; Tue, 19 Jan 2021 14:31:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1wic-0005TS-Cl for grub-devel@gnu.org; Tue, 19 Jan 2021 14:31:11 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:39666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1wia-0000dn-9X for grub-devel@gnu.org; Tue, 19 Jan 2021 14:31:10 -0500 Received: by mail-ed1-x535.google.com with SMTP id b21so14110066edy.6 for ; Tue, 19 Jan 2021 11:31:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to; bh=MJL94cOxSPPJn/F62F0hiHAV3+OX/kAI4CusNd+g9L0=; b=RyFjob9RMlt3Vf914Sxv5bUfxaFXNgkz7mAkVwSHLT77O26+ZH0iSeJNUc4bE307W8 SxV1EQtAHJpFWniERhJACFyg2EZaaYAW4aNGPFNps+rFQ4v71G8kR9wnmO5CFu8zb/7S pEMI40S5cr4xQsfkXkB74yAOi3zae2Gg4SoipFBi2NgsBJ3r8qxYDlI3VGAsbl4Jv5GP u4u9XG8lCFv3BYLoK+t0Ssc38oNN3Jzwe57ZXmeXBlFjs0pZLGekIjCLV7vbQvIvrSPY qEAGb2HJuXYW37+ldMfazWwdm70qrpjBKi6EZpyFWyq0wGFQ/khgNFqCEg5Z1oC70N6e HkAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to; bh=MJL94cOxSPPJn/F62F0hiHAV3+OX/kAI4CusNd+g9L0=; b=p4KujUUJoZl9wHjJovwEoMzcuy3R7+SspnSsBw6fu/xIXlMtcyvanoi6QDHFwLfOD0 lf+d8WZl/cDohlllYytDNvajCuIlrqZuUAa73rfhKHCggp6k0wDf47YSDIk1OJZMGry0 barVaWsCzJllat3GVc1NUwWqb3ktM1XihEf8YR5vIO9Ne4Q7lBnLtlOkPQUlk8XwsK4V rp4jjyLKXnliupnDBeKTOtnGSGJXQM6P9zGvJ6cWwOcgitfAdlf+kYL1p7cbayuiiHbd if9oK6mZmWWoyQTbB6HdsHlaOp7XE7Gq1iPdJufozS2qdUU+C5aOmVDLN48tssU1zNx5 Am1Q== X-Gm-Message-State: AOAM531ipK1JZZz3Vfji1f3rhy+K17NS2sBj4XFgdGPK0ZiRqCVUrk4w kRT7fmv3QhRHXmGenE0c4ss= X-Google-Smtp-Source: ABdhPJyhV/8w/aBEPZZtj7uaGpqi40zJ2qzKzyakMHjoe+VSk8Yl3e33ERqpKq7NDtSOy77zxQ93Dw== X-Received: by 2002:aa7:d2d4:: with SMTP id k20mr4535293edr.361.1611084666533; Tue, 19 Jan 2021 11:31:06 -0800 (PST) Received: from pevik ([62.201.25.198]) by smtp.gmail.com with ESMTPSA id y20sm5431127edc.84.2021.01.19.11.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jan 2021 11:31:05 -0800 (PST) Date: Tue, 19 Jan 2021 20:31:03 +0100 From: Petr Vorel To: Patrick Steinhardt Cc: Dmitry , The development of GNU GRUB , Daniel Kiper Subject: Re: [PATCH v3 3/5] argon2: Import Argon2 from cryptsetup Message-ID: <20210119193103.GA44793@pevik> Reply-To: Petr Vorel References: <20210119000758.GA178434@pevik> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=petr.vorel@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2021 19:31:11 -0000 Hi Patrick, > On Tue, Jan 19, 2021 at 02:06:15PM +0100, Petr Vorel wrote: > > Hi, > > > Please try to build only for the "efi-64" platform. (not "pc") > > right, I'll test it, but we need to support also legacy bios. > I wasn't aware it wouldn't build on the "pc" platform, but I never even > tried in the first place. The patch series definitely needs more > polishing anyway, but thanks for making me aware. Thanks! One more note: "Argon2 not supported" is not shown, instead there is "Invalid encryption" printed later in luks2_recover_key(). It was trivial to modify sources to find it, but that will not be user friendly for users which will run grub2 from distro package. > > BTW as Argon2 is the default PBKDF algorithm in current cryptsetup, Debian > > installer (and probably other distros' installers) uses it and it has to be > > converted after installation with Live CD / connecting HDD on different machine. > > Therefore postponing Argon2 to another release means users will have it in 2+ > > years after 2.06 release (unless distros backport it). > That cannot be helped, unfortunately. The current release has been > taking far too long already, and delaying it even further will > completely bar anybody from using LUKS2 with GRUB in the first place. Sure, understand. > I don't really know about the release cycle, but personally I wouldn't > mind to accelerate it. That's only my two cents though as somebody who > hasn't been involved in the project that deeply. +1 (that would allow to greatly reduce number of patches in distros, but understand the lack of maintainers time). Kind regards, Petr > Patrick