From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7615C43381 for ; Tue, 19 Jan 2021 21:10:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A873B22D71 for ; Tue, 19 Jan 2021 21:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390364AbhASVKL (ORCPT ); Tue, 19 Jan 2021 16:10:11 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51965 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389908AbhASVKE (ORCPT ); Tue, 19 Jan 2021 16:10:04 -0500 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 6F8E7E0008; Tue, 19 Jan 2021 21:09:20 +0000 (UTC) Date: Tue, 19 Jan 2021 22:09:20 +0100 From: Alexandre Belloni To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Lee Jones , Rob Herring , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 02/17] rtc: bd70528: Do not require parent data Message-ID: <20210119210920.GR3666@piout.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 19/01/2021 09:14:45+0200, Matti Vaittinen wrote: > The ROHM BD71828 and BD71815 RTC drivers only need the regmap > pointer from parent. Regmap can be obtained via dev_get_regmap() > so do not require parent to populate driver data for that. > > BD70528 on the other hand requires parent data to access the > watchdog so leave the parent data for BD70528 here for now. > > Signed-off-by: Matti Vaittinen Acked-by: Alexandre Belloni > --- > > Please note that this same change has been sent individually: > https://lore.kernel.org/lkml/20210105152350.GA3714833@localhost.localdomain/ > It is present in this series only because some patches depend on it. > Then I think it is best to have it as part of this series. > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ I've alway wanted to comment on that, should he have to say "I don't think" to vanish ? Because saying "I don't think so," means that he thinks this is not so. > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ And I guess this should be simply "non cogito" ;) -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com