All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/14] rtc: rv3029: use rtc_lock/rtc_unlock
Date: Tue, 19 Jan 2021 23:06:49 +0100	[thread overview]
Message-ID: <20210119220653.677750-11-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20210119220653.677750-1-alexandre.belloni@bootlin.com>

Avoid accessing directly rtc->ops_lock and use the RTC core helpers.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-rv3029c2.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c
index c1f4c0bba1e5..71102c7fbd7d 100644
--- a/drivers/rtc/rtc-rv3029c2.c
+++ b/drivers/rtc/rtc-rv3029c2.c
@@ -265,24 +265,23 @@ static irqreturn_t rv3029_handle_irq(int irq, void *dev_id)
 {
 	struct device *dev = dev_id;
 	struct rv3029_data *rv3029 = dev_get_drvdata(dev);
-	struct mutex *lock = &rv3029->rtc->ops_lock;
 	unsigned int flags, controls;
 	unsigned long events = 0;
 	int ret;
 
-	mutex_lock(lock);
+	rtc_lock(rv3029->rtc);
 
 	ret = regmap_read(rv3029->regmap, RV3029_IRQ_CTRL, &controls);
 	if (ret) {
 		dev_warn(dev, "Read IRQ Control Register error %d\n", ret);
-		mutex_unlock(lock);
+		rtc_unlock(rv3029->rtc);
 		return IRQ_NONE;
 	}
 
 	ret = regmap_read(rv3029->regmap, RV3029_IRQ_FLAGS, &flags);
 	if (ret) {
 		dev_warn(dev, "Read IRQ Flags Register error %d\n", ret);
-		mutex_unlock(lock);
+		rtc_unlock(rv3029->rtc);
 		return IRQ_NONE;
 	}
 
@@ -297,7 +296,7 @@ static irqreturn_t rv3029_handle_irq(int irq, void *dev_id)
 		regmap_write(rv3029->regmap, RV3029_IRQ_FLAGS, flags);
 		regmap_write(rv3029->regmap, RV3029_IRQ_CTRL, controls);
 	}
-	mutex_unlock(lock);
+	rtc_unlock(rv3029->rtc);
 
 	return IRQ_HANDLED;
 }
-- 
2.29.2


  parent reply	other threads:[~2021-01-19 22:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 22:06 [PATCH 01/14] rtc: ac100: use rtc_lock/rtc_unlock Alexandre Belloni
2021-01-19 22:06 ` [PATCH 02/14] rtc: asm9260: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 03/14] rtc: ds1305: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 04/14] rtc: ds1307: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 05/14] rtc: ds1685: " Alexandre Belloni
2021-01-25  3:33   ` Joshua Kinard
2021-01-19 22:06 ` [PATCH 06/14] rtc: ds3232: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 07/14] rtc: hym8563: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 08/14] rtc: m41t80: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 09/14] rtc: mcp795: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 10/14] rtc: pcf2123: " Alexandre Belloni
2021-01-19 22:06 ` Alexandre Belloni [this message]
2021-01-19 22:06 ` [PATCH 12/14] rtc: rx8010: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 13/14] rtc: rx8025: " Alexandre Belloni
2021-01-19 22:06 ` [PATCH 14/14] rtc: stm32: " Alexandre Belloni
2021-01-19 22:06   ` Alexandre Belloni
2021-01-20 17:50 ` [PATCH 01/14] rtc: ac100: " kernel test robot
2021-01-20 17:50   ` kernel test robot
2021-01-25 22:14 ` [PATCH v2] " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210119220653.677750-11-alexandre.belloni@bootlin.com \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.