From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE20C433E6 for ; Wed, 20 Jan 2021 06:09:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46B282313A for ; Wed, 20 Jan 2021 06:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbhATGJJ (ORCPT ); Wed, 20 Jan 2021 01:09:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:42904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbhATGI6 (ORCPT ); Wed, 20 Jan 2021 01:08:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C44C6217BA; Wed, 20 Jan 2021 06:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611122897; bh=RR54Qs4HyvFncXLjeeZ8ZNoWbpER2eGQN67MAA65J8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n8ZMmcVpD1uURQ5NGIAawLGiLgoRL2IAUVgy9CnCdUSYva1zb9C/4vq4IQ4uIJ7EM HGTqKG7/BNZL4PfOqcKP3WNISw6EtYR1OrQaf/ea19W3qq8JLPmfrwkdWXwOH5qQk2 q9U+gthlT1Pz61jqJBZR2LNKJ8OPL7aAMeg2UFJJaFrNJB/4dHuLljKNc2s12Tqki+ SqiWM0xJNMLD1oIZPU6ay0Mh1AitLYMB6UCbBVKVrYm7jji9KAke9dlTjN+azi7ufg 2yp5Xo9bYxFK6y+BhMS1cNATbYAiH39s4auOZJ7lz9TlsRiLBo3rsH+HRRR8nWE2hx zD5LenpclqHHQ== Date: Tue, 19 Jan 2021 22:08:15 -0800 From: Jakub Kicinski To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Wu , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH AUTOSEL 5.10 28/45] net: stmmac: Fixed mtu channged by cache aligned Message-ID: <20210119220815.039ac330@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210120012602.769683-28-sashal@kernel.org> References: <20210120012602.769683-1-sashal@kernel.org> <20210120012602.769683-28-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Jan 2021 20:25:45 -0500 Sasha Levin wrote: > From: David Wu > > [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] > > Since the original mtu is not used when the mtu is updated, > the mtu is aligned with cache, this will get an incorrect. > For example, if you want to configure the mtu to be 1500, > but mtu 1536 is configured in fact. > > Fixed: eaf4fac478077 ("net: stmmac: Do not accept invalid MTU values") > Signed-off-by: David Wu > Link: https://lore.kernel.org/r/20210113034109.27865-1-david.wu@rock-chips.com > Signed-off-by: Jakub Kicinski > Signed-off-by: Sasha Levin This was applied 6 days ago, I thought you said you wait two weeks. What am I missing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F0A7C433E0 for ; Wed, 20 Jan 2021 06:10:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7E6323159 for ; Wed, 20 Jan 2021 06:10:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7E6323159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=64XxRpdRI7o872sO6wzm2M/dNsOcGycg1cMsAtEo2F0=; b=t8p/RHh2gyGiNDkRlB09NIOQO uYCm1f8sD0my7ZJJ/b1O962igOJ3jaOWURkW28WmXUVW7apggLsWRSYim4HFo4BTCaa+f88Qw+zwm n7kDAL/sLpAOvp+/XoPvDuyFKyKTHAjXsECaihJCobHb8s1bhk2xE3g0mej32u4qB1rxOmFXX7SnV OCN3zuEnGIbhKpbAxCsuaFs7o+IHeQ7Vl5565D7LfujZEOUtnaEWL9/H1fiz/eskMx2WSE8V6QOAp AFfZiqeurtjY6kDOxGYhPRCMsjybeoeLRgWxsCT6WvAs8JEK4h/HjM5YfF0m3XGi68lf2EL1r8qMO 3m2Mu7cfQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l26fG-0006yd-LB; Wed, 20 Jan 2021 06:08:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l26fD-0006yG-E2 for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 06:08:20 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C44C6217BA; Wed, 20 Jan 2021 06:08:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611122897; bh=RR54Qs4HyvFncXLjeeZ8ZNoWbpER2eGQN67MAA65J8g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=n8ZMmcVpD1uURQ5NGIAawLGiLgoRL2IAUVgy9CnCdUSYva1zb9C/4vq4IQ4uIJ7EM HGTqKG7/BNZL4PfOqcKP3WNISw6EtYR1OrQaf/ea19W3qq8JLPmfrwkdWXwOH5qQk2 q9U+gthlT1Pz61jqJBZR2LNKJ8OPL7aAMeg2UFJJaFrNJB/4dHuLljKNc2s12Tqki+ SqiWM0xJNMLD1oIZPU6ay0Mh1AitLYMB6UCbBVKVrYm7jji9KAke9dlTjN+azi7ufg 2yp5Xo9bYxFK6y+BhMS1cNATbYAiH39s4auOZJ7lz9TlsRiLBo3rsH+HRRR8nWE2hx zD5LenpclqHHQ== Date: Tue, 19 Jan 2021 22:08:15 -0800 From: Jakub Kicinski To: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.10 28/45] net: stmmac: Fixed mtu channged by cache aligned Message-ID: <20210119220815.039ac330@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210120012602.769683-28-sashal@kernel.org> References: <20210120012602.769683-1-sashal@kernel.org> <20210120012602.769683-28-sashal@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_010819_539227_60EEE882 X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Wu , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 19 Jan 2021 20:25:45 -0500 Sasha Levin wrote: > From: David Wu > > [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ] > > Since the original mtu is not used when the mtu is updated, > the mtu is aligned with cache, this will get an incorrect. > For example, if you want to configure the mtu to be 1500, > but mtu 1536 is configured in fact. > > Fixed: eaf4fac478077 ("net: stmmac: Do not accept invalid MTU values") > Signed-off-by: David Wu > Link: https://lore.kernel.org/r/20210113034109.27865-1-david.wu@rock-chips.com > Signed-off-by: Jakub Kicinski > Signed-off-by: Sasha Levin This was applied 6 days ago, I thought you said you wait two weeks. What am I missing? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel