From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8FCC4332D for ; Wed, 20 Jan 2021 06:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3E6A23142 for ; Wed, 20 Jan 2021 06:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729755AbhATG2I (ORCPT ); Wed, 20 Jan 2021 01:28:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728982AbhATGVK (ORCPT ); Wed, 20 Jan 2021 01:21:10 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B140C0613CF for ; Tue, 19 Jan 2021 22:20:23 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id m6so13863339pfm.6 for ; Tue, 19 Jan 2021 22:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s6C+mbhedQCP+zudi5mxquluGRK7D+VGS5SgYthRSds=; b=WgYhoD8yxocJ85iXXmVyCBnc24BrEivMRF1Tb8iCP7Uda5K63BkrHdCjTqppP/WbCA zI2onxF6t3pfa2MTQMPIVzMcCtPfE3zhIoEdsNh5CWE8uECvpKXRewnhVQnjT7B/+mwk rIU0TpWE/YqQyWwzP/xTAmTQRTndEF+vK/v0ymWR/DQtzwqz9XzYQICA11Y70fBgYS+l 8g8JeQeEjmtg0veHXZRqAuTosQUaByNm8iLNxxIn4YXf5Ps8YsIvk+TJNdwOqyW5so8p LyYZrYiF4x0MdQx0tl35ZBr1N4mKau2k/l4ae+N57NAJzrysiCr1uENk7QPQI+WgPqLd O5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=s6C+mbhedQCP+zudi5mxquluGRK7D+VGS5SgYthRSds=; b=k96Ql19odd+v9viiMAGvPcTU1eWBhzaQNWQAF/AzrFONyyPvcnpOjXH1qCpQ2pGYns QwgQMmjNwb4GVgNroT44s2cnBlFXgFEaOphylrC11T1AlrZ9VgtFI4VV5NvVMIdvXALs CdXHHzWnmz+5wPOmGunDKdF/mQdtO1rntpfKZYYy8T71TmJu2I3dcFURPFPDMaCfHLBG 2+VHQuF0d6+tMRMbKbgW+HeoCZ3Qr1UHTSLkOWp5bATZfz4vCdHmLLOzg+lXEHwqFm/F Z7cvvyw8l5Delcp27kuJiHhRKQJl3AjZPejDH+45WCXBGhmwWzSDince8nCenph2PlO3 JIvg== X-Gm-Message-State: AOAM530I7gs9qH5OPjp0sOVcgYZEROUfciTQWZHzgvHqC/deiSlvlLha 6Z/QZ2X8tb1Y5KbEEyw0IqHuPQ== X-Google-Smtp-Source: ABdhPJxLMUyE+2pwrS0UVGPFMaBcYi/uM33r5JfTx1Pgy3Xp8LXpTj6aZrSgZfqJw/i9I+XYAOqi5g== X-Received: by 2002:a65:458e:: with SMTP id o14mr7834909pgq.444.1611123622455; Tue, 19 Jan 2021 22:20:22 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id n8sm1015976pjo.18.2021.01.19.22.20.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jan 2021 22:20:21 -0800 (PST) Date: Wed, 20 Jan 2021 11:50:19 +0530 From: Viresh Kumar To: Frank Rowand Cc: Rob Herring , pantelis.antoniou@konsulko.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Vincent Guittot , Bill Mills , anmar.oueja@linaro.org, Masahiro Yamada Subject: Re: [PATCH] of: unittest: Statically apply overlays using fdtoverlay Message-ID: <20210120062019.itpakykj2ah5oxp3@vireshk-i7> References: <1e42183ccafa1afba33b3e79a4e3efd3329fd133.1610095159.git.viresh.kumar@linaro.org> <20210119022154.2338781-1-frowand.list@gmail.com> <20210119080546.dzec3jatsz2662qs@vireshk-i7> <20210120050606.b2m4jssh73wexybx@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210120050606.b2m4jssh73wexybx@vireshk-i7> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-01-21, 10:36, Viresh Kumar wrote: > On 19-01-21, 09:44, Frank Rowand wrote: > > No. overlay_base.dts is intentionally compiled into a base FDT, not > > an overlay. Unittest intentionally unflattens this FDT in early boot, > > in association with unflattening the system FDT. One key intent > > behind this is to use the same memory allocation method that is > > used for the system FDT. > > > > Do not try to convert overlay_base.dts into an overlay. > > Okay, but why does it have /plugin/; specified in it then ? > > And shouldn't we create two separate dtb-s now, static_test.dtb and > static_overlay_test.dtb ? As fdtoverlay will not be able to merge it with > testcase.dtb anyway. > > Or maybe we can create another file static_overlay.dts (like testcases.dts) > which can include both testcases.dts and overlay_base.dts, and then we can > create static_test.dtb out of it ? That won't impact the runtime tests at all. Hmm, I noticed just now that you have kept overlay.dtb out of the build, probably we should then drop overlay_base.dtb as well ? -- viresh