From: Christoph Hellwig <hch@infradead.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc: kjlu@umn.edu, Jens Axboe <axboe@kernel.dk>,
Jan Kara <jack@suse.cz>, Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Fix an error handling in add_partition
Date: Wed, 20 Jan 2021 10:05:44 +0000 [thread overview]
Message-ID: <20210120100544.GC3694085@infradead.org> (raw)
In-Reply-To: <20210117085023.24352-1-dinghao.liu@zju.edu.cn>
On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-01-20 11:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 8:50 [PATCH] block: Fix an error handling in add_partition Dinghao Liu
2021-01-20 10:05 ` Christoph Hellwig [this message]
2021-01-25 4:36 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2021-01-16 7:27 Dinghao Liu
2021-01-16 8:18 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120100544.GC3694085@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dinghao.liu@zju.edu.cn \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=kjlu@umn.edu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.