* ARM: dts: sun7i: a20: bananapro: Fix ethernet node
@ 2021-01-20 11:07 Hermann.Lauer
0 siblings, 0 replies; 3+ messages in thread
From: Hermann.Lauer @ 2021-01-20 11:07 UTC (permalink / raw)
To: linux-arm-kernel
BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
it's devicetree, too. Without this patch you will get high packet loss rates.
Tested-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
From: Jernej Skrabec <jernej.skrabec@siol.net>
Date: Sun, 25 Oct 2020 09:19:49 +0100
Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node
Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
ethernet node to reflect that fact.
Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC ethernet controller")
---
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
--- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
@@ -110,7 +110,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-supply = <®_gmac_3v3>;
status = "okay";
};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ARM: dts: sun7i: a20: bananapro: Fix ethernet node
2021-01-20 11:40 Hermann.Lauer
@ 2021-01-20 23:48 ` Jernej Škrabec
0 siblings, 0 replies; 3+ messages in thread
From: Jernej Škrabec @ 2021-01-20 23:48 UTC (permalink / raw)
To: linux-arm-kernel, Hermann.Lauer; +Cc: wens, mripard
Hi!
Change itself it's fine, just few comments on your commit message and e-mail
recipients.
Dne sreda, 20. januar 2021 ob 12:40:26 CET je Hermann.Lauer@uni-heidelberg.de
napisal(a):
> BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
> it's devicetree, too. Without this patch you will get high packet loss
rates.
M2 Ultra has nothing to do with BananaPro, it's better to explain real reason
why this change fixes ethernet.
>
> Tested-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
Tested-by tag from the patch author is not very useful, it's already expected
that you (or person you know) tested it, when sending fixes.
>
> From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
> From: Jernej Skrabec <jernej.skrabec@siol.net>
> Date: Sun, 25 Oct 2020 09:19:49 +0100
> Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node
As I said, referencing fix for another, unrelated board is not really
meaningful.
>
> Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
> ethernet node to reflect that fact.
>
> Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC
ethernet controller")
Fixes tag is for M2 Ultra and completely irrelevant here. Please provide
proper Fixes tag for this file.
You are missing Signed-of-by tag at the end of the message.
You missed few maintainers and mailing lists in "to" and "cc" field. Run
"scripts/get_maintainer.pl" on this patch to get full list of recipients.
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* ARM: dts: sun7i: a20: bananapro: Fix ethernet node
@ 2021-01-20 11:40 Hermann.Lauer
2021-01-20 23:48 ` Jernej Škrabec
0 siblings, 1 reply; 3+ messages in thread
From: Hermann.Lauer @ 2021-01-20 11:40 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: wens, jernej.skrabec, mripard
BananaPro 1GB works only reliable with the patch for M2 Ultra applied to
it's devicetree, too. Without this patch you will get high packet loss rates.
Tested-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de>
From b3eec3212e66ece33f69be0de98d54e67834e798 Mon Sep 17 00:00:00 2001
From: Jernej Skrabec <jernej.skrabec@siol.net>
Date: Sun, 25 Oct 2020 09:19:49 +0100
Subject: ARM: dts: sun8i: r40: bananapi-m2-ultra: Fix ethernet node
Ethernet PHY on BananaPi M2 Ultra provides RX and TX delays. Fix
ethernet node to reflect that fact.
Fixes: c36fd5a48bd2 ("ARM: dts: sun8i: r40: bananapi-m2-ultra: Enable GMAC ethernet controller")
---
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
--- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
@@ -110,7 +110,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-supply = <®_gmac_3v3>;
status = "okay";
};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-20 23:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 11:07 ARM: dts: sun7i: a20: bananapro: Fix ethernet node Hermann.Lauer
2021-01-20 11:40 Hermann.Lauer
2021-01-20 23:48 ` Jernej Škrabec
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.