All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Vosmaer <jacob@gitlab.com>
To: git@vger.kernel.org
Cc: avarab@gmail.com, peff@peff.net, me@ttaylorr.com,
	Jacob Vosmaer <jacob@gitlab.com>
Subject: [PATCH v2 0/1] builtin/pack-objects.c: avoid iterating all refs
Date: Wed, 20 Jan 2021 13:45:13 +0100	[thread overview]
Message-ID: <20210120124514.49737-1-jacob@gitlab.com> (raw)

I have updated the patch with more background information in the
commit message, and I have cleaned up the add_ref_tag iterator
callback a bit. I also switched to for_each_tag_ref.

On the previous version of the patch there was some discussion about
whether we can use for_each_tag_ref in combination with peel_ref. It
turns out we can, and we were already doing it in the same file:
search for mark_tagged to see what I mean.

Jacob Vosmaer (1):
  builtin/pack-objects.c: avoid iterating all refs

 builtin/pack-objects.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

-- 
2.30.0


             reply	other threads:[~2021-01-20 17:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 12:45 Jacob Vosmaer [this message]
2021-01-20 12:45 ` [PATCH v2 1/1] builtin/pack-objects.c: avoid iterating all refs Jacob Vosmaer
2021-01-20 14:49   ` Taylor Blau
2021-01-20 16:18     ` Jeff King
2021-01-20 16:19       ` Taylor Blau
2021-01-20 18:49         ` Jacob Vosmaer
2021-01-20 19:45         ` Jeff King
2021-01-20 21:46           ` Jacob Vosmaer
2021-01-20 21:52             ` Taylor Blau
2021-01-21  2:54             ` Jeff King
2021-01-22 16:46               ` Jacob Vosmaer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120124514.49737-1-jacob@gitlab.com \
    --to=jacob@gitlab.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.