From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Kevin Hao <haokexin@gmail.com>
Cc: linux-mips@vger.kernel.org
Subject: Re: [PATCH] MIPS: OCTEON: Fix the boot broken when using built-in DTB
Date: Wed, 20 Jan 2021 18:39:12 +0100 [thread overview]
Message-ID: <20210120173912.GA16543@alpha.franken.de> (raw)
In-Reply-To: <20210119105648.GA343327@pek-khao-d2.corp.ad.wrs.com>
On Tue, Jan 19, 2021 at 06:56:48PM +0800, Kevin Hao wrote:
> > .... IMHO the real bug is d9df9fb901d2 MIPS: Octeon: Remove special handling
> > of CONFIG_MIPS_ELF_APPENDED_DTB=y. I'm tending to simply revert that commit.
>
> Yes, this indeed seem much better. I will send a patch to revert d9df9fb901d2.
> Another issue is that the name of fw_passed_dtb seems pretty confusion after the
> change of commit 37e5c69ffd41. Could we rename it to something like final_dtb_addr?
this wouldn't make the mess smaller, IMHO. My idea is to add a helper
function, which deals with all the possible sources of dtbs, which
could be used instead of fw_passed_dtb. This gets rid of the ugly
#ifdefry in head.S and hopefull makes future changes less error prone.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-01-20 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 11:49 [PATCH] MIPS: OCTEON: Fix the boot broken when using built-in DTB Kevin Hao
2021-01-18 18:24 ` Thomas Bogendoerfer
2021-01-19 10:56 ` Kevin Hao
2021-01-20 17:39 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120173912.GA16543@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=haokexin@gmail.com \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.