From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com,
drjones@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH v3 1/3] s390x: pv: implement routine to share/unshare memory
Date: Wed, 20 Jan 2021 17:48:09 +0100 [thread overview]
Message-ID: <20210120174809.64bb8e4d@ibm-vm> (raw)
In-Reply-To: <211a4bd3-763a-f8fc-3c08-8d8d1809cc7c@redhat.com>
On Wed, 20 Jan 2021 11:48:52 +0100
Thomas Huth <thuth@redhat.com> wrote:
[...]
> > +/*
> > + * Guest 2 request to the Ultravisor to make a page shared with the
> > + * hypervisor for IO.
> > + *
> > + * @addr: Real or absolute address of the page to be shared
>
> When is it real, and when is it absolute?
as far as we are concerned, it's unpredictable
this means that a guest should avoid sharing any prefix (or
reverse prefix) pages.
> > + */
> > +static inline int uv_set_shared(unsigned long addr)
> > +{
> > + return share(addr, UVC_CMD_SET_SHARED_ACCESS);
> > +}
> > +
> > +/*
> > + * Guest 2 request to the Ultravisor to make a page unshared.
> > + *
> > + * @addr: Real or absolute address of the page to be unshared
>
> dito
same
> > + */
> > +static inline int uv_remove_shared(unsigned long addr)
> > +{
> > + return share(addr, UVC_CMD_REMOVE_SHARED_ACCESS);
> > +}
> > +
> > #endif
>
> Apart from the nits:
> Acked-by: Thomas Huth <thuth@redhat.com>
>
next prev parent reply other threads:[~2021-01-20 16:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 19:52 [kvm-unit-tests PATCH v3 0/3] s390x: css: pv: css test adaptation for PV Pierre Morel
2021-01-19 19:52 ` [kvm-unit-tests PATCH v3 1/3] s390x: pv: implement routine to share/unshare memory Pierre Morel
2021-01-20 10:48 ` Thomas Huth
2021-01-20 12:16 ` Pierre Morel
2021-01-20 16:48 ` Claudio Imbrenda [this message]
2021-01-19 19:52 ` [kvm-unit-tests PATCH v3 2/3] s390x: define UV compatible I/O allocation Pierre Morel
2021-01-20 11:01 ` Thomas Huth
2021-01-20 12:39 ` Pierre Morel
2021-01-20 12:25 ` Claudio Imbrenda
2021-01-20 12:41 ` Pierre Morel
2021-01-19 19:52 ` [kvm-unit-tests PATCH v3 3/3] s390x: css: pv: css test adaptation for PV Pierre Morel
2021-01-20 12:03 ` Thomas Huth
2021-01-21 9:07 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120174809.64bb8e4d@ibm-vm \
--to=imbrenda@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.