From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BECB0C433E0 for ; Wed, 20 Jan 2021 18:42:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AFBD23406 for ; Wed, 20 Jan 2021 18:42:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404649AbhATSZ5 (ORCPT ); Wed, 20 Jan 2021 13:25:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:47364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391968AbhATSSy (ORCPT ); Wed, 20 Jan 2021 13:18:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E69E3233ED; Wed, 20 Jan 2021 18:18:10 +0000 (UTC) Date: Wed, 20 Jan 2021 18:18:08 +0000 From: Catalin Marinas To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Will Deacon , Mark Rutland , David Brazdil , Alexandru Elisei , Ard Biesheuvel , Jing Zhang , Ajay Patil , Prasad Sodagudi , Srinivas Ramana , James Morse , Julien Thierry , Suzuki K Poulose , kernel-team@android.com Subject: Re: [PATCH v4 02/21] arm64: Fix outdated TCR setup comment Message-ID: <20210120181807.GB17952@gaia> References: <20210118094533.2874082-1-maz@kernel.org> <20210118094533.2874082-3-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118094533.2874082-3-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 18, 2021 at 09:45:14AM +0000, Marc Zyngier wrote: > The arm64 kernel has long be able to use more than 39bit VAs. > Since day one, actually. Let's rewrite the offending comment. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/mm/proc.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > index 1f7ee8c8b7b8..ece785477bdc 100644 > --- a/arch/arm64/mm/proc.S > +++ b/arch/arm64/mm/proc.S > @@ -464,8 +464,8 @@ SYM_FUNC_START(__cpu_setup) > #endif > msr mair_el1, x5 > /* > - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for > - * both user and kernel. > + * Set/prepare TCR and TTBR. TCR_EL1.T1SZ gets further > + * adjusted if the kernel is compiled with 52bit VA support. I think both T0SZ and T1SZ get updated based on a mismatch between the kernel configuration and the hardware support. Anyway, I'm not asking for a detailed comment here, so: Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24805C433E0 for ; Wed, 20 Jan 2021 18:18:21 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 74A6C233FE for ; Wed, 20 Jan 2021 18:18:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74A6C233FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B1CC74B19B; Wed, 20 Jan 2021 13:18:19 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rBQebzrU2AsC; Wed, 20 Jan 2021 13:18:17 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CF7E54B19D; Wed, 20 Jan 2021 13:18:17 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1A6874B19B for ; Wed, 20 Jan 2021 13:18:16 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZL4owrLezUIf for ; Wed, 20 Jan 2021 13:18:15 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 074684B19A for ; Wed, 20 Jan 2021 13:18:14 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id E69E3233ED; Wed, 20 Jan 2021 18:18:10 +0000 (UTC) Date: Wed, 20 Jan 2021 18:18:08 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH v4 02/21] arm64: Fix outdated TCR setup comment Message-ID: <20210120181807.GB17952@gaia> References: <20210118094533.2874082-1-maz@kernel.org> <20210118094533.2874082-3-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118094533.2874082-3-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Prasad Sodagudi , Srinivas Ramana , linux-kernel@vger.kernel.org, Ard Biesheuvel , Ajay Patil , kernel-team@android.com, Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Jan 18, 2021 at 09:45:14AM +0000, Marc Zyngier wrote: > The arm64 kernel has long be able to use more than 39bit VAs. > Since day one, actually. Let's rewrite the offending comment. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/mm/proc.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > index 1f7ee8c8b7b8..ece785477bdc 100644 > --- a/arch/arm64/mm/proc.S > +++ b/arch/arm64/mm/proc.S > @@ -464,8 +464,8 @@ SYM_FUNC_START(__cpu_setup) > #endif > msr mair_el1, x5 > /* > - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for > - * both user and kernel. > + * Set/prepare TCR and TTBR. TCR_EL1.T1SZ gets further > + * adjusted if the kernel is compiled with 52bit VA support. I think both T0SZ and T1SZ get updated based on a mismatch between the kernel configuration and the hardware support. Anyway, I'm not asking for a detailed comment here, so: Acked-by: Catalin Marinas _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0911C433E0 for ; Wed, 20 Jan 2021 18:19:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 506B8233ED for ; Wed, 20 Jan 2021 18:19:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 506B8233ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9uPhJ0qC65aW1868X8wPudavT/n25dCPRyYC32ZXGO8=; b=IoY+EfmV05S3YLqIqwJM/wwj4 F8ICSR3AssRxKAjR6xcZn4VAjgXRHJxK7RFFVgI/yRRBDNp2AKXW/2lZPFoqmjeGzYtiKWlHBYwXa p5wKykAgB/LREsBXoILph71PM0mgHieMxPJdfW0/DEITKNEtblsciOLS7h8uCLlRK3dePnw9bqGYu vkIop07+9zNBN5dl7rQ5IUNc1dcRy7fjqJtjJ7BSUjTuQnSnEskfN8yWOGcwgOu34jcnkEiRunLw/ oDiucZRKnWvx9ZremKATUlC/Tm0HsZSRjjjlQBwOOTLjmPQxiKepYBaJgBeKs+JNKM7+ukh29lCbi rLE/eeJwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2I3d-0008Hv-Q5; Wed, 20 Jan 2021 18:18:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2I3a-0008HU-GI for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 18:18:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E69E3233ED; Wed, 20 Jan 2021 18:18:10 +0000 (UTC) Date: Wed, 20 Jan 2021 18:18:08 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH v4 02/21] arm64: Fix outdated TCR setup comment Message-ID: <20210120181807.GB17952@gaia> References: <20210118094533.2874082-1-maz@kernel.org> <20210118094533.2874082-3-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210118094533.2874082-3-maz@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_131814_649685_75013B8A X-CRM114-Status: GOOD ( 16.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jing Zhang , Prasad Sodagudi , Srinivas Ramana , Suzuki K Poulose , Alexandru Elisei , linux-kernel@vger.kernel.org, Ard Biesheuvel , James Morse , Julien Thierry , Ajay Patil , kernel-team@android.com, David Brazdil , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 18, 2021 at 09:45:14AM +0000, Marc Zyngier wrote: > The arm64 kernel has long be able to use more than 39bit VAs. > Since day one, actually. Let's rewrite the offending comment. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/mm/proc.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > index 1f7ee8c8b7b8..ece785477bdc 100644 > --- a/arch/arm64/mm/proc.S > +++ b/arch/arm64/mm/proc.S > @@ -464,8 +464,8 @@ SYM_FUNC_START(__cpu_setup) > #endif > msr mair_el1, x5 > /* > - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for > - * both user and kernel. > + * Set/prepare TCR and TTBR. TCR_EL1.T1SZ gets further > + * adjusted if the kernel is compiled with 52bit VA support. I think both T0SZ and T1SZ get updated based on a mismatch between the kernel configuration and the hardware support. Anyway, I'm not asking for a detailed comment here, so: Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel