From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pratyush Yadav Date: Thu, 21 Jan 2021 00:29:38 +0530 Subject: [PATCH 0/2] Console/stdio use after free In-Reply-To: References: <20210120140454.4286-1-nsaenzjulienne@suse.de> Message-ID: <20210120185936.lz3czug3ku6xhmit@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 20/01/21 07:18AM, Simon Glass wrote: > Hi Nicolas, > > On Wed, 20 Jan 2021 at 07:04, Nicolas Saenz Julienne > wrote: > > > > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > > introduces a use after free in usb_kbd_remove(): > > > > - usbkbd's stdio device is de-registered with stdio_deregister_dev(), > > the struct stdio_dev is freed. > > > > - iomux_doenv() is called, usbkbd removed from the console list, and > > console_stop() is called on the struct stdio_dev pointer that no > > longer exists. > > > > This series mitigates this by making sure the pointer is really a stdio > > device prior performing the stop operation. It's not ideal, but I > > couldn't figure out a nicer way to fix this. > > Your 'from' address is coming through as just your email. Could you > please update it to include your name as well? >From shows the full name on my email client. For everybody apart from Nicholas it shows just the email, but for Nicholas I can see full name in both From and Cc. Maybe something wrong with your email client settings. > Regards, > Simon -- Regards, Pratyush Yadav Texas Instruments India