All of
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <>
Cc: Daniel Henrique Barboza <>,,,
Subject: [PATCH v1 2/2] spapr.c: add 'name' property for hotplugged CPUs nodes
Date: Wed, 20 Jan 2021 20:23:05 -0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

In the CPU hotunplug bug [1] the guest kernel throws a scary
message in dmesg:

pseries-hotplug-cpu: Failed to offline CPU <NULL>, rc: -16

The reason isn't related to the bug though. This happens because the
kernel file arch/powerpc/platform/pseries/hotplug-cpu.c, function
dlpar_cpu_remove(), is not finding the of the offending

We're not populating the 'name' property for hotplugged CPUs. Since the
kernel relies on for identifying CPU nodes, and the
CPUs that are coldplugged has the 'name' property filled by SLOF, this
is creating an unneeded inconsistency between hotplug and coldplug CPUs
in the kernel.

Let's fill the 'name' property for hotplugged CPUs as well. This will
make the guest dmesg throws a less intimidating message when we try to
unplug the last online CPU:

pseries-hotplug-cpu: Failed to offline CPU PowerPC,POWER9@1, rc: -16


Signed-off-by: Daniel Henrique Barboza <>
 hw/ppc/spapr.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index cc1b709615..6ab27ea269 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3750,6 +3750,19 @@ int spapr_core_dt_populate(SpaprDrc *drc, SpaprMachineState *spapr,
     spapr_dt_cpu(cs, fdt, offset, spapr);
+    /*
+     * spapr_dt_cpu() does not fill the 'name' property in the
+     * CPU node. The function is called during boot process, before
+     * and after CAS, and overwriting the 'name' property written
+     * by SLOF is not allowed.
+     *
+     * Write it manually after spapr_dt_cpu(). This makes the hotplug
+     * CPUs more compatible with the coldplugged ones, which have
+     * the 'name' property. Linux Kernel also relies on this
+     * property to identify CPU nodes.
+     */
+    _FDT((fdt_setprop_string(fdt, offset, "name", nodename)));
     *fdt_start_offset = offset;
     return 0;

  parent reply	other threads:[~2021-01-20 23:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 23:23 [PATCH v1 0/2] spapr.c: add 'name' property for hotplugged CPUs nodes Daniel Henrique Barboza
2021-01-20 23:23 ` [PATCH v1 1/2] spapr.c: use g_auto* with 'nodename' in CPU DT functions Daniel Henrique Barboza
2021-01-21  0:27   ` David Gibson
2021-01-20 23:23 ` Daniel Henrique Barboza [this message]
2021-01-21  0:43   ` [PATCH v1 2/2] spapr.c: add 'name' property for hotplugged CPUs nodes David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.