From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Wed, 20 Jan 2021 20:10:51 -0700 Subject: [PATCH v2 0/6] log: Allow multiple lines and conversion to printf() Message-ID: <20210121031057.559301-1-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de At present when logging is not enabled, all log() calls become nops. This does not seem right, since if the log level is high enough then there should be some sort of message. So in that case, this series updates it to print the message if the log level is above LOGL_INFO. This mimics the behaviour for the log_...() macros like log_debug() and log_info(), so we can drop the special case for these. Also the current implementation does not support multiple log calls on the same line nicely. The tags are repeated so the line is very hard to read. This series adds that as a new feature. Changes in v2: - Move the newline check into log_dispatch() - Update commit message and cover letter to mention log_...() macros - Add a test for !CONFIG_LOG - Update log() to (effectively) call debug() for log_level == LOGL_DEBUG Simon Glass (6): log: Set up a flag byte for log records log: Handle line continuation log: Add return-checking macros for 0 being success sandbox: log: Avoid build error with !CONFIG_LOG tpm: Don't select LOG log: Convert log values to printf() if not enabled cmd/Kconfig | 1 - common/log.c | 16 +++++-- common/log_console.c | 26 +++++++----- configs/sandbox_defconfig | 15 ++++--- doc/develop/logging.rst | 37 +++++++++++++++-- include/asm-generic/global_data.h | 6 +++ include/log.h | 69 ++++++++++++++++++++----------- test/log/Makefile | 3 +- test/log/cont_test.c | 19 +++++++-- test/log/nolog_ndebug.c | 38 +++++++++++++++++ test/log/nolog_test.c | 3 ++ 11 files changed, 178 insertions(+), 55 deletions(-) create mode 100644 test/log/nolog_ndebug.c -- 2.30.0.296.g2bfb1c46d8-goog