From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A8AC433E0 for ; Thu, 21 Jan 2021 07:50:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A7272313E for ; Thu, 21 Jan 2021 07:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727857AbhAUHuL (ORCPT ); Thu, 21 Jan 2021 02:50:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbhAUG6O (ORCPT ); Thu, 21 Jan 2021 01:58:14 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9350BC0613C1 for ; Wed, 20 Jan 2021 22:57:32 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id g15so1020750pjd.2 for ; Wed, 20 Jan 2021 22:57:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rUtmDYOZWBTxf9UWZYyTgxEJymEAYD1V+CFm2Cwj5oE=; b=zKWYsAaGAVfkuVwHuXb2le1Ng7fKUWMobE0WXs3dqRKkU7n5Wv1zcU3wNMT76oiTUz lLVzgAHjb16iIK2ipXv5aBuUDH1vLeJBVPM325Qpf5SXYOkyopMaPwuzj3nGvEh3oyCZ vgEJoAVBW7R8zdFmazofWHebI4dxKvt9zxdt0Dn8Qjx63oYuy7nbAnnjomTJxo7vm22G GjD4th4VSyw84uD8FnaejQWDFGH8CYHr9zFqz0K4TT0kTjNzRo5mI/6sXlTdPLQqukqU L0vHeWu+0istqq10w3eS3yE3urL9XpPvd8KdVeC7OIz6a8ktEPhgf4wjmXBK9dzx6y/h NkNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rUtmDYOZWBTxf9UWZYyTgxEJymEAYD1V+CFm2Cwj5oE=; b=HZLiHSdbMAgy2gFd16ZJvMOpCfRLCwe71c2TcjG1Tk3QUBFeY4nHUg7yeBnJTrq9l5 AeCDN6QXtw5ov4l5xTd3ACLwohlFo6vAO9KI5xbUoO6CKVpJDwMXYOx0J//ZTfDHUZbp 4QwiCbasovah2nMb8NU4tSoh/sWbWM0pULfDBTcdn80l04J88XCbsjJ1oW4ZJ5zel4zc j3f8CifQN2yGi0OPbQZxvbbzxWBYBKpnCrkcSx5YqSeTikHkjhgOla0xKVVA78kdJ3tC Mc8vdBBnQRVobH9GsXnNPRltmcUKkKKvhQLKh1I3BLJtBJmdSveE5Xy78TxEyeiUOK2T pNVA== X-Gm-Message-State: AOAM533w+AZxlg+IGnKFue8hPuhUn3IER0IrJPzkqS6PQp4TAkLptsC2 RUkxq13vlLQ5dlIVO6iByiCR+Q== X-Google-Smtp-Source: ABdhPJzhOl0HtEqutqCzxnWljZBU8BwIKjgI+j16tebtc4O5786lYFY0Hbxtp5+iVNVOGNHTqKEsXA== X-Received: by 2002:a17:902:ff04:b029:df:d5e5:9acc with SMTP id f4-20020a170902ff04b02900dfd5e59accmr334016plj.1.1611212252012; Wed, 20 Jan 2021 22:57:32 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id t2sm4593111pju.19.2021.01.20.22.57.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jan 2021 22:57:31 -0800 (PST) Date: Thu, 21 Jan 2021 12:27:28 +0530 From: Viresh Kumar To: David Gibson Cc: Frank Rowand , Rob Herring , Pantelis Antoniou , Vincent Guittot , Masahiro Yamada , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bill Mills , anmar.oueja@linaro.org Subject: Re: [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay Message-ID: <20210121065728.trqph5uwvp43k46l@vireshk-i7> References: <696c137461be8ec4395c733c559c269bb4ad586e.1611124778.git.viresh.kumar@linaro.org> <20210121005145.GF5174@yekko.fritz.box> <7d6adfd9-da1e-d4ca-3a04-b192f0cf36b0@gmail.com> <20210121053426.4dw5oqz7qb4y7hvm@vireshk-i7> <20210121063438.GJ5174@yekko.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210121063438.GJ5174@yekko.fritz.box> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-01-21, 17:34, David Gibson wrote: > No, this is the wrong way around. The expected operation here is that > you apply overlay (1) to the base tree, giving you, say, output1.dtb. > output1.dtb is (effectively) a base tree itself, to which you can then > apply overlay-(2). Thanks for the confirmation about this. > Merging overlays is > something that could make sense, but fdtoverlay will not do it at > present. FWIW, I think it works fine right now even if it not intentional. I did inspect the output dtb (made by merging two overlays) using fdtdump and it looked okay. But yeah, I understand that we shouldn't do it. -- viresh