* [PATCH] usb: typec: tcpci_maxim: Drop GPIO includes
@ 2021-01-20 22:50 Linus Walleij
2021-01-21 3:59 ` Guenter Roeck
2021-01-21 7:31 ` Heikki Krogerus
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2021-01-20 22:50 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-usb, Linus Walleij, Guenter Roeck, Heikki Krogerus
This driver includes the legacy GPIO header <linux/gpio.h>,
the new GPIO header <linux/gpio/consumer.h> and
the deprecated OF GPIO header <linux/of_gpio.h> yet
fail to use symbols from any of them, so drop these
includes.
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/usb/typec/tcpm/tcpci_maxim.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
index 319266329b42..0e2bb1235ab5 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
@@ -5,13 +5,10 @@
* MAXIM TCPCI based TCPC driver
*/
-#include <linux/gpio.h>
-#include <linux/gpio/consumer.h>
#include <linux/interrupt.h>
#include <linux/i2c.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/regmap.h>
#include <linux/usb/pd.h>
#include <linux/usb/tcpm.h>
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: typec: tcpci_maxim: Drop GPIO includes
2021-01-20 22:50 [PATCH] usb: typec: tcpci_maxim: Drop GPIO includes Linus Walleij
@ 2021-01-21 3:59 ` Guenter Roeck
2021-01-21 7:31 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-01-21 3:59 UTC (permalink / raw)
To: Linus Walleij, Greg Kroah-Hartman; +Cc: linux-usb, Heikki Krogerus
On 1/20/21 2:50 PM, Linus Walleij wrote:
> This driver includes the legacy GPIO header <linux/gpio.h>,
> the new GPIO header <linux/gpio/consumer.h> and
> the deprecated OF GPIO header <linux/of_gpio.h> yet
> fail to use symbols from any of them, so drop these
> includes.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpci_maxim.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 319266329b42..0e2bb1235ab5 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -5,13 +5,10 @@
> * MAXIM TCPCI based TCPC driver
> */
>
> -#include <linux/gpio.h>
> -#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/i2c.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/regmap.h>
> #include <linux/usb/pd.h>
> #include <linux/usb/tcpm.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: typec: tcpci_maxim: Drop GPIO includes
2021-01-20 22:50 [PATCH] usb: typec: tcpci_maxim: Drop GPIO includes Linus Walleij
2021-01-21 3:59 ` Guenter Roeck
@ 2021-01-21 7:31 ` Heikki Krogerus
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2021-01-21 7:31 UTC (permalink / raw)
To: Linus Walleij; +Cc: Greg Kroah-Hartman, linux-usb, Guenter Roeck
On Wed, Jan 20, 2021 at 11:50:45PM +0100, Linus Walleij wrote:
> This driver includes the legacy GPIO header <linux/gpio.h>,
> the new GPIO header <linux/gpio/consumer.h> and
> the deprecated OF GPIO header <linux/of_gpio.h> yet
> fail to use symbols from any of them, so drop these
> includes.
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_maxim.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 319266329b42..0e2bb1235ab5 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -5,13 +5,10 @@
> * MAXIM TCPCI based TCPC driver
> */
>
> -#include <linux/gpio.h>
> -#include <linux/gpio/consumer.h>
> #include <linux/interrupt.h>
> #include <linux/i2c.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/regmap.h>
> #include <linux/usb/pd.h>
> #include <linux/usb/tcpm.h>
> --
> 2.29.2
thanks,
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-21 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 22:50 [PATCH] usb: typec: tcpci_maxim: Drop GPIO includes Linus Walleij
2021-01-21 3:59 ` Guenter Roeck
2021-01-21 7:31 ` Heikki Krogerus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.