From: Mike Rapoport <rppt@kernel.org>
To: Yun Levi <ppbuk5246@gmail.com>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, inux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/memblock: Fix the typo on comments.
Date: Thu, 21 Jan 2021 10:39:42 +0200 [thread overview]
Message-ID: <20210121083942.GT1106298@kernel.org> (raw)
In-Reply-To: <CAM7-yPR_xX7G_=-bJO2Gq_U9cSptaVkzjcwCstRZD+kDK1y+VA@mail.gmail.com>
On Thu, Jan 21, 2021 at 08:43:20AM +0900, Yun Levi wrote:
> > subject would be clearer as something like
> >
> > "mm/memblock: Fix typo in comment of memblock_phys_alloc_try_nid()"
> >
> > Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Thanks. Then, should I resend this patch with suggested subject with
> Reviewed-by tag?
In general, yes. When there are minor review comments and Reviewed-by tag,
you should send v2 version of a patch that addresses the comments and has
the Reviewed-by tag.
Since this is a small patch and a small update, I've applied the patch with
the subject David suggested to memblock/fixes branch.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2021-01-21 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 12:28 [PATCH] mm/memblock: Fix the typo on comments Levi Yun
2021-01-20 13:56 ` David Hildenbrand
2021-01-20 23:43 ` Yun Levi
2021-01-21 8:39 ` Mike Rapoport [this message]
2021-01-21 11:20 ` Yun Levi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121083942.GT1106298@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=inux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ppbuk5246@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.