From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 7/8] meson: Display cryto-related information altogether
Date: Thu, 21 Jan 2021 10:13:08 +0000 [thread overview]
Message-ID: <20210121101308.GA3126480@redhat.com> (raw)
In-Reply-To: <20210121101127.GF3125227@redhat.com>
On Thu, Jan 21, 2021 at 10:11:32AM +0000, Daniel P. Berrangé wrote:
> On Thu, Jan 21, 2021 at 10:56:15AM +0100, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > Cc: Daniel P. Berrange <berrange@redhat.com>
> > ---
> > meson.build | 34 +++++++++++++++++++---------------
> > 1 file changed, 19 insertions(+), 15 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index e372b69f163..9274775a81a 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -2453,19 +2453,8 @@
> > endif
> > summary(summary_info, bool_yn: true, section: 'Block layer support')
> >
> > +# Crypto
>
> Rather than a comment why not introduce grouping in the output
> so it is visible when reading the summary.
>
> This can be done in meson by calling summary() multiple times
> giving "section: 'Crypto'" arg.
Sigh, I'm not very good at reading this morning. I see this
is in fact done in this patch, I just couldn't see it in the
diff :-(
...
> > +summary(summary_info, bool_yn: true, section: 'Crypto')
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-01-21 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 9:56 [PATCH v2 0/8] meson: Clarify summary Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 1/8] meson: Summarize information related to directories first Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 2/8] meson: Display host binaries information altogether Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 3/8] meson: Summarize overall features altogether Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 4/8] meson: Summarize compilation-related information altogether Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 5/8] meson: Display accelerators and selected targets altogether Philippe Mathieu-Daudé
2021-01-21 9:56 ` [RFC PATCH v2 6/8] meson: Display block layer information altogether Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 7/8] meson: Display cryto-related " Philippe Mathieu-Daudé
2021-01-21 9:58 ` Philippe Mathieu-Daudé
2021-01-21 10:11 ` Daniel P. Berrangé
2021-01-21 10:13 ` Daniel P. Berrangé [this message]
2021-01-21 11:01 ` Philippe Mathieu-Daudé
2021-01-21 9:56 ` [PATCH v2 8/8] meson: Display library dependencies altogether Philippe Mathieu-Daudé
2021-01-21 12:03 ` [PATCH v2 0/8] meson: Clarify summary Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121101308.GA3126480@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.