From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC680C43381 for ; Fri, 22 Jan 2021 08:46:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E231236F9 for ; Fri, 22 Jan 2021 08:46:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E231236F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E80756E9BC; Fri, 22 Jan 2021 08:45:57 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 788476E52D for ; Thu, 21 Jan 2021 11:04:09 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E00615C0081; Thu, 21 Jan 2021 06:04:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 21 Jan 2021 06:04:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=BdC6sBpfkqeuRKbr+YS2x3XOUsy 005Dr/ViXrL61NFk=; b=aDs6Dtzv8ag0v/0OXCRHZaCiLqFRU9NR2LJX3no7/5P oiKo0TNRe/TvB/YYUZ/jZZIkQEpJrPzX/EGprWCG3HRoY5tCc/EAe4WN4FHvZZEb EIuWe+y18XKUmNvgOeGnQYxc49ksvNLfutXtdh5jz5D87/OQ62HJrykQXhb58AW8 hwSuVdXRRRWOY4U/0/Fe7D+yWT/3j5OJtqXw1wTRiLljsdJncDF3Q32y1mFKPhC8 vE4pxZ+nD38Y6DxZJsi9DmxvKEGP02fa0GbFxLLCvVypWV3PfC4oTWd1Cg7riGru lggjx8VnM03uJb31JiTwnEflQFXJgmIqpnCfABJWgiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=BdC6sB pfkqeuRKbr+YS2x3XOUsy005Dr/ViXrL61NFk=; b=euGOwYB9bR45t+dC23Xcgy NtVSS5qyte5VMfvKQsFiogJd6hp3oJmBs6biXHF5UKpmTBFoxKycWpapgUiXzOON 6FxuaxmLGGw8acRRR46JGogBXzR3D3fASXKnVd5jVUl0EkA0nbsVi/4iKuC8N460 QHOEQ+MF1O8/gtn2W3gWTubGYRRLzsmn722KmVRqTwD9OcCLDZ0yuTtcjm0B756f 62iaoCy72yrS1gF7o8O/5JLMG64MGudRTWNFOVKSmxyeb8CZYiJHV12PRVlPkVNq xCii5SL345bYKkVn1iZHbc9I+fi+NrsZwyzhQF2NZz5KClzTyKXbCk4672PTDsuw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeggddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 0003F240066; Thu, 21 Jan 2021 06:04:07 -0500 (EST) Date: Thu, 21 Jan 2021 12:04:06 +0100 From: Maxime Ripard To: Lucas Nussbaum , Ryutaroh Matsumoto Subject: Re: [PATCH 1/2] drm/vc4: Correct lbm size and calculation Message-ID: <20210121110406.yeb4zoqwwgilyrhq@gilmour> References: <20210121105759.1262699-1-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: <20210121105759.1262699-1-maxime@cerno.tech> X-Mailman-Approved-At: Fri, 22 Jan 2021 08:45:43 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dom Cobley , dri-devel@lists.freedesktop.org, Dave Stevenson Content-Type: multipart/mixed; boundary="===============0537990099==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0537990099== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vwouope6l6r7ww7z" Content-Disposition: inline --vwouope6l6r7ww7z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Lucas, Ryutaroh, On Thu, Jan 21, 2021 at 11:57:58AM +0100, Maxime Ripard wrote: > From: Dom Cobley >=20 > LBM base address is measured in units of pixels per cycle. > That is 4 for 2711 (hvs5) and 2 for 2708. >=20 > We are wasting 75% of lbm by indexing without the scaling. > But we were also using too high a size for the lbm resulting > in partial corruption (right hand side) of vertically > scaled images, usually at 4K or lower resolutions with more layers. >=20 > The physical RAM of LBM on 2711 is 8 * 1920 * 16 * 12-bit > (pixels are stored 12-bits per component regardless of format). >=20 > The LBM adress indexes work in units of pixels per clock, > so for 4 pixels per clock that means we have 32 * 1920 =3D 60K >=20 > Fixes: c54619b0bfb3 ("drm/vc4: Add support for the BCM2711 HVS5") > Signed-off-by: Dom Cobley > Signed-off-by: Maxime Ripard This one should fix your issue Feel free to test it and let me know if it's not the case Maxime --vwouope6l6r7ww7z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYAlfpgAKCRDj7w1vZxhR xaBXAP0fiKQIxEzL81OKhR7b4IXJ/WrKoh15kNgOJP7kl1hCcQEArSxNfjGY4J1m 93cw+K/4shynPUohViNPfQ89sbN2CA4= =t052 -----END PGP SIGNATURE----- --vwouope6l6r7ww7z-- --===============0537990099== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0537990099==--