From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A2AC433E0 for ; Thu, 21 Jan 2021 13:23:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA6DE20691 for ; Thu, 21 Jan 2021 13:23:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731994AbhAUNW1 (ORCPT ); Thu, 21 Jan 2021 08:22:27 -0500 Received: from foss.arm.com ([217.140.110.172]:36380 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731795AbhAUNU6 (ORCPT ); Thu, 21 Jan 2021 08:20:58 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87CD0139F; Thu, 21 Jan 2021 05:20:12 -0800 (PST) Received: from e119884-lin.cambridge.arm.com (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E33A3F68F; Thu, 21 Jan 2021 05:20:11 -0800 (PST) From: Vincenzo Frascino To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Cc: Vincenzo Frascino , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Leon Romanovsky , Andrey Konovalov , Catalin Marinas , Will Deacon Subject: [PATCH v2 2/2] kasan: Add explicit preconditions to kasan_report() Date: Thu, 21 Jan 2021 13:19:56 +0000 Message-Id: <20210121131956.23246-3-vincenzo.frascino@arm.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210121131956.23246-1-vincenzo.frascino@arm.com> References: <20210121131956.23246-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With the introduction of KASAN_HW_TAGS, kasan_report() dereferences the address passed as a parameter. Add a comment to make sure that the preconditions to the function are explicitly clarified. Note: An invalid address (e.g. NULL) passed to the function when, KASAN_HW_TAGS is enabled, leads to a kernel panic. Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Dmitry Vyukov Cc: Leon Romanovsky Cc: Andrey Konovalov Signed-off-by: Vincenzo Frascino --- mm/kasan/kasan.h | 2 +- mm/kasan/report.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index cc4d9e1d49b1..8c706e7652f2 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -209,7 +209,7 @@ bool check_memory_region(unsigned long addr, size_t size, bool write, static inline bool addr_has_metadata(const void *addr) { - return true; + return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); } #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ diff --git a/mm/kasan/report.c b/mm/kasan/report.c index c0fb21797550..8b690091cb37 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -403,6 +403,13 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, end_report(&flags); } +/** + * kasan_report - report kasan fault details + * @addr: valid address of the allocation where the tag fault was detected + * @size: size of the allocation where the tag fault was detected + * @is_write: the instruction that caused the fault was a read or write? + * @ip: pointer to the instruction that cause the fault + */ bool kasan_report(unsigned long addr, size_t size, bool is_write, unsigned long ip) { -- 2.30.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5BEC433E6 for ; Thu, 21 Jan 2021 13:22:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D93620691 for ; Thu, 21 Jan 2021 13:22:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D93620691 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QLgqaHSlLSXxNy18cC3C5TiZrgQZ7Qvp7IYq0bqZCoI=; b=PQEC6uDzOpOfCIuNfKeNJ2Rub hdi73PWXH9W9MmjPHuQbKpSGoLx03rqdxFeR8O1enKS/UZdLi++hhdU8eLSv0eTNY7XxMUirXBEqM 3yT7OIaGcbpda8vEtgVJKaQQI9VrSfkUcvIFoDj6zYj9saSRJ4cawTL//cSuxFJsyyXueqpNkOMuH G6rh3i11XZ5Mw+vKFswJtB7czZwb79sbBs0/uAOAt71eo6N8BicHi9O5+9L8ycU9grlzBdfcrMI1p vDezHR79sd1sTcwqGVCqziZ9rju0P4D/yVImyU+uCcLrOV+IXeuATn4mdqjgDBAc6mLXVs+ESarTP evaWbkHEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Zsr-0005ti-AQ; Thu, 21 Jan 2021 13:20:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2Zsj-0005sE-Ex for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 13:20:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87CD0139F; Thu, 21 Jan 2021 05:20:12 -0800 (PST) Received: from e119884-lin.cambridge.arm.com (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E33A3F68F; Thu, 21 Jan 2021 05:20:11 -0800 (PST) From: Vincenzo Frascino To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com Subject: [PATCH v2 2/2] kasan: Add explicit preconditions to kasan_report() Date: Thu, 21 Jan 2021 13:19:56 +0000 Message-Id: <20210121131956.23246-3-vincenzo.frascino@arm.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210121131956.23246-1-vincenzo.frascino@arm.com> References: <20210121131956.23246-1-vincenzo.frascino@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_082013_584248_B6084D03 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Konovalov , Leon Romanovsky , Alexander Potapenko , Catalin Marinas , Andrey Ryabinin , Vincenzo Frascino , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org With the introduction of KASAN_HW_TAGS, kasan_report() dereferences the address passed as a parameter. Add a comment to make sure that the preconditions to the function are explicitly clarified. Note: An invalid address (e.g. NULL) passed to the function when, KASAN_HW_TAGS is enabled, leads to a kernel panic. Cc: Andrey Ryabinin Cc: Alexander Potapenko Cc: Dmitry Vyukov Cc: Leon Romanovsky Cc: Andrey Konovalov Signed-off-by: Vincenzo Frascino --- mm/kasan/kasan.h | 2 +- mm/kasan/report.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index cc4d9e1d49b1..8c706e7652f2 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -209,7 +209,7 @@ bool check_memory_region(unsigned long addr, size_t size, bool write, static inline bool addr_has_metadata(const void *addr) { - return true; + return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); } #endif /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ diff --git a/mm/kasan/report.c b/mm/kasan/report.c index c0fb21797550..8b690091cb37 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -403,6 +403,13 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, end_report(&flags); } +/** + * kasan_report - report kasan fault details + * @addr: valid address of the allocation where the tag fault was detected + * @size: size of the allocation where the tag fault was detected + * @is_write: the instruction that caused the fault was a read or write? + * @ip: pointer to the instruction that cause the fault + */ bool kasan_report(unsigned long addr, size_t size, bool is_write, unsigned long ip) { -- 2.30.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel