From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17036C433E6 for ; Thu, 21 Jan 2021 14:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D412A238A1 for ; Thu, 21 Jan 2021 14:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730933AbhAUNev (ORCPT ); Thu, 21 Jan 2021 08:34:51 -0500 Received: from foss.arm.com ([217.140.110.172]:36720 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732279AbhAUNd1 (ORCPT ); Thu, 21 Jan 2021 08:33:27 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21AEB11B3; Thu, 21 Jan 2021 05:32:39 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.35.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CEB63F68F; Thu, 21 Jan 2021 05:32:37 -0800 (PST) Date: Thu, 21 Jan 2021 13:32:35 +0000 From: Mark Rutland To: Marc Zyngier Cc: Mohamed Mediouni , Arnd Bergmann , Linux ARM , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Will Deacon , Stan Skowronek Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. Message-ID: <20210121133235.GG48431@C02TD0UTHF1T.local> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> <71e94b48857cbdd21c5d6bdadf148621@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <71e94b48857cbdd21c5d6bdadf148621@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 21, 2021 at 01:22:37PM +0000, Marc Zyngier wrote: > On 2021-01-21 12:50, Mohamed Mediouni wrote: > > > On 21 Jan 2021, at 13:44, Arnd Bergmann wrote: > > > > > > On Wed, Jan 20, 2021 at 2:27 PM Mohamed Mediouni > > [...] > > > > > + aic.fast_ipi = of_property_read_bool(node, "fast-ipi"); > > > > > > Where is this property documented, and what decides which one to use? > > It’s getting documented in the next patch set. > > > > This property is there to enable support for older iPhone processors > > later on, some of which do not have fast IPI support. > > > > On Apple M1, fast-ipi is always on. > > Then please focus on a single implementation. Additional features can > always be merged later once something is up and running. > > Also, there sysregs can be detected by matching the MIDR, so I don't > think we need a DT property for that. Generally we do not detect IMP-DEF sysregs based on MIDR because they won't necessarily be exposed to a VM, so I suspect that we do need DT properties to describe that IMP-DEF sysregs are accessible, and should not rely on the MIDR alone. Maybe that's implicit in another property, but worth bearing in mind. Thanks, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCB8C433DB for ; Thu, 21 Jan 2021 13:33:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3200E2245C for ; Thu, 21 Jan 2021 13:33:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3200E2245C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=61Ww6KwIBsYScS4dZX0J0uXRLaJ48uBKF63eSpB5gxk=; b=L0Z+b9Jufdi+fJBnF85FtZIOd z49vafDcWTm54TSxStRMNRT93B+6goJkT3uTjGb/caIP+wgSbr5Rn7+Q3o5A0ODG7vtEXf7NVm+iq WlbKduLJhoJraDLzY/JjtDeDbZZ/ttE1kAlfDhscPQIgUawIsZ1tFHMYKSi92rtwlEQagwkKMNHOG 2erVE2tRfNPCAbPuPfut7l0UO3BmL68c4NaPVHBSNCm/iS8kDLIzmaHFCse/HGnVv7Wvfd234GPfp c43NGMZju13HCgf8Qd+zLd1dOm/yLpJxU2ZvHWJDrsEIpqDzPRCch5RKj/Ay5AyObNo80U4q3+8u0 TmWJzI+xA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2a4q-0007se-FV; Thu, 21 Jan 2021 13:32:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2a4n-0007rr-Ip for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 13:32:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 21AEB11B3; Thu, 21 Jan 2021 05:32:39 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.35.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8CEB63F68F; Thu, 21 Jan 2021 05:32:37 -0800 (PST) Date: Thu, 21 Jan 2021 13:32:35 +0000 From: Mark Rutland To: Marc Zyngier Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple AIC driver. Message-ID: <20210121133235.GG48431@C02TD0UTHF1T.local> References: <20210120132717.395873-1-mohamed.mediouni@caramail.com> <20210120132717.395873-8-mohamed.mediouni@caramail.com> <71e94b48857cbdd21c5d6bdadf148621@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <71e94b48857cbdd21c5d6bdadf148621@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_083241_668328_6D16999E X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Catalin Marinas , Hector Martin , linux-kernel@vger.kernel.org, Mohamed Mediouni , Will Deacon , Linux ARM , Stan Skowronek Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKYW4gMjEsIDIwMjEgYXQgMDE6MjI6MzdQTSArMDAwMCwgTWFyYyBaeW5naWVyIHdy b3RlOgo+IE9uIDIwMjEtMDEtMjEgMTI6NTAsIE1vaGFtZWQgTWVkaW91bmkgd3JvdGU6Cj4gPiA+ IE9uIDIxIEphbiAyMDIxLCBhdCAxMzo0NCwgQXJuZCBCZXJnbWFubiA8YXJuZEBrZXJuZWwub3Jn PiB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIFdlZCwgSmFuIDIwLCAyMDIxIGF0IDI6MjcgUE0gTW9o YW1lZCBNZWRpb3VuaQo+IAo+IFsuLi5dCj4gCj4gPiA+ID4gKyAgICAgICBhaWMuZmFzdF9pcGkg PSBvZl9wcm9wZXJ0eV9yZWFkX2Jvb2wobm9kZSwgImZhc3QtaXBpIik7Cj4gPiA+IAo+ID4gPiBX aGVyZSBpcyB0aGlzIHByb3BlcnR5IGRvY3VtZW50ZWQsIGFuZCB3aGF0IGRlY2lkZXMgd2hpY2gg b25lIHRvIHVzZT8KPiA+IEl04oCZcyBnZXR0aW5nIGRvY3VtZW50ZWQgaW4gdGhlIG5leHQgcGF0 Y2ggc2V0Lgo+ID4gCj4gPiBUaGlzIHByb3BlcnR5IGlzIHRoZXJlIHRvIGVuYWJsZSBzdXBwb3J0 IGZvciBvbGRlciBpUGhvbmUgcHJvY2Vzc29ycwo+ID4gbGF0ZXIgb24sIHNvbWUgb2Ygd2hpY2gg ZG8gbm90IGhhdmUgZmFzdCBJUEkgc3VwcG9ydC4KPiA+IAo+ID4gT24gQXBwbGUgTTEsIGZhc3Qt aXBpIGlzIGFsd2F5cyBvbi4KPiAKPiBUaGVuIHBsZWFzZSBmb2N1cyBvbiBhIHNpbmdsZSBpbXBs ZW1lbnRhdGlvbi4gQWRkaXRpb25hbCBmZWF0dXJlcyBjYW4KPiBhbHdheXMgYmUgbWVyZ2VkIGxh dGVyIG9uY2Ugc29tZXRoaW5nIGlzIHVwIGFuZCBydW5uaW5nLgo+IAo+IEFsc28sIHRoZXJlIHN5 c3JlZ3MgY2FuIGJlIGRldGVjdGVkIGJ5IG1hdGNoaW5nIHRoZSBNSURSLCBzbyBJIGRvbid0Cj4g dGhpbmsgd2UgbmVlZCBhIERUIHByb3BlcnR5IGZvciB0aGF0LgoKR2VuZXJhbGx5IHdlIGRvIG5v dCBkZXRlY3QgSU1QLURFRiBzeXNyZWdzIGJhc2VkIG9uIE1JRFIgYmVjYXVzZSB0aGV5Cndvbid0 IG5lY2Vzc2FyaWx5IGJlIGV4cG9zZWQgdG8gYSBWTSwgc28gSSBzdXNwZWN0IHRoYXQgd2UgZG8g bmVlZCBEVApwcm9wZXJ0aWVzIHRvIGRlc2NyaWJlIHRoYXQgSU1QLURFRiBzeXNyZWdzIGFyZSBh Y2Nlc3NpYmxlLCBhbmQgc2hvdWxkCm5vdCByZWx5IG9uIHRoZSBNSURSIGFsb25lLiBNYXliZSB0 aGF0J3MgaW1wbGljaXQgaW4gYW5vdGhlciBwcm9wZXJ0eSwKYnV0IHdvcnRoIGJlYXJpbmcgaW4g bWluZC4KClRoYW5rcywKTWFyay4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK