All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/4] json: limit: set default burst to 5
Date: Thu, 21 Jan 2021 15:59:34 +0100	[thread overview]
Message-ID: <20210121145934.GA4142@salvia> (raw)
In-Reply-To: <20210121145759.GA4087@salvia>

On Thu, Jan 21, 2021 at 03:57:59PM +0100, Pablo Neira Ayuso wrote:
> Hi Phil,
> 
> On Thu, Jan 21, 2021 at 03:44:14PM +0100, Phil Sutter wrote:
> > Hi!
> > 
> > On Thu, Jan 21, 2021 at 02:55:08PM +0100, Florian Westphal wrote:
> > > The tests fail because json printing omits a burst of 5 and
> > > the parser treats that as 'burst 0'.
> > 
> > While this patch is correct in that it aligns json and bison parser
> > behaviours, I think omitting burst value in JSON output is a bug by
> > itself: We don't care about output length and users are supposed to
> > parse (and thus filter) the information anyway, so there's no gain from
> > omitting such info. I'll address this in a separate patch, though.
> 
> The listing of:
> 
> nft list ruleset
> 
> is already omitting this. Would you prefer this is also exposed there?

I mean, IIRC for json it makes sense to display every field (not omit
anything), so my question is whether you think the native syntax
should omit this or it's fine as it is.

  reply	other threads:[~2021-01-21 15:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 13:55 [PATCH nft 0/4] json test case fixups Florian Westphal
2021-01-21 13:55 ` [PATCH 1/4] json: fix icmpv6.t test cases Florian Westphal
2021-01-21 15:12   ` Phil Sutter
2021-01-21 13:55 ` [PATCH 2/4] json: limit: set default burst to 5 Florian Westphal
2021-01-21 14:44   ` Phil Sutter
2021-01-21 14:57     ` Pablo Neira Ayuso
2021-01-21 14:59       ` Pablo Neira Ayuso [this message]
2021-01-21 15:10         ` Phil Sutter
2021-01-21 13:55 ` [PATCH 3/4] json: ct: add missing rule Florian Westphal
2021-01-21 15:13   ` Phil Sutter
2021-01-21 13:55 ` [PATCH 4/4] json: icmp: refresh json output Florian Westphal
2021-01-21 15:04   ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121145934.GA4142@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.