From: Vinod Koul <vkoul@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding
Date: Thu, 21 Jan 2021 22:36:17 +0530 [thread overview]
Message-ID: <20210121170617.GH2771@vkoul-mobl> (raw)
In-Reply-To: <CACRpkdY6G_EP8QAp1C-eghdbgcgwQezA1ap=nDtSHPNqjuDF6Q@mail.gmail.com>
On 21-01-21, 14:20, Linus Walleij wrote:
> On Wed, Jan 20, 2021 at 11:21 PM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>
> > Several properties are shared between all TLMM bindings. By providing a
> > common binding to define these properties each platform's binding can be
> > reduced to just listing which of these properties should be checked for
> > - or further specified.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Overall it looks good, just cutting some slack for reviewers (especially
> DT people) before applying.
Yeah it does clean stuff up. I have rebased on SM8350 series on top of this, will post soon.
> > +description:
> > + This defines the common properties used to describe all Qualcomm TLMM
> > + bindings and pinconf/pinmux states for these.
>
> I vaguely recall asking you in the past what the acronym TLMM actually
> means. This would be a good place to expand the acronym so people
> know what these four letters actually represent.
It is Top Level Mode Multiplexer (TLMM) it is actually used in the
binding doc :)
>
> (There, I finally gave you an official reason to go and poke Qualcomm
> hardware engineers about this. ;)
>
> Yours,
> Linus Walleij
--
~Vinod
next prev parent reply other threads:[~2021-01-21 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 22:21 [PATCH 0/3] pinctrl: qcom: TLMM driver for SC8180x Bjorn Andersson
2021-01-20 22:21 ` [PATCH 1/3] dt-bindings: pinctrl: qcom: Define common TLMM binding Bjorn Andersson
2021-01-21 13:20 ` Linus Walleij
2021-01-21 17:06 ` Vinod Koul [this message]
2021-01-21 17:18 ` Bjorn Andersson
2021-01-20 22:21 ` [PATCH 2/3] dt-bindings: pinctrl: qcom: Add sc8180x binding Bjorn Andersson
2021-01-20 22:21 ` [PATCH 3/3] pinctrl: qcom: Add sc8180x TLMM driver Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121170617.GH2771@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.