From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C27C433E9 for ; Thu, 21 Jan 2021 18:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75C8223A03 for ; Thu, 21 Jan 2021 18:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389505AbhAUSC4 (ORCPT ); Thu, 21 Jan 2021 13:02:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:53972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388958AbhAURzG (ORCPT ); Thu, 21 Jan 2021 12:55:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 414C621973; Thu, 21 Jan 2021 17:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611251665; bh=UoorRMvSGUceggy9m7jQ580i3cz0aYpDS1TAbvR/rEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A08rRJRbcUEexudiHrvqmX6AgJwLL+HJOEIqjMdYrhGPSBMaRSmAp77HRfl/uEhJr GDgqkSHYixgVJ6aZ3/d1//Rqo7o8dspi6AgBkV92oCVtU8OZWeDquOIjJBQlyHr9Jv enuXyQFtAe1WvTAfA036bxCKVyOZtMOix7roLxWNR7rWsvWNXsmSt56F0bXEfuzusc QjCarXuyOSzhmmsrD1QJxh3oASray65OGKXi5FJGAHdHBjt5uDnPGZOED7AjUNYlps u58NTQShoDQr6IoCETUMwnJNU8EemE1sc/ErtHbnwHv4ZF969qqtAg1Ib3doLCmeSp wp85wTVhx/DZg== Date: Thu, 21 Jan 2021 17:54:20 +0000 From: Will Deacon To: Ard Biesheuvel Cc: Marc Zyngier , Russell King , Catalin Marinas , Andre Przywara , Android Kernel Team , Theodore Ts'o , Mark Brown , Sudeep Holla , Linux Kernel Mailing List , Linus Walleij , kvmarm , Lorenzo Pieralisi , Linux ARM Subject: Re: [PATCH v6 0/5] ARM: arm64: Add SMCCC TRNG entropy service Message-ID: <20210121175419.GA22963@willie-the-truck> References: <20210106103453.152275-1-andre.przywara@arm.com> <161114590396.218530.9227813162726341261.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 02:15:59PM +0100, Ard Biesheuvel wrote: > On Wed, 20 Jan 2021 at 14:01, Will Deacon wrote: > > > > On Wed, 6 Jan 2021 10:34:48 +0000, Andre Przywara wrote: > > > a fix to v5, now *really* fixing the wrong priority of SMCCC vs. RNDR > > > in arch_get_random_seed_long_early(). Apologies for messing this up > > > in v5 and thanks to broonie for being on the watch! > > > > > > Will, Catalin: it would be much appreciated if you could consider taking > > > patch 1/5. This contains the common definitions, and is a prerequisite > > > for every other patch, although they are somewhat independent and likely > > > will need to go through different subsystems. > > > > > > [...] > > > > Applied the first patch only to arm64 (for-next/rng), thanks! > > > > [1/5] firmware: smccc: Add SMCCC TRNG function call IDs > > https://git.kernel.org/arm64/c/67c6bb56b649 > > > > What's the plan for the rest of the series, and I think the related > > change over at [1]? > > > > Given that Ted seems to have lost interest in /dev/random patches, I > was hoping [1] could be taken via the arm64 tree instead. Without this > patch, I don't think we should expose the SMCCC RNG interface via > arch_get_random_seed(), given how insanely often it will be called in > that case. Ok, let's give that a shot -- I'll additionally pick patches 2 and 4 out of this series, and merge in the /dev/random change on its own branch in case there are any late objections. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E438C433E0 for ; Thu, 21 Jan 2021 17:54:32 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id CB96E207C5 for ; Thu, 21 Jan 2021 17:54:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB96E207C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F402F4B156; Thu, 21 Jan 2021 12:54:30 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HXn1Fr5z4iOG; Thu, 21 Jan 2021 12:54:30 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id F02AA4B159; Thu, 21 Jan 2021 12:54:29 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1BE854B156 for ; Thu, 21 Jan 2021 12:54:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ex+eyCKSK23Y for ; Thu, 21 Jan 2021 12:54:27 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id DDCBA4B0B6 for ; Thu, 21 Jan 2021 12:54:26 -0500 (EST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 414C621973; Thu, 21 Jan 2021 17:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611251665; bh=UoorRMvSGUceggy9m7jQ580i3cz0aYpDS1TAbvR/rEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A08rRJRbcUEexudiHrvqmX6AgJwLL+HJOEIqjMdYrhGPSBMaRSmAp77HRfl/uEhJr GDgqkSHYixgVJ6aZ3/d1//Rqo7o8dspi6AgBkV92oCVtU8OZWeDquOIjJBQlyHr9Jv enuXyQFtAe1WvTAfA036bxCKVyOZtMOix7roLxWNR7rWsvWNXsmSt56F0bXEfuzusc QjCarXuyOSzhmmsrD1QJxh3oASray65OGKXi5FJGAHdHBjt5uDnPGZOED7AjUNYlps u58NTQShoDQr6IoCETUMwnJNU8EemE1sc/ErtHbnwHv4ZF969qqtAg1Ib3doLCmeSp wp85wTVhx/DZg== Date: Thu, 21 Jan 2021 17:54:20 +0000 From: Will Deacon To: Ard Biesheuvel Subject: Re: [PATCH v6 0/5] ARM: arm64: Add SMCCC TRNG entropy service Message-ID: <20210121175419.GA22963@willie-the-truck> References: <20210106103453.152275-1-andre.przywara@arm.com> <161114590396.218530.9227813162726341261.b4-ty@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Lorenzo Pieralisi , Theodore Ts'o , Marc Zyngier , Linus Walleij , Sudeep Holla , Russell King , Linux Kernel Mailing List , Catalin Marinas , Mark Brown , Andre Przywara , Android Kernel Team , kvmarm , Linux ARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Jan 20, 2021 at 02:15:59PM +0100, Ard Biesheuvel wrote: > On Wed, 20 Jan 2021 at 14:01, Will Deacon wrote: > > > > On Wed, 6 Jan 2021 10:34:48 +0000, Andre Przywara wrote: > > > a fix to v5, now *really* fixing the wrong priority of SMCCC vs. RNDR > > > in arch_get_random_seed_long_early(). Apologies for messing this up > > > in v5 and thanks to broonie for being on the watch! > > > > > > Will, Catalin: it would be much appreciated if you could consider taking > > > patch 1/5. This contains the common definitions, and is a prerequisite > > > for every other patch, although they are somewhat independent and likely > > > will need to go through different subsystems. > > > > > > [...] > > > > Applied the first patch only to arm64 (for-next/rng), thanks! > > > > [1/5] firmware: smccc: Add SMCCC TRNG function call IDs > > https://git.kernel.org/arm64/c/67c6bb56b649 > > > > What's the plan for the rest of the series, and I think the related > > change over at [1]? > > > > Given that Ted seems to have lost interest in /dev/random patches, I > was hoping [1] could be taken via the arm64 tree instead. Without this > patch, I don't think we should expose the SMCCC RNG interface via > arch_get_random_seed(), given how insanely often it will be called in > that case. Ok, let's give that a shot -- I'll additionally pick patches 2 and 4 out of this series, and merge in the /dev/random change on its own branch in case there are any late objections. Will _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABD8FC433DB for ; Thu, 21 Jan 2021 17:55:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 556BB22CE3 for ; Thu, 21 Jan 2021 17:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 556BB22CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xpdXLViG6Dy0WEOEAOkmHJtDuRVhXqNhTg55FDrg3v0=; b=LVQXY4QlWabg4FYvCTMxnLl3e 179h6cWniGnkTA0KaRUeimcL7uBUcTeFh0LEwoG+0fplys2oZZYGoVEW3qq3N/MCL3mt4dP+Mk5Nq oAZVV2Fp2fBSZd1Hcd0Ecyui5xsbnOSzeL7scOTlt9+mJ5i3SO44K4+6y2Ki7MYVbFrV9vXcO1Ex9 v25tH1gwVQ5EamRHHKM5YuwJqIpUuyTZCdAQlliBbVAYS4DQY9MWsuRTqHz+8JeJ9TuOgjAeHuTJK NFnuEhzg0ll2D8MUKabZRgqh3aoAydAkn6wROWGIDUw4eZ/49ghE2inYz40dFEcKpdWAk/JODTbwF pHCrHjO0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2eA9-0006qf-WD; Thu, 21 Jan 2021 17:54:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2eA6-0006oq-Mh for linux-arm-kernel@lists.infradead.org; Thu, 21 Jan 2021 17:54:27 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 414C621973; Thu, 21 Jan 2021 17:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611251665; bh=UoorRMvSGUceggy9m7jQ580i3cz0aYpDS1TAbvR/rEk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A08rRJRbcUEexudiHrvqmX6AgJwLL+HJOEIqjMdYrhGPSBMaRSmAp77HRfl/uEhJr GDgqkSHYixgVJ6aZ3/d1//Rqo7o8dspi6AgBkV92oCVtU8OZWeDquOIjJBQlyHr9Jv enuXyQFtAe1WvTAfA036bxCKVyOZtMOix7roLxWNR7rWsvWNXsmSt56F0bXEfuzusc QjCarXuyOSzhmmsrD1QJxh3oASray65OGKXi5FJGAHdHBjt5uDnPGZOED7AjUNYlps u58NTQShoDQr6IoCETUMwnJNU8EemE1sc/ErtHbnwHv4ZF969qqtAg1Ib3doLCmeSp wp85wTVhx/DZg== Date: Thu, 21 Jan 2021 17:54:20 +0000 From: Will Deacon To: Ard Biesheuvel Subject: Re: [PATCH v6 0/5] ARM: arm64: Add SMCCC TRNG entropy service Message-ID: <20210121175419.GA22963@willie-the-truck> References: <20210106103453.152275-1-andre.przywara@arm.com> <161114590396.218530.9227813162726341261.b4-ty@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210121_125426_814333_34E7A0C8 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Theodore Ts'o , Marc Zyngier , Linus Walleij , Sudeep Holla , Russell King , Linux Kernel Mailing List , Catalin Marinas , Mark Brown , Andre Przywara , Android Kernel Team , kvmarm , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 20, 2021 at 02:15:59PM +0100, Ard Biesheuvel wrote: > On Wed, 20 Jan 2021 at 14:01, Will Deacon wrote: > > > > On Wed, 6 Jan 2021 10:34:48 +0000, Andre Przywara wrote: > > > a fix to v5, now *really* fixing the wrong priority of SMCCC vs. RNDR > > > in arch_get_random_seed_long_early(). Apologies for messing this up > > > in v5 and thanks to broonie for being on the watch! > > > > > > Will, Catalin: it would be much appreciated if you could consider taking > > > patch 1/5. This contains the common definitions, and is a prerequisite > > > for every other patch, although they are somewhat independent and likely > > > will need to go through different subsystems. > > > > > > [...] > > > > Applied the first patch only to arm64 (for-next/rng), thanks! > > > > [1/5] firmware: smccc: Add SMCCC TRNG function call IDs > > https://git.kernel.org/arm64/c/67c6bb56b649 > > > > What's the plan for the rest of the series, and I think the related > > change over at [1]? > > > > Given that Ted seems to have lost interest in /dev/random patches, I > was hoping [1] could be taken via the arm64 tree instead. Without this > patch, I don't think we should expose the SMCCC RNG interface via > arch_get_random_seed(), given how insanely often it will be called in > that case. Ok, let's give that a shot -- I'll additionally pick patches 2 and 4 out of this series, and merge in the /dev/random change on its own branch in case there are any late objections. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel